Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all_files options for clang-format check #24640

Merged
merged 2 commits into from Nov 5, 2019
Merged

Remove all_files options for clang-format check #24640

merged 2 commits into from Nov 5, 2019

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Nov 4, 2019

fix #24638
paulrouget added 2 commits Nov 4, 2019
@paulrouget
remove allfiles option for clang-format
b1753fe
@paulrouget
CPP formating
Loading status checks…
ddbb0d5
@highfive
Copy link

highfive commented Nov 4, 2019

Heads up! This PR modifies the following files:
@jdm
Copy link
Member

jdm commented Nov 4, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2019

📌 Commit ddbb0d5 has been approved by jdm
@highfive highfive assigned jdm and unassigned SimonSapin Nov 4, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2019

⌛ Testing commit ddbb0d5 with merge 7e77aac...
bors-servo added a commit that referenced this pull request Nov 4, 2019
@bors-servo
Auto merge of #24640 - paulrouget:no-allfiles-opt, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7e77aac 
Remove all_files options for clang-format check

fix #24638
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2019

💔 Test failed - linux-rel-css
@jdm
Copy link
Member

jdm commented Nov 4, 2019 •
edited

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2019

💣 Failed to start rebuilding: Unknown error
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2019

⌛ Testing commit ddbb0d5 with merge 8263b77...
bors-servo added a commit that referenced this pull request Nov 4, 2019
@bors-servo
Auto merge of #24640 - paulrouget:no-allfiles-opt, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8263b77 
Remove all_files options for clang-format check

fix #24638
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Nov 4, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2019

💣 Failed to start rebuilding: Unknown error
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2019

⌛ Testing commit ddbb0d5 with merge 678f95f...
bors-servo added a commit that referenced this pull request Nov 4, 2019
@bors-servo
Auto merge of #24640 - paulrouget:no-allfiles-opt, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
678f95f 
Remove all_files options for clang-format check

fix #24638
@highfive highfive removed the S-tests-failed label Nov 4, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2019

💔 Test failed - linux-rel-css
@jdm
Copy link
Member

jdm commented Nov 4, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2019

⌛ Testing commit ddbb0d5 with merge 6d0eb01...
bors-servo added a commit that referenced this pull request Nov 4, 2019
@bors-servo
Auto merge of #24640 - paulrouget:no-allfiles-opt, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6d0eb01 
Remove all_files options for clang-format check

fix #24638
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Nov 4, 2019 •
edited

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 5, 2019

⌛ Testing commit ddbb0d5 with merge 593f8bd...
bors-servo added a commit that referenced this pull request Nov 5, 2019
@bors-servo
Auto merge of #24640 - paulrouget:no-allfiles-opt, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
593f8bd 
Remove all_files options for clang-format check

fix #24638
@bors-servo
Copy link
Contributor

bors-servo commented Nov 5, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing 593f8bd to master...
@bors-servo bors-servo merged commit ddbb0d5 into servo:master Nov 5, 2019
2 checks passed
2 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

The "all files" option for test-tidy + clang-format doesn't make sense
5 participants
@paulrouget @highfive @jdm @bors-servo @SimonSapin
You can’t perform that action at this time.