Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to cancel the task. The thread is ending. #24646

Merged
merged 1 commit into from Nov 7, 2019
Merged

No need to cancel the task. The thread is ending. #24646

merged 1 commit into from Nov 7, 2019
+0 −1

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Nov 4, 2019

Fix #24635
@paulrouget
No need to cancel the task. The thread is ending.
Loading status checks…
f11132f
@paulrouget
Copy link
Contributor Author

paulrouget commented Nov 4, 2019

For the record: cancel_current_task() mark the task as ending. We don't need to rely on this as we already have our own flag (mLooping).
@jdm
Copy link
Member

jdm commented Nov 4, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 4, 2019

📌 Commit f11132f has been approved by jdm
@highfive highfive assigned jdm and unassigned SimonSapin Nov 4, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2019

⌛ Testing commit f11132f with merge 20894a3...
bors-servo added a commit that referenced this pull request Nov 6, 2019
@bors-servo
Auto merge of #24646 - paulrouget:nocancel, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
20894a3 
No need to cancel the task. The thread is ending.

Fix #24635
@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2019

💔 Test failed - status-taskcluster
@CYBAI
Copy link
Collaborator

CYBAI commented Nov 6, 2019

@bors-servo retry
bors-servo added a commit that referenced this pull request Nov 6, 2019
@bors-servo
Auto merge of #24646 - paulrouget:nocancel, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e34b8f2 
No need to cancel the task. The thread is ending.

Fix #24635
@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2019

⌛ Testing commit f11132f with merge e34b8f2...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Nov 6, 2019

@bors-servo retry

  • network issues
@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2019

💣 Failed to start rebuilding: Unknown error
bors-servo added a commit that referenced this pull request Nov 6, 2019
@bors-servo
Auto merge of #24646 - paulrouget:nocancel, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
17619e2 
No need to cancel the task. The thread is ending.

Fix #24635
@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2019

⌛ Testing commit f11132f with merge 17619e2...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Nov 6, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2019

💣 Failed to start rebuilding: Unknown error
@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2019

⌛ Testing commit f11132f with merge efb1d58...
bors-servo added a commit that referenced this pull request Nov 6, 2019
@bors-servo
Auto merge of #24646 - paulrouget:nocancel, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
efb1d58 
No need to cancel the task. The thread is ending.

Fix #24635
@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2019

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member

jdm commented Nov 6, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 6, 2019

⌛ Testing commit f11132f with merge b21cf18...
bors-servo added a commit that referenced this pull request Nov 6, 2019
@bors-servo
Auto merge of #24646 - paulrouget:nocancel, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b21cf18 
No need to cancel the task. The thread is ending.

Fix #24635
@bors-servo
Copy link
Contributor

bors-servo commented Nov 7, 2019

💔 Test failed - status-taskcluster
@CYBAI
Copy link
Collaborator

CYBAI commented Nov 7, 2019

@bors-servo retry
@CYBAI
Copy link
Collaborator

CYBAI commented Nov 7, 2019

👆 #16783
@bors-servo
Copy link
Contributor

bors-servo commented Nov 7, 2019

💣 Failed to start rebuilding: Unknown error
@bors-servo
Copy link
Contributor

bors-servo commented Nov 7, 2019

⌛ Testing commit f11132f with merge 64560ec...
bors-servo added a commit that referenced this pull request Nov 7, 2019
@bors-servo
Auto merge of #24646 - paulrouget:nocancel, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
64560ec 
No need to cancel the task. The thread is ending.

Fix #24635
@bors-servo
Copy link
Contributor

bors-servo commented Nov 7, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing 64560ec to master...
@bors-servo bors-servo merged commit f11132f into servo:master Nov 7, 2019
2 checks passed
2 checks passed
Taskcluster (pull_request) TaskGroup: success
Details
homu Test successful
Details
@SimonSapin SimonSapin mentioned this pull request Dec 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

uwp: cancel_current_task() throws at shutdown
6 participants
@paulrouget @jdm @bors-servo @CYBAI @SimonSapin @highfive
You can’t perform that action at this time.