Remove patched webxr #24676

Manishearth · 2019-11-06T17:54:55Z

Unsure if this compiles yet, testing locally.

r? @jdm

Manishearth · 2019-11-06T18:19:53Z

Included in #24657

jdm · 2019-11-06T18:21:36Z

@bors-servo r+

bors-servo · 2019-11-06T18:21:37Z

📌 Commit 5b1fc76 has been approved by jdm

jdm · 2019-11-06T18:28:45Z

@bors-servo r-
This needs a mach fmt.

Manishearth · 2019-11-06T18:45:43Z

@bors-servo r=jdm

bors-servo · 2019-11-06T18:45:44Z

📌 Commit 0b02dec has been approved by jdm

bors-servo · 2019-11-07T07:11:00Z

⌛ Testing commit 0b02dec with merge 14062b2...


        Auto merge of #24676 - Manishearth:unpatch, r=jdm

@jdm

Remove patched webxr Unsure if this compiles yet, testing locally. r? @jdm

bors-servo · 2019-11-07T07:38:21Z

💔 Test failed - linux-rel-css

Manishearth · 2019-11-07T07:44:54Z

Looks like the sparkle update makes some webgl tests fail?

cc @pcwalton

 (view as text)

{
    "status": "FAIL", 
    "group": "default", 
    "message": "assert_true: area outside scissor should be black\nat (0, 16) expected: 0,0,0,0 was 168,132,185,44 expected true got false", 
    "stack": "reportTestResultsToHarness/<@http://web-platform.test:8000/_webgl/js/js-test-pre.js:123:9\nTest.prototype.step@http://web-platform.test:8000/resources/testharness.js:1908:25\ntest@http://web-platform.test:8000/resources/testharness.js:544:30\nreportTestResultsToHarness@http://web-platform.test:8000/_webgl/js/js-test-pre.js:122:7\ntestFailed@http://web-platform.test:8000/_webgl/js/js-test-pre.js:249:5\ncheckCanvasRect/<@http://web-platform.test:8000/_webgl/js/webgl-test-utils.js:1269:9\ncheckCanvasRectColor@http://web-platform.test:8000/_webgl/js/webgl-test-utils.js:1225:9\ncheckCanvasRect@http://web-platform.test:8000/_webgl/js/webgl-test-utils.js:1257:3\ntestCanvasSizeChange@http://web-platform.test:8000/_webgl/conformance/rendering/gl-scissor-canvas-dimensions.html:87:7\n@http://web-platform.test:8000/_webgl/conformance/rendering/gl-scissor-canvas-dimensions.html:93:1\n", 
    "subtest": "WebGL test #4: area outside scissor should be black\nat (0, 16) expected: 0,0,0,0 was 168,132,185,44", 
    "test": "/_webgl/conformance/rendering/gl-scissor-canvas-dimensions.html", 
    "line": 227306, 
    "action": "test_result", 
    "expected": "PASS"
}
{
    "status": "FAIL", 
    "group": "default", 
    "message": "assert_true: area outside scissor should be black\nat (18, 0) expected: 0,0,0,0 was 3,0,0,0 expected true got false", 
    "stack": "reportTestResultsToHarness/<@http://web-platform.test:8000/_webgl/js/js-test-pre.js:123:9\nTest.prototype.step@http://web-platform.test:8000/resources/testharness.js:1908:25\ntest@http://web-platform.test:8000/resources/testharness.js:544:30\nreportTestResultsToHarness@http://web-platform.test:8000/_webgl/js/js-test-pre.js:122:7\ntestFailed@http://web-platform.test:8000/_webgl/js/js-test-pre.js:249:5\ncheckCanvasRect/<@http://web-platform.test:8000/_webgl/js/webgl-test-utils.js:1269:9\ncheckCanvasRectColor@http://web-platform.test:8000/_webgl/js/webgl-test-utils.js:1225:9\ncheckCanvasRect@http://web-platform.test:8000/_webgl/js/webgl-test-utils.js:1257:3\ntestCanvasSizeChange@http://web-platform.test:8000/_webgl/conformance/rendering/gl-scissor-canvas-dimensions.html:88:7\n@http://web-platform.test:8000/_webgl/conformance/rendering/gl-scissor-canvas-dimensions.html:93:1\n", 
    "subtest": "WebGL test #5: area outside scissor should be black\nat (18, 0) expected: 0,0,0,0 was 3,0,0,0", 
    "test": "/_webgl/conformance/rendering/gl-scissor-canvas-dimensions.html", 
    "line": 227307, 
    "action": "test_result", 
    "expected": "PASS"
}
{
    "status": "FAIL", 
    "group": "default", 
    "message": "assert_true: internal buffers have been initialized to 0\nat (24, 2) expected: 0,0,0,0 was 81,101,0,0 expected true got false", 
    "stack": "reportTestResultsToHarness/<@http://web-platform.test:8000/_webgl/js/js-test-pre.js:123:9\nTest.prototype.step@http://web-platform.test:8000/resources/testharness.js:1908:25\ntest@http://web-platform.test:8000/resources/testharness.js:544:30\nreportTestResultsToHarness@http://web-platform.test:8000/_webgl/js/js-test-pre.js:122:7\ntestFailed@http://web-platform.test:8000/_webgl/js/js-test-pre.js:249:5\ncheckCanvasRect/<@http://web-platform.test:8000/_webgl/js/webgl-test-utils.js:1269:9\ncheckCanvasRectColor@http://web-platform.test:8000/_webgl/js/webgl-test-utils.js:1225:9\ncheckCanvasRect@http://web-platform.test:8000/_webgl/js/webgl-test-utils.js:1257:3\nrunTest@http://web-platform.test:8000/_webgl/conformance/renderbuffers/stencil-renderbuffer-initialization.html:75:9\n@http://web-platform.test:8000/_webgl/conformance/renderbuffers/stencil-renderbuffer-initialization.html:60:9\n", 
    "subtest": "WebGL test #6: internal buffers have been initialized to 0\nat (24, 2) expected: 0,0,0,0 was 81,101,0,0", 
    "test": "/_webgl/conformance/renderbuffers/stencil-renderbuffer-initialization.html", 
    "line": 263271, 
    "action": "test_result", 
    "expected": "PASS"
}
{
    "status": "FAIL", 
    "group": "default", 
    "message": "assert_true: internal buffers have been initialized to 0\nat (24, 2) expected: 0,0,0,0 was 81,88,2,0 expected true got false", 
    "stack": "reportTestResultsToHarness/<@http://web-platform.test:8000/_webgl/js/js-test-pre.js:123:9\nTest.prototype.step@http://web-platform.test:8000/resources/testharness.js:1908:25\ntest@http://web-platform.test:8000/resources/testharness.js:544:30\nreportTestResultsToHarness@http://web-platform.test:8000/_webgl/js/js-test-pre.js:122:7\ntestFailed@http://web-platform.test:8000/_webgl/js/js-test-pre.js:249:5\ncheckCanvasRect/<@http://web-platform.test:8000/_webgl/js/webgl-test-utils.js:1269:9\ncheckCanvasRectColor@http://web-platform.test:8000/_webgl/js/webgl-test-utils.js:1225:9\ncheckCanvasRect@http://web-platform.test:8000/_webgl/js/webgl-test-utils.js:1257:3\nrunTest@http://web-platform.test:8000/_webgl/conformance/renderbuffers/stencil-renderbuffer-initialization.html:75:9\n@http://web-platform.test:8000/_webgl/conformance/renderbuffers/stencil-renderbuffer-initialization.html:62:9\n", 
    "subtest": "WebGL test #12: internal buffers have been initialized to 0\nat (24, 2) expected: 0,0,0,0 was 81,88,2,0", 
    "test": "/_webgl/conformance/renderbuffers/stencil-renderbuffer-initialization.html", 
    "line": 263277, 
    "action": "test_result", 
    "expected": "PASS"
}
{
    "status": "FAIL", 
    "group": "default", 
    "message": "assert_true: internal buffers have been initialized to 0\nat (3, 1) expected: 0,0,0,0 was 113,94,2,0 expected true got false", 
    "stack": "reportTestResultsToHarness/<@http://web-platform.test:8000/_webgl/js/js-test-pre.js:123:9\nTest.prototype.step@http://web-platform.test:8000/resources/testharness.js:1908:25\ntest@http://web-platform.test:8000/resources/testharness.js:544:30\nreportTestResultsToHarness@http://web-platform.test:8000/_webgl/js/js-test-pre.js:122:7\ntestFailed@http://web-platform.test:8000/_webgl/js/js-test-pre.js:249:5\ncheckCanvasRect/<@http://web-platform.test:8000/_webgl/js/webgl-test-utils.js:1269:9\ncheckCanvasRectColor@http://web-platform.test:8000/_webgl/js/webgl-test-utils.js:1225:9\ncheckCanvasRect@http://web-platform.test:8000/_webgl/js/webgl-test-utils.js:1257:3\nrunTest@http://web-platform.test:8000/_webgl/conformance/renderbuffers/stencil-renderbuffer-initialization.html:75:9\n@http://web-platform.test:8000/_webgl/conformance/renderbuffers/stencil-renderbuffer-initialization.html:59:9\n", 
    "subtest": "WebGL test #20: internal buffers have been initialized to 0\nat (3, 1) expected: 0,0,0,0 was 113,94,2,0", 
    "test": "/_webgl/conformance/renderbuffers/stencil-renderbuffer-initialization.html", 
    "line": 263285, 
    "action": "test_result", 
    "expected": "PASS"
}
{
    "status": "FAIL", 
    "group": "default", 
    "message": "assert_true: internal buffers have been initialized to 0\nat (38, 2) expected: 0,0,0,0 was 193,82,2,0 expected true got false", 
    "stack": "reportTestResultsToHarness/<@http://web-platform.test:8000/_webgl/js/js-test-pre.js:123:9\nTest.prototype.step@http://web-platform.test:8000/resources/testharness.js:1908:25\ntest@http://web-platform.test:8000/resources/testharness.js:544:30\nreportTestResultsToHarness@http://web-platform.test:8000/_webgl/js/js-test-pre.js:122:7\ntestFailed@http://web-platform.test:8000/_webgl/js/js-test-pre.js:249:5\ncheckCanvasRect/<@http://web-platform.test:8000/_webgl/js/webgl-test-utils.js:1269:9\ncheckCanvasRectColor@http://web-platform.test:8000/_webgl/js/webgl-test-utils.js:1225:9\ncheckCanvasRect@http://web-platform.test:8000/_webgl/js/webgl-test-utils.js:1257:3\nrunTest@http://web-platform.test:8000/_webgl/conformance/renderbuffers/stencil-renderbuffer-initialization.html:75:9\n@http://web-platform.test:8000/_webgl/conformance/renderbuffers/stencil-renderbuffer-initialization.html:60:9\n", 
    "subtest": "WebGL test #26: internal buffers have been initialized to 0\nat (38, 2) expected: 0,0,0,0 was 193,82,2,0", 
    "test": "/_webgl/conformance/renderbuffers/stencil-renderbuffer-initialization.html", 
    "line": 263291, 
    "action": "test_result", 
    "expected": "PASS"
}
{
    "status": "FAIL", 
    "group": "default", 
    "message": "assert_true: internal buffers have been initialized to 0\nat (40, 2) expected: 0,0,0,0 was 97,81,2,0 expected true got false", 
    "stack": "reportTestResultsToHarness/<@http://web-platform.test:8000/_webgl/js/js-test-pre.js:123:9\nTest.prototype.step@http://web-platform.test:8000/resources/testharness.js:1908:25\ntest@http://web-platform.test:8000/resources/testharness.js:544:30\nreportTestResultsToHarness@http://web-platform.test:8000/_webgl/js/js-test-pre.js:122:7\ntestFailed@http://web-platform.test:8000/_webgl/js/js-test-pre.js:249:5\ncheckCanvasRect/<@http://web-platform.test:8000/_webgl/js/webgl-test-utils.js:1269:9\ncheckCanvasRectColor@http://web-platform.test:8000/_webgl/js/webgl-test-utils.js:1225:9\ncheckCanvasRect@http://web-platform.test:8000/_webgl/js/webgl-test-utils.js:1257:3\nrunTest@http://web-platform.test:8000/_webgl/conformance/renderbuffers/stencil-renderbuffer-initialization.html:75:9\n@http://web-platform.test:8000/_webgl/conformance/renderbuffers/stencil-renderbuffer-initialization.html:62:9\n", 
    "subtest": "WebGL test #32: internal buffers have been initialized to 0\nat (40, 2) expected: 0,0,0,0 was 97,81,2,0", 
    "test": "/_webgl/conformance/renderbuffers/stencil-renderbuffer-initialization.html", 
    "line": 263297, 
    "action": "test_result", 
    "expected": "PASS"
}
{
    "status": "FAIL", 
    "group": "default", 
    "message": "assert_true: internal buffers have been initialized to 0\nat (24, 2) expected: 0,0,0,0 was 81,102,0,0 expected true got false", 
    "stack": "reportTestResultsToHarness/<@http://web-platform.test:8000/_webgl/js/js-test-pre.js:123:9\nTest.prototype.step@http://web-platform.test:8000/resources/testharness.js:1908:25\ntest@http://web-platform.test:8000/resources/testharness.js:544:30\nreportTestResultsToHarness@http://web-platform.test:8000/_webgl/js/js-test-pre.js:122:7\ntestFailed@http://web-platform.test:8000/_webgl/js/js-test-pre.js:249:5\ncheckCanvasRect/<@http://web-platform.test:8000/_webgl/js/webgl-test-utils.js:1269:9\ncheckCanvasRectColor@http://web-platform.test:8000/_webgl/js/webgl-test-utils.js:1225:9\ncheckCanvasRect@http://web-platform.test:8000/_webgl/js/webgl-test-utils.js:1257:3\nrunTest@http://web-platform.test:8000/_webgl/conformance/renderbuffers/depth-renderbuffer-initialization.html:75:9\n@http://web-platform.test:8000/_webgl/conformance/renderbuffers/depth-renderbuffer-initialization.html:60:9\n", 
    "subtest": "WebGL test #6: internal buffers have been initialized to 0\nat (24, 2) expected: 0,0,0,0 was 81,102,0,0", 
    "test": "/_webgl/conformance/renderbuffers/depth-renderbuffer-initialization.html", 
    "line": 318389, 
    "action": "test_result", 
    "expected": "PASS"
}
{
    "status": "FAIL", 
    "group": "default", 
    "message": "assert_true: internal buffers have been initialized to 0\nat (32, 2) expected: 0,0,0,0 was 177,93,2,0 expected true got false", 
    "stack": "reportTestResultsToHarness/<@http://web-platform.test:8000/_webgl/js/js-test-pre.js:123:9\nTest.prototype.step@http://web-platform.test:8000/resources/testharness.js:1908:25\ntest@http://web-platform.test:8000/resources/testharness.js:544:30\nreportTestResultsToHarness@http://web-platform.test:8000/_webgl/js/js-test-pre.js:122:7\ntestFailed@http://web-platform.test:8000/_webgl/js/js-test-pre.js:249:5\ncheckCanvasRect/<@http://web-platform.test:8000/_webgl/js/webgl-test-utils.js:1269:9\ncheckCanvasRectColor@http://web-platform.test:8000/_webgl/js/webgl-test-utils.js:1225:9\ncheckCanvasRect@http://web-platform.test:8000/_webgl/js/webgl-test-utils.js:1257:3\nrunTest@http://web-platform.test:8000/_webgl/conformance/renderbuffers/depth-renderbuffer-initialization.html:75:9\n@http://web-platform.test:8000/_webgl/conformance/renderbuffers/depth-renderbuffer-initialization.html:62:9\n", 
    "subtest": "WebGL test #12: internal buffers have been initialized to 0\nat (32, 2) expected: 0,0,0,0 was 177,93,2,0", 
    "test": "/_webgl/conformance/renderbuffers/depth-renderbuffer-initialization.html", 
    "line": 318403, 
    "action": "test_result", 
    "expected": "PASS"
}
{
    "status": "FAIL", 
    "group": "default", 
    "message": "assert_true: internal buffers have been initialized to 0\nat (3, 1) expected: 0,0,0,0 was 49,93,2,0 expected true got false", 
    "stack": "reportTestResultsToHarness/<@http://web-platform.test:8000/_webgl/js/js-test-pre.js:123:9\nTest.prototype.step@http://web-platform.test:8000/resources/testharness.js:1908:25\ntest@http://web-platform.test:8000/resources/testharness.js:544:30\nreportTestResultsToHarness@http://web-platform.test:8000/_webgl/js/js-test-pre.js:122:7\ntestFailed@http://web-platform.test:8000/_webgl/js/js-test-pre.js:249:5\ncheckCanvasRect/<@http://web-platform.test:8000/_webgl/js/webgl-test-utils.js:1269:9\ncheckCanvasRectColor@http://web-platform.test:8000/_webgl/js/webgl-test-utils.js:1225:9\ncheckCanvasRect@http://web-platform.test:8000/_webgl/js/webgl-test-utils.js:1257:3\nrunTest@http://web-platform.test:8000/_webgl/conformance/renderbuffers/depth-renderbuffer-initialization.html:75:9\n@http://web-platform.test:8000/_webgl/conformance/renderbuffers/depth-renderbuffer-initialization.html:59:9\n", 
    "subtest": "WebGL test #20: internal buffers have been initialized to 0\nat (3, 1) expected: 0,0,0,0 was 49,93,2,0", 
    "test": "/_webgl/conformance/renderbuffers/depth-renderbuffer-initialization.html", 
    "line": 318420, 
    "action": "test_result", 
    "expected": "PASS"
}
{
    "status": "FAIL", 
    "group": "default", 
    "message": "assert_true: internal buffers have been initialized to 0\nat (2, 1) expected: 0,0,0,0 was 33,91,2,0 expected true got false", 
    "stack": "reportTestResultsToHarness/<@http://web-platform.test:8000/_webgl/js/js-test-pre.js:123:9\nTest.prototype.step@http://web-platform.test:8000/resources/testharness.js:1908:25\ntest@http://web-platform.test:8000/resources/testharness.js:544:30\nreportTestResultsToHarness@http://web-platform.test:8000/_webgl/js/js-test-pre.js:122:7\ntestFailed@http://web-platform.test:8000/_webgl/js/js-test-pre.js:249:5\ncheckCanvasRect/<@http://web-platform.test:8000/_webgl/js/webgl-test-utils.js:1269:9\ncheckCanvasRectColor@http://web-platform.test:8000/_webgl/js/webgl-test-utils.js:1225:9\ncheckCanvasRect@http://web-platform.test:8000/_webgl/js/webgl-test-utils.js:1257:3\nrunTest@http://web-platform.test:8000/_webgl/conformance/renderbuffers/depth-renderbuffer-initialization.html:75:9\n@http://web-platform.test:8000/_webgl/conformance/renderbuffers/depth-renderbuffer-initialization.html:60:9\n", 
    "subtest": "WebGL test #26: internal buffers have been initialized to 0\nat (2, 1) expected: 0,0,0,0 was 33,91,2,0", 
    "test": "/_webgl/conformance/renderbuffers/depth-renderbuffer-initialization.html", 
    "line": 318439, 
    "action": "test_result", 
    "expected": "PASS"
}
{
    "status": "FAIL", 
    "group": "default", 
    "message": "assert_true: internal buffers have been initialized to 0\nat (40, 2) expected: 0,0,0,0 was 161,79,2,0 expected true got false", 
    "stack": "reportTestResultsToHarness/<@http://web-platform.test:8000/_webgl/js/js-test-pre.js:123:9\nTest.prototype.step@http://web-platform.test:8000/resources/testharness.js:1908:25\ntest@http://web-platform.test:8000/resources/testharness.js:544:30\nreportTestResultsToHarness@http://web-platform.test:8000/_webgl/js/js-test-pre.js:122:7\ntestFailed@http://web-platform.test:8000/_webgl/js/js-test-pre.js:249:5\ncheckCanvasRect/<@http://web-platform.test:8000/_webgl/js/webgl-test-utils.js:1269:9\ncheckCanvasRectColor@http://web-platform.test:8000/_webgl/js/webgl-test-utils.js:1225:9\ncheckCanvasRect@http://web-platform.test:8000/_webgl/js/webgl-test-utils.js:1257:3\nrunTest@http://web-platform.test:8000/_webgl/conformance/renderbuffers/depth-renderbuffer-initialization.html:75:9\n@http://web-platform.test:8000/_webgl/conformance/renderbuffers/depth-renderbuffer-initialization.html:62:9\n", 
    "subtest": "WebGL test #32: internal buffers have been initialized to 0\nat (40, 2) expected: 0,0,0,0 was 161,79,2,0", 
    "test": "/_webgl/conformance/renderbuffers/depth-renderbuffer-initialization.html", 
    "line": 318451, 
    "action": "test_result", 
    "expected": "PASS"
}

asajeffrey · 2019-11-07T16:03:52Z

Should we move over to the published surfman crate?

Manishearth · 2019-11-07T16:16:26Z

Yes

…

On Thu, Nov 7, 2019, 8:04 AM Alan Jeffrey ***@***.***> wrote: Should we move over to the published surfman crate? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#24676?email_source=notifications&email_token=AAMK6SCLAQABW6775AZMZHTQSQ375A5CNFSM4JJZHOY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDM4YRY#issuecomment-551144519>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMK6SB2P2ARZ6HSD7DZQX3QSQ375ANCNFSM4JJZHOYQ> .

Manishearth · 2019-11-08T17:49:43Z

@bors-servo r=jdm

bors-servo · 2019-11-08T17:49:44Z

📌 Commit d02333b has been approved by jdm

Manishearth · 2019-11-11T20:29:16Z

@bors-servo r=jdm

bors-servo · 2019-11-11T20:29:17Z

📌 Commit 2436bd1 has been approved by jdm

bors-servo · 2019-11-11T20:35:30Z

⌛ Testing commit 2436bd1 with merge 2702f4a...


        Auto merge of #24676 - Manishearth:unpatch, r=jdm

@jdm

Remove patched webxr Unsure if this compiles yet, testing locally. r? @jdm

bors-servo · 2019-11-11T22:27:17Z

💔 Test failed - status-taskcluster

jdm · 2019-11-11T22:40:04Z

@bors-servo retry

#22212

Manishearth · 2019-11-11T22:41:21Z

OOM for mozjs build?

      0 [main] us 0 init_cheap: VirtualAlloc pointer is null, Win32 error 487
AllocationBase 0x0, BaseAddress 0x607A0000, RegionSize 0xE0000, State 0x10000
C:\Users\task_1573485483\repo\.servo\msvc-dependencies\moztools\3.2\msys\bin\pwd.exe: *** Couldn't reserve space for cygwin's heap, Win32 error 0
      0 [main] us 0 init_cheap: VirtualAlloc pointer is null, Win32 error 487
AllocationBase 0x0, BaseAddress 0x607A0000, RegionSize 0xE0000, State 0x10000
C:\Users\task_1573485483\repo\.servo\msvc-dependencies\moztools\3.2\msys\bin\sh.exe: *** Couldn't reserve space for cygwin's heap, Win32 error 0
mozmake: *** [makefile.cargo:193: maybe-configure] Error 1
thread 'main' panicked at 'assertion failed: result.success()', C:\Users\task_1573485483\.cargo\git\checkouts\mozjs-fa11ffc7d4f1cc2d\5906588\build.rs:133:5

@bors-servo retry

bors-servo · 2019-11-12T00:25:19Z

💣 Failed to start rebuilding: 405 Not Allowed

bors-servo · 2019-11-12T00:25:24Z

⌛ Testing commit 2436bd1 with merge 31ee5fc...


        Auto merge of #24676 - Manishearth:unpatch, r=jdm

@jdm

Remove patched webxr Unsure if this compiles yet, testing locally. r? @jdm

bors-servo · 2019-11-12T01:07:12Z

💔 Test failed - linux-rel-wpt

jdm · 2019-11-12T02:55:40Z

@bors-servo retry

bors-servo · 2019-11-12T02:55:43Z

⚡ Previous build results for linux-rel-css, status-taskcluster are reusable. Rebuilding only linux-rel-wpt...

bors-servo · 2019-11-12T03:38:21Z

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing 31ee5fc to master...

highfive assigned jdm Nov 6, 2019

highfive added the S-awaiting-review label Nov 6, 2019

Manishearth force-pushed the Manishearth:unpatch branch from e0a93af to 208ada1 Nov 6, 2019

highfive added S-awaiting-merge and removed S-awaiting-review labels Nov 6, 2019

jdm added S-fails-tidy and removed S-awaiting-merge labels Nov 6, 2019

Manishearth force-pushed the Manishearth:unpatch branch from 5b1fc76 to 0b02dec Nov 6, 2019

highfive added the S-awaiting-review label Nov 6, 2019

highfive added S-awaiting-merge and removed S-awaiting-review labels Nov 6, 2019

highfive added S-tests-failed and removed S-awaiting-merge labels Nov 7, 2019

Manishearth force-pushed the Manishearth:unpatch branch from 0b02dec to d02333b Nov 8, 2019

highfive added S-awaiting-review and removed S-tests-failed labels Nov 8, 2019

Manishearth force-pushed the Manishearth:unpatch branch from 11cab6a to 2436bd1 Nov 11, 2019

highfive removed the S-awaiting-merge label Nov 11, 2019

highfive added the S-awaiting-review label Nov 11, 2019

highfive added S-awaiting-merge and removed S-awaiting-review labels Nov 11, 2019

Manishearth mentioned this pull request Nov 11, 2019

Binding a surface to the current OSMesa context doesn't update the surface data pcwalton/surfman#35

Closed

highfive added S-tests-failed and removed S-awaiting-merge labels Nov 11, 2019

highfive added S-awaiting-merge and removed S-tests-failed labels Nov 12, 2019

highfive added S-tests-failed and removed S-awaiting-merge labels Nov 12, 2019

bors-servo merged commit 2436bd1 into servo:master Nov 12, 2019
2 checks passed

2 checks passed

Community-TC (pull_request) TaskGroup: success
Details

homu Test successful
Details

This was referenced Nov 12, 2019

Update for surfman surfaceless changes #24657

Closed

WebAudio MediaElementAudioSourceNode implementation #24687

Merged

jdm mentioned this pull request Nov 13, 2019

glwindow only shows a black window for babylon demos #24727

Closed

servo / servo

Remove patched webxr #24676

Remove patched webxr #24676

Manishearth commented Nov 6, 2019

Manishearth commented Nov 6, 2019

jdm commented Nov 6, 2019

bors-servo commented Nov 6, 2019

jdm commented Nov 6, 2019

Manishearth commented Nov 6, 2019

bors-servo commented Nov 6, 2019

bors-servo commented Nov 7, 2019

bors-servo commented Nov 7, 2019

Manishearth commented Nov 7, 2019

asajeffrey commented Nov 7, 2019

Manishearth commented Nov 7, 2019

Manishearth commented Nov 8, 2019

bors-servo commented Nov 8, 2019

Manishearth commented Nov 11, 2019

bors-servo commented Nov 11, 2019

bors-servo commented Nov 11, 2019

bors-servo commented Nov 11, 2019

jdm commented Nov 11, 2019 •

edited

Manishearth commented Nov 11, 2019

bors-servo commented Nov 12, 2019

bors-servo commented Nov 12, 2019

bors-servo commented Nov 12, 2019

jdm commented Nov 12, 2019

bors-servo commented Nov 12, 2019

bors-servo commented Nov 12, 2019

servo / servo

Join GitHub today

Remove patched webxr #24676

Remove patched webxr #24676

Conversation

Manishearth commented Nov 6, 2019

Manishearth commented Nov 6, 2019

jdm commented Nov 6, 2019

bors-servo commented Nov 6, 2019

jdm commented Nov 6, 2019

Manishearth commented Nov 6, 2019

bors-servo commented Nov 6, 2019

bors-servo commented Nov 7, 2019

bors-servo commented Nov 7, 2019

Manishearth commented Nov 7, 2019

asajeffrey commented Nov 7, 2019

Manishearth commented Nov 7, 2019

Manishearth commented Nov 8, 2019

bors-servo commented Nov 8, 2019

Manishearth commented Nov 11, 2019

bors-servo commented Nov 11, 2019

bors-servo commented Nov 11, 2019

bors-servo commented Nov 11, 2019

jdm commented Nov 11, 2019 • edited

Manishearth commented Nov 11, 2019

bors-servo commented Nov 12, 2019

bors-servo commented Nov 12, 2019

bors-servo commented Nov 12, 2019

jdm commented Nov 12, 2019

bors-servo commented Nov 12, 2019

bors-servo commented Nov 12, 2019

jdm commented Nov 11, 2019 •

edited