Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require FormDataEventInit dictionary #24680

Merged
merged 1 commit into from Nov 24, 2019
Merged

Require FormDataEventInit dictionary #24680

merged 1 commit into from Nov 24, 2019

Conversation

@saschanaz
Copy link
Contributor

saschanaz commented Nov 7, 2019 •
edited

Should probably wait until whatwg/html#5064 be fixed.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix __ (#22670 mentions FormDataEvent but the codegen itself still has a problem, in e.g. PromiseRejectionEventInit)
  • There are tests for these changes
@highfive
Copy link

highfive commented Nov 7, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/formdataevent.rs, components/script/dom/webidls/FormDataEvent.webidl
  • @KiChjang: components/script/dom/formdataevent.rs, components/script/dom/webidls/FormDataEvent.webidl
@highfive
Copy link

highfive commented Nov 7, 2019

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@saschanaz saschanaz force-pushed the saschanaz:formdataevent branch 2 times, most recently from 0105e59 to f9c8aba Nov 12, 2019
@jdm
Copy link
Member

jdm commented Nov 18, 2019

whatwg/html#5064 merged.
@jdm
Copy link
Member

jdm commented Nov 21, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 21, 2019

📌 Commit f9c8aba has been approved by jdm
@highfive highfive assigned jdm and unassigned SimonSapin Nov 21, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Nov 21, 2019

⌛ Testing commit f9c8aba with merge 9bfb7b9...
bors-servo added a commit that referenced this pull request Nov 21, 2019
@bors-servo
Auto merge of #24680 - saschanaz:formdataevent, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9bfb7b9 
Require FormDataEventInit dictionary

<!-- Please describe your changes on the following line: -->

Should probably wait until whatwg/html#5064 be fixed.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix __ (#22670 mentions `FormDataEvent` but the codegen itself still has a problem, in e.g. `PromiseRejectionEventInit`)

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 21, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Nov 21, 2019 

{
    "status": "FAIL", 
    "group": "default", 
    "message": "assert_equals: wrong value for FormDataEvent.length expected 1 but got 2", 
    "stack": "IdlInterface.prototype.test_self/<@https://web-platform.test:8443/resources/idlharness.js:1697:13\nTest.prototype.step@https://web-platform.test:8443/resources/testharness.js:1931:25\ntest@https://web-platform.test:8443/resources/testharness.js:544:30\nsubsetTestByKey@https://web-platform.test:8443/common/subset-tests-by-key.js:70:14\nIdlInterface.prototype.test_self@https://web-platform.test:8443/resources/idlharness.js:1677:9\nIdlInterface.prototype.test@https://web-platform.test:8443/resources/idlharness.js:1550:14\nIdlArray.prototype.test@https://web-platform.test:8443/resources/idlharness.js:888:28\nidl_test/</<@https://web-platform.test:8443/resources/idlharness.js:3387:31\n", 
    "subtest": "FormDataEvent interface object length", 
    "test": "/html/dom/idlharness.https.html?exclude=(Document|Window|HTML.*)", 
    "line": 2070, 
    "action": "test_result", 
    "expected": "PASS"
}

This may be corrected upstream; we haven't successfully synced with WPT in several days.
@saschanaz
Copy link
Contributor Author

saschanaz commented Nov 22, 2019

Hmm yes, and probably blocked by web-platform-tests/wpt#20304 this time.
@CYBAI
Copy link
Collaborator

CYBAI commented Nov 24, 2019

@bors-servo try=wpt
@saschanaz
Require FormDataEventInit dictionary
Loading status checks…
94565c4
@saschanaz saschanaz force-pushed the saschanaz:formdataevent branch from f9c8aba to 94565c4 Nov 24, 2019
@saschanaz
Copy link
Contributor Author

saschanaz commented Nov 24, 2019

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Nov 24, 2019

⌛ Trying commit 94565c4 with merge dd69fb9...
bors-servo added a commit that referenced this pull request Nov 24, 2019
@bors-servo
Auto merge of #24680 - saschanaz:formdataevent, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
dd69fb9 
Require FormDataEventInit dictionary

<!-- Please describe your changes on the following line: -->

Should probably wait until whatwg/html#5064 be fixed.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix __ (#22670 mentions `FormDataEvent` but the codegen itself still has a problem, in e.g. `PromiseRejectionEventInit`)

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 24, 2019

⌛ Testing commit 94565c4 with merge 6ff1338...
bors-servo added a commit that referenced this pull request Nov 24, 2019
@bors-servo
Auto merge of #24680 - saschanaz:formdataevent, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6ff1338 
Require FormDataEventInit dictionary

<!-- Please describe your changes on the following line: -->

Should probably wait until whatwg/html#5064 be fixed.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix __ (#22670 mentions `FormDataEvent` but the codegen itself still has a problem, in e.g. `PromiseRejectionEventInit`)

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 24, 2019

💔 Test failed - status-taskcluster
@CYBAI
Copy link
Collaborator

CYBAI commented Nov 24, 2019

@bors-servo retry
bors-servo added a commit that referenced this pull request Nov 24, 2019
@bors-servo
Auto merge of #24680 - saschanaz:formdataevent, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f84a9ed 
Require FormDataEventInit dictionary

<!-- Please describe your changes on the following line: -->

Should probably wait until whatwg/html#5064 be fixed.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix __ (#22670 mentions `FormDataEvent` but the codegen itself still has a problem, in e.g. `PromiseRejectionEventInit`)

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 24, 2019

⌛ Testing commit 94565c4 with merge f84a9ed...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 24, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Nov 24, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 24, 2019

⌛ Testing commit 94565c4 with merge 82bf265...
bors-servo added a commit that referenced this pull request Nov 24, 2019
@bors-servo
Auto merge of #24680 - saschanaz:formdataevent, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
82bf265 
Require FormDataEventInit dictionary

<!-- Please describe your changes on the following line: -->

Should probably wait until whatwg/html#5064 be fixed.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix __ (#22670 mentions `FormDataEvent` but the codegen itself still has a problem, in e.g. `PromiseRejectionEventInit`)

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 24, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Nov 24, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 24, 2019

⌛ Testing commit 94565c4 with merge c8791c0...
bors-servo added a commit that referenced this pull request Nov 24, 2019
@bors-servo
Auto merge of #24680 - saschanaz:formdataevent, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c8791c0 
Require FormDataEventInit dictionary

<!-- Please describe your changes on the following line: -->

Should probably wait until whatwg/html#5064 be fixed.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix __ (#22670 mentions `FormDataEvent` but the codegen itself still has a problem, in e.g. `PromiseRejectionEventInit`)

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 24, 2019

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing c8791c0 to master...
@bors-servo bors-servo merged commit 94565c4 into servo:master Nov 24, 2019
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@saschanaz saschanaz deleted the saschanaz:formdataevent branch Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@saschanaz @highfive @jdm @bors-servo @CYBAI @SimonSapin
You can’t perform that action at this time.