Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebAudio MediaElementAudioSourceNode implementation #24687

Merged
merged 6 commits into from Nov 19, 2019
Merged

WebAudio MediaElementAudioSourceNode implementation #24687

merged 6 commits into from Nov 19, 2019
+179 −147

Conversation

@ferjm
Copy link
Member

ferjm commented Nov 7, 2019

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #22370
  • There are tests for these changes

Depends on servo/media#321

Tested with https://ferjm.github.io/webaudio-examples/media-source-buffer/

I am still investigating why it is playing back with a low rate.
@highfive
Copy link

highfive commented Nov 7, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/htmlvideoelement.rs, components/script/dom/webidls/AudioContext.webidl, components/script/dom/audiocontext.rs, components/script/dom/mod.rs, components/script/dom/mediaelementaudiosourcenode.rs and 3 more
  • @KiChjang: components/script/dom/htmlvideoelement.rs, components/script/dom/webidls/AudioContext.webidl, components/script/dom/audiocontext.rs, components/script/dom/mod.rs, components/script/dom/mediaelementaudiosourcenode.rs and 3 more
@highfive
Copy link

highfive commented Nov 7, 2019

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@bors-servo
Copy link
Contributor

bors-servo commented Nov 12, 2019

☔ The latest upstream changes (presumably #24676) made this pull request unmergeable. Please resolve the merge conflicts.
@nox
Copy link
Member

nox commented Nov 12, 2019

r? @Manishearth
@highfive highfive assigned Manishearth and unassigned nox Nov 12, 2019
@Manishearth
Manishearth approved these changes Nov 12, 2019
View changes
@jdm jdm removed the S-awaiting-review label Nov 12, 2019
@ferjm ferjm force-pushed the ferjm:mediaelementaudionode branch from 9118f98 to 16e93b0 Nov 18, 2019
@ferjm ferjm force-pushed the ferjm:mediaelementaudionode branch from 16e93b0 to 184b376 Nov 18, 2019
@servo-wpt-sync
Copy link
Collaborator

servo-wpt-sync commented Nov 18, 2019

Error syncing changes upstream. Logs saved in error-snapshot-1574093491037.
ferjm added 5 commits Nov 7, 2019
@ferjm
Update servo-media with MediaElementAudioSourceNode engine
518ec87
@ferjm
Rename frame_renderer to video_renderer
ea05487
@ferjm
MediaElementAudioSourceNode implementation
03485d7
@ferjm
MediaElementAudioSourceNode: set audio renderer
a72e46f
@ferjm
Implement AudioContext.createMediaElementAudioSourceNode()
Loading status checks…
04f4da3
@ferjm ferjm force-pushed the ferjm:mediaelementaudionode branch from 184b376 to 04f4da3 Nov 18, 2019
@ferjm
Copy link
Member Author

ferjm commented Nov 18, 2019

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Nov 18, 2019

⌛ Trying commit 04f4da3 with merge 32ae8bb...
bors-servo added a commit that referenced this pull request Nov 18, 2019
@bors-servo
Auto merge of #24687 - ferjm:mediaelementaudionode, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
32ae8bb 
WebAudio MediaElementAudioSourceNode implementation

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22370
- [X] There are tests for these changes

Depends on servo/media#321

Tested with https://ferjm.github.io/webaudio-examples/media-source-buffer/

I am still investigating why it is playing back with a low rate.
@bors-servo
Copy link
Contributor

bors-servo commented Nov 18, 2019

💔 Test failed - linux-rel-css
@ferjm
Copy link
Member Author

ferjm commented Nov 19, 2019

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Nov 19, 2019

⌛ Trying commit 6a28dba with merge 93c9419...
bors-servo added a commit that referenced this pull request Nov 19, 2019
@bors-servo
Auto merge of #24687 - ferjm:mediaelementaudionode, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
93c9419 
WebAudio MediaElementAudioSourceNode implementation

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22370
- [X] There are tests for these changes

Depends on servo/media#321

Tested with https://ferjm.github.io/webaudio-examples/media-source-buffer/

I am still investigating why it is playing back with a low rate.
@bors-servo
Copy link
Contributor

bors-servo commented Nov 19, 2019

💔 Test failed - linux-rel-wpt
@ferjm
Update tests for MediaElementAudioSourceNode
Loading status checks…
da2f601
@ferjm ferjm force-pushed the ferjm:mediaelementaudionode branch from 6a28dba to da2f601 Nov 19, 2019
@ferjm
Copy link
Member Author

ferjm commented Nov 19, 2019

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Nov 19, 2019

⌛ Trying commit da2f601 with merge 58e75ad...
bors-servo added a commit that referenced this pull request Nov 19, 2019
@bors-servo
Auto merge of #24687 - ferjm:mediaelementaudionode, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
58e75ad 
WebAudio MediaElementAudioSourceNode implementation

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22370
- [X] There are tests for these changes

Depends on servo/media#321

Tested with https://ferjm.github.io/webaudio-examples/media-source-buffer/

I am still investigating why it is playing back with a low rate.
@bors-servo
Copy link
Contributor

bors-servo commented Nov 19, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
State: approved= try=True
@ferjm
Copy link
Member Author

ferjm commented Nov 19, 2019

@bors-servo r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Nov 19, 2019

📌 Commit da2f601 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Nov 19, 2019

⌛ Testing commit da2f601 with merge 25c3b4c...
bors-servo added a commit that referenced this pull request Nov 19, 2019
@bors-servo
Auto merge of #24687 - ferjm:mediaelementaudionode, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
25c3b4c 
WebAudio MediaElementAudioSourceNode implementation

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22370
- [X] There are tests for these changes

Depends on servo/media#321

Tested with https://ferjm.github.io/webaudio-examples/media-source-buffer/

I am still investigating why it is playing back with a low rate.
@bors-servo
Copy link
Contributor

bors-servo commented Nov 19, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Nov 19, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 19, 2019

💣 Failed to start rebuilding: 405 Not Allowed
@bors-servo
Copy link
Contributor

bors-servo commented Nov 19, 2019

⌛ Testing commit da2f601 with merge 03a6fe0...
bors-servo added a commit that referenced this pull request Nov 19, 2019
@bors-servo
Auto merge of #24687 - ferjm:mediaelementaudionode, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
03a6fe0 
WebAudio MediaElementAudioSourceNode implementation

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22370
- [X] There are tests for these changes

Depends on servo/media#321

Tested with https://ferjm.github.io/webaudio-examples/media-source-buffer/

I am still investigating why it is playing back with a low rate.
@bors-servo
Copy link
Contributor

bors-servo commented Nov 19, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: Manishearth
Pushing 03a6fe0 to master...
@bors-servo bors-servo merged commit da2f601 into servo:master Nov 19, 2019
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@ferjm ferjm deleted the ferjm:mediaelementaudionode branch Nov 20, 2019
@jbeich

This comment has been minimized.

Sign in to view
Copy link
Contributor

jbeich commented on 518ec87 Dec 4, 2019 •
edited

Did you forget to update servo-media-dummy? After this commit it uses different snapshot than other servo-media packages.

servo/Cargo.lock

Lines 4476 to 4489 in 518ec87

[[package]]
name = "servo-media-dummy"
version = "0.1.0"
source = "git+https://github.com/servo/media#5380170bb42286ce9009d83e1034904bea8f00ee"
dependencies = [
"boxfnonce",
"ipc-channel",
"servo-media",
"servo-media-audio",
"servo-media-player",
"servo-media-streams",
"servo-media-traits",
"servo-media-webrtc",
]

This comment has been minimized.

Sign in to view
Copy link
Member

jdm replied Dec 4, 2019

Looks like it, yes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth

Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Implement MediaElementAudioSourceNode
8 participants
@ferjm @highfive @bors-servo @nox @servo-wpt-sync @jdm @Manishearth @jbeich
You can’t perform that action at this time.