Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of on_unimplemented #24694

Merged
merged 2 commits into from Nov 9, 2019
Merged

Remove use of on_unimplemented #24694

merged 2 commits into from Nov 9, 2019

Commits on Nov 8, 2019

  1. Remove use of on_unimplemented

    It errors in today’s Nightly:
    
    ```rust
    error[E0557]: feature has been removed
     --> components/script/lib.rs:9:12
      |
    9 | #![feature(on_unimplemented)]
      |            ^^^^^^^^^^^^^^^^ feature has been removed
    
    error[E0658]: this is an internal attribute that will never be stable
      --> components/script/dom/bindings/conversions.rs:77:1
       |
    77 | #[rustc_on_unimplemented(message = "The IDL interface `{Self}` is not derived from `{T}`.")]
       | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
       |
       = note: for more information, see rust-lang/rust#29642
       = help: add `#![feature(rustc_attrs)]` to the crate attributes to enable
    
    error: aborting due to 2 previous errors
    ```
    SimonSapin committed Nov 8, 2019
  2. Fix some warnings new in Rust Nightly

    SimonSapin committed Nov 8, 2019
You can’t perform that action at this time.