Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make `./mach rustup` install the rustc-dev component #24711

Merged
merged 1 commit into from Nov 13, 2019
Merged

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Nov 12, 2019

No description provided.

@highfive
Copy link

highfive commented Nov 12, 2019

Heads up! This PR modifies the following files:

@jdm
Copy link
Member

jdm commented Nov 12, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Nov 12, 2019

📌 Commit b7389a9 has been approved by jdm

@highfive highfive assigned jdm and unassigned nox Nov 12, 2019
@nox
Copy link
Member

nox commented Nov 12, 2019

What's the difference?

@SimonSapin
Copy link
Member Author

SimonSapin commented Nov 12, 2019

This only matters if you use rustup set profile minimal, see https://blog.rust-lang.org/2019/10/15/Rustup-1.20.0.html#profiles

rustc-dev is required for compiler plugins. It is part of the default profile but not minimal.

@bors-servo
Copy link
Contributor

bors-servo commented Nov 13, 2019

Testing commit b7389a9 with merge f7dc5e5...

bors-servo added a commit that referenced this pull request Nov 13, 2019
Make `./mach rustup` install the rustc-dev component
@bors-servo
Copy link
Contributor

bors-servo commented Nov 13, 2019

💔 Test failed - status-taskcluster

@CYBAI
Copy link
Collaborator

CYBAI commented Nov 13, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Nov 13, 2019

💣 Failed to start rebuilding: 405 Not Allowed

@bors-servo
Copy link
Contributor

bors-servo commented Nov 13, 2019

Testing commit b7389a9 with merge eb05af2...

bors-servo added a commit that referenced this pull request Nov 13, 2019
Make `./mach rustup` install the rustc-dev component
@bors-servo
Copy link
Contributor

bors-servo commented Nov 13, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing eb05af2 to master...

@bors-servo bors-servo merged commit b7389a9 into master Nov 13, 2019
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@bors-servo bors-servo deleted the rustc-dev branch Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.