Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use `#![register_tool]` instead of `Registry::register_attribute` #24719

Closed
wants to merge 2 commits into from
Closed

Use `#![register_tool]` instead of `Registry::register_attribute` #24719

wants to merge 2 commits into from

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Nov 12, 2019

CC rust-lang/rust#66344, rust-lang/rust#66079
SimonSapin added 2 commits Nov 12, 2019
@SimonSapin
Use `#![register_attr(…)]` instead of `Registry::register_attribute`
bbfec88 
CC rust-lang/rust#66344, rust-lang/rust#66080
@SimonSapin
Use `#![register_tool]` instead of `#![register_attr]`
Loading status checks…
4ca7272 
CC rust-lang/rust#66079
@highfive
Copy link

highfive commented Nov 12, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webglvertexarrayobjectoes.rs, components/script/canvas_state.rs, components/script/dom/webglframebuffer.rs, components/script/dom/range.rs, components/script/dom/customelementregistry.rs and 36 more
  • @KiChjang: components/script/dom/webglvertexarrayobjectoes.rs, components/script/canvas_state.rs, components/script/dom/webglframebuffer.rs, components/script/dom/range.rs, components/script/dom/customelementregistry.rs and 36 more
@SimonSapin
Copy link
Member Author

SimonSapin commented Nov 12, 2019

Landing (without disabling warnings) this is blocked on fixing #24684.
@jdm
jdm approved these changes Nov 12, 2019
View changes
@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2019

☔ The latest upstream changes (presumably #24750) made this pull request unmergeable. Please resolve the merge conflicts.
@SimonSapin
Copy link
Member Author

SimonSapin commented Nov 16, 2019

Ooh, making #24750 did seem like déjà-vu…
@SimonSapin SimonSapin closed this Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

Assignees

@ferjm ferjm

Labels
S-awaiting-review S-blocked-on-external S-needs-rebase
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@SimonSapin @highfive @bors-servo @jdm @ferjm
You can’t perform that action at this time.