Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address upstream WPT test harness changes #24732

Merged
merged 4 commits into from Nov 16, 2019
Merged

Address upstream WPT test harness changes #24732

merged 4 commits into from Nov 16, 2019
+24 −44

Conversation

@jdm
Copy link
Member

jdm commented Nov 13, 2019

web-platform-tests/wpt#19449 and web-platform-tests/wpt#19993 caused some of our proprietary tests to silently start to fail. This addresses all of the breakage.
@jdm
Expect new PreconditionFailedError interface during WPT tests.
610d7d4
@asajeffrey
asajeffrey approved these changes Nov 14, 2019
View changes
Copy link
Member

asajeffrey left a comment

LGTM
@jdm
Copy link
Member Author

jdm commented Nov 14, 2019

@bors-servo r=asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented Nov 14, 2019

📌 Commit bcaf43d has been approved by asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2019

⌛ Testing commit bcaf43d with merge 3ccc7c6...
bors-servo added a commit that referenced this pull request Nov 15, 2019
@bors-servo
Auto merge of #24732 - jdm:wptfixes, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3ccc7c6 
Address upstream WPT test harness changes

web-platform-tests/wpt#19449 and web-platform-tests/wpt#19993 caused some of our proprietary tests to silently start to fail. This addresses all of the breakage.
@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2019

💔 Test failed - linux-rel-css
@CYBAI
Copy link
Collaborator

CYBAI commented Nov 15, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2019

⌛ Testing commit bcaf43d with merge c0f30fc...
bors-servo added a commit that referenced this pull request Nov 15, 2019
@bors-servo
Auto merge of #24732 - jdm:wptfixes, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c0f30fc 
Address upstream WPT test harness changes

web-platform-tests/wpt#19449 and web-platform-tests/wpt#19993 caused some of our proprietary tests to silently start to fail. This addresses all of the breakage.
@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2019

💔 Test failed - linux-rel-css
@CYBAI
Copy link
Collaborator

CYBAI commented Nov 15, 2019 

{
    "status": "FAIL", 
    "group": "default", 
    "message": "", 
    "stack": "step@http://web-platform.test:8000/_mozilla/mozilla/window_requestAnimationFrame2.html:18:17\nTest.prototype.step@http://web-platform.test:8000/resources/testharness.js:1931:25\nTest.prototype.step_func/<@http://web-platform.test:8000/resources/testharness.js:1956:35\n", 
    "subtest": "Test throwing an error inside requestAnimationFrame callback", 
    "test": "/_mozilla/mozilla/window_requestAnimationFrame2.html", 
    "line": 196908, 
    "action": "test_result", 
    "expected": "PASS"
}
jdm added 2 commits Nov 13, 2019
@jdm
Convert deprecated single-page tests to use proper test harness.
ebf54c9
@jdm
Fix test syntax error.
a1df2a7
@jdm jdm force-pushed the jdm:wptfixes branch from bcaf43d to 010b8a6 Nov 15, 2019
@jdm
Copy link
Member Author

jdm commented Nov 15, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2019

📌 Commit 010b8a6 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented Nov 16, 2019

@bors-servo retry
bors-servo added a commit that referenced this pull request Nov 16, 2019
@bors-servo
Auto merge of #24732 - jdm:wptfixes, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
67777eb 
Address upstream WPT test harness changes

web-platform-tests/wpt#19449 and web-platform-tests/wpt#19993 caused some of our proprietary tests to silently start to fail. This addresses all of the breakage.
@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2019

⌛ Testing commit 4041caf with merge 67777eb...
@jdm
Copy link
Member Author

jdm commented Nov 16, 2019

@bors-servo treeclosed=10
mac3 is broken and ruining everything (#24755)
@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2019

💔 Test failed - status-taskcluster
@SimonSapin
Copy link
Member

SimonSapin commented Nov 16, 2019

mac3 should be out of the pool now servo/taskcluster-config#5 (comment)

@bors-servo treeclosed-
@jdm
Copy link
Member Author

jdm commented Nov 16, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2019

💣 Failed to start rebuilding: 405 Not Allowed
@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2019

⌛ Testing commit 4041caf with merge c1c9ab6...
bors-servo added a commit that referenced this pull request Nov 16, 2019
@bors-servo
Auto merge of #24732 - jdm:wptfixes, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c1c9ab6 
Address upstream WPT test harness changes

web-platform-tests/wpt#19449 and web-platform-tests/wpt#19993 caused some of our proprietary tests to silently start to fail. This addresses all of the breakage.
@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2019

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member Author

jdm commented Nov 16, 2019

@bors-servo retry
#13480
@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2019

⌛ Testing commit 4041caf with merge 04119ed...
bors-servo added a commit that referenced this pull request Nov 16, 2019
@bors-servo
Auto merge of #24732 - jdm:wptfixes, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
04119ed 
Address upstream WPT test harness changes

web-platform-tests/wpt#19449 and web-platform-tests/wpt#19993 caused some of our proprietary tests to silently start to fail. This addresses all of the breakage.
@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: asajeffrey
Pushing 04119ed to master...
@bors-servo bors-servo merged commit 4041caf into servo:master Nov 16, 2019
1 of 2 checks passed
1 of 2 checks passed
Community-TC (pull_request) TaskGroup: failure
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asajeffrey asajeffrey

Assignees

@asajeffrey asajeffrey

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@jdm @bors-servo @CYBAI @SimonSapin @asajeffrey @highfive
You can’t perform that action at this time.