Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better tooltip for UWP port #24734

Merged
merged 1 commit into from Nov 16, 2019
Merged

Better tooltip for UWP port #24734

merged 1 commit into from Nov 16, 2019

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Nov 14, 2019

Fix #24721
@paulrouget
Better tooltip for UWP port
Loading status checks…
8a97aa5
@jdm
Copy link
Member

jdm commented Nov 14, 2019 •
edited

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 14, 2019

📌 Commit 8a97aa5 has been approved by jdm
@highfive highfive assigned jdm and unassigned Manishearth Nov 14, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2019

⌛ Testing commit 8a97aa5 with merge c813ec9...
bors-servo added a commit that referenced this pull request Nov 15, 2019
@bors-servo
Auto merge of #24734 - paulrouget:tooltip, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c813ec9 
Better tooltip for UWP port

Fix #24721
@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Nov 15, 2019

@bors-servo retry
#23290
@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2019

⌛ Testing commit 8a97aa5 with merge 1607d96...
bors-servo added a commit that referenced this pull request Nov 15, 2019
@bors-servo
Auto merge of #24734 - paulrouget:tooltip, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1607d96 
Better tooltip for UWP port

Fix #24721
@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Nov 15, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2019

⌛ Testing commit 8a97aa5 with merge 2fe2015...
bors-servo added a commit that referenced this pull request Nov 16, 2019
@bors-servo
Auto merge of #24734 - paulrouget:tooltip, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2fe2015 
Better tooltip for UWP port

Fix #24721
@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2019

💔 Test failed - linux-rel-wpt
@CYBAI
Copy link
Collaborator

CYBAI commented Nov 16, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2019

⌛ Testing commit 8a97aa5 with merge e1401c7...
bors-servo added a commit that referenced this pull request Nov 16, 2019
@bors-servo
Auto merge of #24734 - paulrouget:tooltip, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e1401c7 
Better tooltip for UWP port

Fix #24721
@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Nov 16, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2019

💣 Failed to start rebuilding: 405 Not Allowed
@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2019

⌛ Testing commit 8a97aa5 with merge 5670a45...
bors-servo added a commit that referenced this pull request Nov 16, 2019
@bors-servo
Auto merge of #24734 - paulrouget:tooltip, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5670a45 
Better tooltip for UWP port

Fix #24721
@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing 5670a45 to master...
@bors-servo bors-servo merged commit 8a97aa5 into servo:master Nov 16, 2019
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

HoloLens: keyboard shortcut tooltips are "floating" in the middle of the UI
6 participants
@paulrouget @jdm @bors-servo @CYBAI @Manishearth @highfive
You can’t perform that action at this time.