Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce unnecesarily large borrow in script thread #24742

Merged
merged 1 commit into from Nov 17, 2019
Merged

Reduce unnecesarily large borrow in script thread #24742

merged 1 commit into from Nov 17, 2019

Conversation

@jdm
Copy link
Member

jdm commented Nov 14, 2019

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #24730
  • There are tests for these changes
@highfive
Copy link

highfive commented Nov 14, 2019

Heads up! This PR modifies the following files:
@highfive
Copy link

highfive commented Nov 14, 2019

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm jdm changed the title script: Reduce scope of borrows for history updates. Reduce unnecesarily large borrow in script thread Nov 14, 2019
@jdm
Copy link
Member Author

jdm commented Nov 14, 2019

@bors-servo try=wpt
bors-servo added a commit that referenced this pull request Nov 14, 2019
@bors-servo
Auto merge of #24742 - servo:jdm-patch-34, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3cf9dd6 
Reduce unnecesarily large borrow in script thread

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24730
- [x] There are tests for these changes
@bors-servo
Copy link
Contributor

bors-servo commented Nov 14, 2019

⌛ Trying commit 616334d with merge 3cf9dd6...
@asajeffrey
asajeffrey approved these changes Nov 14, 2019
View changes
Copy link
Member

asajeffrey left a comment

LGTM
@bors-servo
Copy link
Contributor

bors-servo commented Nov 14, 2019

💔 Test failed - linux-rel-css
@jdm
Copy link
Member Author

jdm commented Nov 14, 2019

https://build.servo.org/builders/linux-rel-wpt/builds/14221 and https://build.servo.org/builders/linux-rel-css/builds/14155 have so many improved test results \o/
@asajeffrey
Copy link
Member

asajeffrey commented Nov 14, 2019

That's a lot of CRASHes becoming OK \o/
@jdm
script: Reduce scope of borrows for history updates.
Loading status checks…
8846cda
@jdm jdm force-pushed the jdm-patch-34 branch from 616334d to 8846cda Nov 14, 2019
@jdm
Copy link
Member Author

jdm commented Nov 14, 2019

@bors-servo r=asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented Nov 14, 2019

📌 Commit 8846cda has been approved by asajeffrey
@highfive highfive assigned asajeffrey and unassigned SimonSapin Nov 14, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2019

⌛ Testing commit 8846cda with merge 85d0e99...
bors-servo added a commit that referenced this pull request Nov 15, 2019
@bors-servo
Auto merge of #24742 - servo:jdm-patch-34, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
85d0e99 
Reduce unnecesarily large borrow in script thread

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24730
- [x] There are tests for these changes
@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2019

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member Author

jdm commented Nov 15, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2019

⌛ Testing commit 8846cda with merge 901fef5...
bors-servo added a commit that referenced this pull request Nov 16, 2019
@bors-servo
Auto merge of #24742 - servo:jdm-patch-34, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
901fef5 
Reduce unnecesarily large borrow in script thread

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24730
- [x] There are tests for these changes
@bors-servo
Copy link
Contributor

bors-servo commented Nov 17, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: asajeffrey
Pushing 901fef5 to master...
@bors-servo bors-servo merged commit 8846cda into master Nov 17, 2019
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@bors-servo bors-servo deleted the jdm-patch-34 branch Nov 17, 2019
@bors-servo bors-servo mentioned this pull request Nov 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asajeffrey asajeffrey

Assignees

@asajeffrey asajeffrey

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

referrer-policy tests panic due to refcell borrow errors
5 participants
@jdm @highfive @bors-servo @asajeffrey @SimonSapin
You can’t perform that action at this time.