Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate to rustc 1.41.0-nightly (1bd30ce2a 2019-11-15) #24749
Merged
Conversation
|
@bors-servo try=wpt |
bors-servo
added a commit
that referenced
this pull request
Nov 15, 2019
Update to rustc 1.40.0-nightly (1423bec54 2019-11-05) <!-- Please describe your changes on the following line: --> This is for devs on Windows where the current nightly version of RLS (2019-10-26) is not available. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #___ (GitHub issue number if applicable) <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
This will likely fail some CI jobs (though not WPT) because of new warnings: #24684. Today’s |
|
Oops, but 11-15 fails because of no clippy: Maybe should just wait? |
This reminds me that I had changes waiting for this. I’ve filed #24750 to upgrade to that Nightly, which by the way has both RLS and Clippy. |
|
https://rust-lang.github.io/rustup-components-history/ also says 11-15 has no clippy, am I reading something wrong? |
|
|
saschanaz
changed the title
|
r? @SimonSapin |
|
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 17, 2019
Update to rustc 1.41.0-nightly (1bd30ce2a 2019-11-15) <!-- Please describe your changes on the following line: --> This is for devs on Windows where the current nightly version of RLS (2019-10-26) is not available. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24756 <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 5, 2019
Update to rustc 1.41.0-nightly (6d77e45f0 2019-12-04) This PR is similar to #24749. After #25075 merged, I can't build successfully in my local due to no clippy in that nightly version. ``` → ./mach build -d info: syncing channel updates for 'nightly-2019-12-04-x86_64-apple-darwin' info: latest update on 2019-12-04, rust version 1.41.0-nightly (7afe6d9d1 2019-12-03) error: component 'clippy' for target 'x86_64-apple-darwin' is unavailable for download for channel nightly-2019-12-04 Build FAILED in 0:00:00 ``` --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) - [x] These changes do not require tests because just updated rustc version. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo
added a commit
that referenced
this pull request
Dec 5, 2019
Update to rustc 1.41.0-nightly (6d77e45f0 2019-12-04) This PR is similar to #24749. After #25075 merged, I can't build successfully in my local due to no clippy in that nightly version. ``` → ./mach build -d info: syncing channel updates for 'nightly-2019-12-04-x86_64-apple-darwin' info: latest update on 2019-12-04, rust version 1.41.0-nightly (7afe6d9d1 2019-12-03) error: component 'clippy' for target 'x86_64-apple-darwin' is unavailable for download for channel nightly-2019-12-04 Build FAILED in 0:00:00 ``` --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) - [x] These changes do not require tests because just updated rustc version. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
saschanaz commentedNov 15, 2019
•
edited
This is for devs on Windows where the current nightly version of RLS (2019-10-26) is not available.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors