Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use `#![register_tool]` instead of `Registry::register_attribute` #24750

Merged
merged 2 commits into from Nov 16, 2019
Merged

Use `#![register_tool]` instead of `Registry::register_attribute` #24750

merged 2 commits into from Nov 16, 2019

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Nov 15, 2019

CC rust-lang/rust#66344, rust-lang/rust#66079
@SimonSapin
Use `#![register_attr(…)]` instead of `Registry::register_attribute`
091feba 
CC rust-lang/rust#66344, rust-lang/rust#66080
@highfive
Copy link

highfive commented Nov 15, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webglvertexarrayobjectoes.rs, components/script/canvas_state.rs, components/script/dom/webglframebuffer.rs, components/script/dom/range.rs, components/script/dom/customelementregistry.rs and 36 more
  • @KiChjang: components/script/dom/webglvertexarrayobjectoes.rs, components/script/canvas_state.rs, components/script/dom/webglframebuffer.rs, components/script/dom/range.rs, components/script/dom/customelementregistry.rs and 36 more
@SimonSapin SimonSapin mentioned this pull request Nov 15, 2019
Merged
3 of 5 tasks complete
@SimonSapin
Copy link
Member Author

SimonSapin commented Nov 15, 2019

This requires a compiler upgrade which was blocked by #24684, but is not longer blocked since rust-lang/rust#66378.
@jdm
Copy link
Member

jdm commented Nov 15, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2019

📌 Commit 6df9460 has been approved by jdm
@highfive highfive assigned jdm and unassigned asajeffrey Nov 15, 2019
@jdm
Copy link
Member

jdm commented Nov 15, 2019

@bors-servo p=1
@SimonSapin
Use `#![register_tool]` instead of `#![register_attr]`
Loading status checks…
bea7395 
CC rust-lang/rust#66079
@SimonSapin SimonSapin force-pushed the register-tool branch from 6df9460 to bea7395 Nov 15, 2019
@jdm
Copy link
Member

jdm commented Nov 15, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2019

📌 Commit bea7395 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2019

⌛ Testing commit bea7395 with merge 03d632f...
bors-servo added a commit that referenced this pull request Nov 15, 2019
@bors-servo
Auto merge of #24750 - servo:register-tool, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
03d632f 
Use `#![register_tool]` instead of `Registry::register_attribute`

CC rust-lang/rust#66344, rust-lang/rust#66079
@SimonSapin
Copy link
Member Author

SimonSapin commented Nov 15, 2019

@bors-servo treeclosed=100

Deploying servo/taskcluster-config#4
@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2019

💔 Test failed - status-taskcluster
@SimonSapin
Copy link
Member Author

SimonSapin commented Nov 15, 2019

@bors-servo retry treeclosed-
@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2019

💣 Failed to start rebuilding: 405 Not Allowed
@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2019

⌛ Testing commit bea7395 with merge d92f705...
bors-servo added a commit that referenced this pull request Nov 15, 2019
@bors-servo
Auto merge of #24750 - servo:register-tool, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d92f705 
Use `#![register_tool]` instead of `Registry::register_attribute`

CC rust-lang/rust#66344, rust-lang/rust#66079
@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2019

💔 Test failed - linux-rel-wpt
@SimonSapin
Copy link
Member Author

SimonSapin commented Nov 15, 2019

@bors-servo retry

  ▶ FAIL [expected PASS] /css/CSS2/tables/border-collapse-dynamic-cell-001.xht
  └   → /css/CSS2/tables/border-collapse-dynamic-cell-001.xht 9565d734a7fc1b3d50a261d4a24bd5a950ac2f7d
/css/CSS2/tables/border-collapse-dynamic-cell-001-ref.xht 54a9df64f1476dd12020019d7cf22ac34d727bc0
@jdm
Copy link
Member

jdm commented Nov 15, 2019

That's #24726.
@SimonSapin SimonSapin mentioned this pull request Nov 15, 2019
Merged
@bors-servo
Copy link
Contributor

bors-servo commented Nov 15, 2019

⚡ Previous build results for linux-rel-css, status-taskcluster are reusable. Rebuilding only linux-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing d92f705 to master...
@bors-servo bors-servo merged commit bea7395 into master Nov 16, 2019
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@bors-servo bors-servo deleted the register-tool branch Nov 16, 2019
@bors-servo bors-servo mentioned this pull request Nov 16, 2019
Closed
@saschanaz saschanaz mentioned this pull request Nov 16, 2019
Closed
@Manishearth Manishearth mentioned this pull request Nov 18, 2019
Closed
@SimonSapin SimonSapin mentioned this pull request Nov 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@SimonSapin @highfive @jdm @bors-servo @asajeffrey
You can’t perform that action at this time.