Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAvoid recompiling script every time surfman changes #24752
Merged
Conversation
|
Can land once servo/webxr#91 does. |
|
r? @jdm |
asajeffrey
force-pushed the
asajeffrey:split-surfman-chains-api-and-impl
branch
from
bc00b6f
to
dfed5ef
|
@bors-servo r=jdm |
|
|
|
|
|
|
asajeffrey
force-pushed the
asajeffrey:split-surfman-chains-api-and-impl
branch
from
dfed5ef
to
124de75
|
Rebased. @bors-servo r=jdm |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 19, 2019
…r=jdm Avoid recompiling script every time surfman changes <!-- Please describe your changes on the following line: --> Uses a version of webxr where webxr-api doesn't depend on surfman, so we can make changes to it without rebuilding script. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because it's just build issues <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Nov 19, 2019
…r=jdm Avoid recompiling script every time surfman changes <!-- Please describe your changes on the following line: --> Uses a version of webxr where webxr-api doesn't depend on surfman, so we can make changes to it without rebuilding script. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because it's just build issues <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Nov 19, 2019
…r=jdm Avoid recompiling script every time surfman changes <!-- Please describe your changes on the following line: --> Uses a version of webxr where webxr-api doesn't depend on surfman, so we can make changes to it without rebuilding script. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because it's just build issues <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedNov 15, 2019
Uses a version of webxr where webxr-api doesn't depend on surfman, so we can make changes to it without rebuilding script.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors