Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAutomatically retry failing WPT tasks (once) #24769
Conversation
highfive
commented
Nov 18, 2019
|
Heads up! This PR modifies the following files:
|
|
LGTM, will let @jdm sign it off given that's quite a change. |
|
We could imagine some more automation, such as:
However if triaging not anymore part of the expected retry process, it could grow until someone gives it attention. |
|
Yeah, I think my biggest concern here is losing the ability to determine a meaningful window in which an intermittent failure appeared. We could build some tooling based on the disabled intermittent failure reporting that already exists that only reports the filtered summary (like you suggested), and then make it someone's responsibility to check every day or two and file new issues. |
|
Alright. I’m not planning to build that tooling soon, so let’s close this PR and keep #23655 open. |
SimonSapin commentedNov 18, 2019
•
edited
Fixes #23655
Only when
./mach filter-intermittentsfinds failures that are not known intermittents.This will make PRs much more likely to land without manual retry. However it will give us a lot less opportunity to see which tests fail intermittently, file issues based on test filenames, track them, etc.