Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support translation in webxr on desktop #24776

Merged
merged 2 commits into from Nov 20, 2019
Merged

Support translation in webxr on desktop #24776

merged 2 commits into from Nov 20, 2019

Conversation

@jdm
Copy link
Member

jdm commented Nov 18, 2019

This makes it possible to roam around webxr scenes using the WASD keys, and the arrow keys continue to change the user's orientation.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #24773
  • These changes do not require tests because no tests for interactive webxr content
@jdm
Copy link
Member Author

jdm commented Nov 18, 2019

r? @Manishearth
@highfive highfive assigned Manishearth and unassigned nox Nov 18, 2019
@jdm
Copy link
Member Author

jdm commented Nov 18, 2019

Depends on servo/webxr#93.
@Manishearth
Manishearth approved these changes Nov 18, 2019
View changes
@jdm jdm force-pushed the jdm:xr-translate branch from d9231a2 to c6cc934 Nov 18, 2019
@jdm
Copy link
Member Author

jdm commented Nov 18, 2019

@bors-servo r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Nov 18, 2019

📌 Commit c6cc934 has been approved by Manishearth
@jdm jdm force-pushed the jdm:xr-translate branch from c6cc934 to d01c6f7 Nov 19, 2019
@jdm
Copy link
Member Author

jdm commented Nov 19, 2019

@bors-servo r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Nov 19, 2019

📌 Commit d01c6f7 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Nov 19, 2019

⌛ Testing commit d01c6f7 with merge de0bec3...
bors-servo added a commit that referenced this pull request Nov 19, 2019
@bors-servo
Auto merge of #24776 - jdm:xr-translate, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
de0bec3 
Support translation in webxr on desktop

This makes it possible to roam around webxr scenes using the WASD keys, and the arrow keys continue to change the user's orientation.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24773
- [x] These changes do not require tests because no tests for interactive webxr content
@bors-servo
Copy link
Contributor

bors-servo commented Nov 19, 2019

💔 Test failed - linux-rel-css
@bors-servo
Copy link
Contributor

bors-servo commented Nov 19, 2019

☔ The latest upstream changes (presumably #24752) made this pull request unmergeable. Please resolve the merge conflicts.
jdm added 2 commits Nov 18, 2019
@jdm
glutin: Use existing routines for rounding physical/logical sizes.
68b832d
@jdm
glutin: Support WASD for translating positing in webxr content.
Loading status checks…
5c08378
@jdm jdm force-pushed the jdm:xr-translate branch from d01c6f7 to 5c08378 Nov 19, 2019
@jdm
Copy link
Member Author

jdm commented Nov 19, 2019

@bors-servo r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Nov 19, 2019

📌 Commit 5c08378 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Nov 19, 2019

⌛ Testing commit 5c08378 with merge d3db4bf...
bors-servo added a commit that referenced this pull request Nov 19, 2019
@bors-servo
Auto merge of #24776 - jdm:xr-translate, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d3db4bf 
Support translation in webxr on desktop

This makes it possible to roam around webxr scenes using the WASD keys, and the arrow keys continue to change the user's orientation.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24773
- [x] These changes do not require tests because no tests for interactive webxr content
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented Nov 20, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2019

💣 Failed to start rebuilding: 405 Not Allowed
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2019

⌛ Testing commit 5c08378 with merge e07f028...
bors-servo added a commit that referenced this pull request Nov 20, 2019
@bors-servo
Auto merge of #24776 - jdm:xr-translate, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e07f028 
Support translation in webxr on desktop

This makes it possible to roam around webxr scenes using the WASD keys, and the arrow keys continue to change the user's orientation.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24773
- [x] These changes do not require tests because no tests for interactive webxr content
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: Manishearth
Pushing e07f028 to master...
@bors-servo bors-servo merged commit 5c08378 into servo:master Nov 20, 2019
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth

Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Support translation in glwindow webxr backend
5 participants
@jdm @bors-servo @Manishearth @nox @highfive
You can’t perform that action at this time.