Enable webxr by default #24777

jdm · 2019-11-18T19:52:22Z

This changes two things:

enable WebXR by default, since it's not exactly an experimental technology in Servo anymore
enable the glwindow webxr backend by default so it's easier to test WebXR on desktop nightlies

Since the glwindow pref is only checked in the glutin desktop port, enabling it for other ports does not hurt us at all and it removes a papercut for testing WebXR content on desktop.

This change is

jdm · 2019-11-18T19:52:31Z

r? @Manishearth

Manishearth

(Wouldn't this require interfaces.html updates in the mozilla tests?)

So I'm okay with landing this, but also I'm a bit wary: this means we're releasing webxr by default, and we need to figure out how that factors in to web stability stuff. Firstly: Are we allowed to do this? Is it okay to release a browser containing currently-still-in-flux APIs? I guess webxr is very close to shipping/stabilizing so perhaps we're fine on that front.

Also, does this count as a separate shipped implementation according to the w3c? (because then servo+firefox might automatically count for various spec stability requirements). Servo is currently only "shipped" as a nightly, so perhaps none of this is relevant yet. But I don't know.

cc @larsbergstrom

Manishearth · 2019-11-18T21:53:12Z

@bors-servo r+

from reading https://www.w3.org/2019/Process-20190301/#implementation-experience it seems like it doesn't really matter if it's enabled by default or not

bors-servo · 2019-11-18T21:53:13Z

📌 Commit 4a8e5dc has been approved by Manishearth

larsbergstrom · 2019-11-18T21:59:30Z

As Servo is not currently shipping in a production browser to end users, it has not been considered a separate "shipped" browser in the W3C/Khronos sense to date. Once that does happen, the specific browser context (e.g., Firefox Reality on Hololens2) would "count", but the engine would be a slightly different thing, as it is for the difference between blink or webkit implementing something vs. Chrome or Safari shipping it. e.g., last I checked WebVR is in webkit due to some awesome work by Igalia, but is not on by default in any webkit-derived browser.

bors-servo · 2019-11-19T08:50:17Z

⌛ Testing commit 4a8e5dc with merge ad9148c...


        Auto merge of #24777 - servo:jdm-patch-34, r=Manishearth

Enable webxr by default This changes two things: * enable WebXR by default, since it's not exactly an experimental technology in Servo anymore * enable the glwindow webxr backend by default so it's easier to test WebXR on desktop nightlies Since the glwindow pref is only checked in the glutin desktop port, enabling it for other ports does not hurt us at all and it removes a papercut for testing WebXR content on desktop.

bors-servo · 2019-11-19T09:21:43Z

💔 Test failed - linux-rel-css

jdm · 2019-11-19T19:31:33Z

@bors-servo r=Manishearth

bors-servo · 2019-11-19T19:31:35Z

📌 Commit 46ff8a8 has been approved by Manishearth

bors-servo · 2019-11-20T00:48:47Z

⌛ Testing commit 46ff8a8 with merge bb68e6b...


        Auto merge of #24777 - servo:jdm-patch-34, r=Manishearth

Enable webxr by default This changes two things: * enable WebXR by default, since it's not exactly an experimental technology in Servo anymore * enable the glwindow webxr backend by default so it's easier to test WebXR on desktop nightlies Since the glwindow pref is only checked in the glutin desktop port, enabling it for other ports does not hurt us at all and it removes a papercut for testing WebXR content on desktop.

bors-servo · 2019-11-20T02:56:20Z

💔 Test failed - status-taskcluster

CYBAI · 2019-11-20T03:14:44Z

 0:09.11�(B ERROR�(B Manifest /repo/tests/wpt/mozilla/meta/MANIFEST.json is outdated, use |./mach update-manifest| to fix.

jdm · 2019-11-20T14:31:00Z

@bors-servo r=Manishearth

bors-servo · 2019-11-20T14:31:02Z

📌 Commit 0863fc4 has been approved by Manishearth

bors-servo · 2019-11-20T17:57:30Z

☔ The latest upstream changes (presumably #24499) made this pull request unmergeable. Please resolve the merge conflicts.

jdm · 2019-11-20T18:34:06Z

@bors-servo r=Manishearth

bors-servo · 2019-11-20T18:34:07Z

📌 Commit 5e2f260 has been approved by Manishearth

bors-servo · 2019-11-20T19:26:35Z

⌛ Testing commit 5e2f260 with merge 994ab2d...


        Auto merge of #24777 - servo:jdm-patch-34, r=Manishearth

Enable webxr by default This changes two things: * enable WebXR by default, since it's not exactly an experimental technology in Servo anymore * enable the glwindow webxr backend by default so it's easier to test WebXR on desktop nightlies Since the glwindow pref is only checked in the glutin desktop port, enabling it for other ports does not hurt us at all and it removes a papercut for testing WebXR content on desktop.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24777)


        Enable webxr by default.

jdm · 2019-11-20T21:16:38Z

@bors-servo r=Manishearth

bors-servo · 2019-11-20T21:16:39Z

📌 Commit b816c0f has been approved by Manishearth

bors-servo · 2019-11-20T21:37:40Z

⌛ Testing commit b816c0f with merge eb363ec...


        Auto merge of #24777 - servo:jdm-patch-34, r=Manishearth

Enable webxr by default This changes two things: * enable WebXR by default, since it's not exactly an experimental technology in Servo anymore * enable the glwindow webxr backend by default so it's easier to test WebXR on desktop nightlies Since the glwindow pref is only checked in the glutin desktop port, enabling it for other ports does not hurt us at all and it removes a papercut for testing WebXR content on desktop.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24777)

bors-servo · 2019-11-20T23:38:30Z

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: Manishearth
Pushing eb363ec to master...

highfive assigned paulrouget Nov 18, 2019

jdm changed the title ~~Enable webxr by default.~~ Enable webxr by default Nov 18, 2019

highfive added the S-awaiting-review label Nov 18, 2019

highfive assigned Manishearth and unassigned paulrouget Nov 18, 2019

Manishearth approved these changes Nov 18, 2019

View changes

highfive added S-awaiting-merge and removed S-awaiting-review labels Nov 18, 2019

highfive added S-tests-failed and removed S-awaiting-merge labels Nov 19, 2019

jdm force-pushed the jdm-patch-34 branch from 4a8e5dc to 46ff8a8 Nov 19, 2019

highfive added S-awaiting-review and removed S-tests-failed labels Nov 19, 2019

highfive added S-awaiting-merge and removed S-awaiting-review labels Nov 19, 2019

highfive added S-tests-failed and removed S-awaiting-merge labels Nov 20, 2019

highfive added S-awaiting-merge and removed S-awaiting-review labels Nov 20, 2019

highfive added S-needs-rebase and removed S-awaiting-merge labels Nov 20, 2019

jdm force-pushed the jdm-patch-34 branch from 0863fc4 to 5e2f260 Nov 20, 2019

highfive added the S-awaiting-review label Nov 20, 2019

highfive added S-awaiting-merge and removed S-awaiting-review S-needs-rebase labels Nov 20, 2019

Enable webxr by default.

Loading status checks…

b816c0f

jdm force-pushed the jdm-patch-34 branch from 5e2f260 to b816c0f Nov 20, 2019

highfive added S-awaiting-review and removed S-awaiting-merge labels Nov 20, 2019

highfive added S-awaiting-merge and removed S-awaiting-review labels Nov 20, 2019

bors-servo merged commit b816c0f into master Nov 20, 2019
2 checks passed

2 checks passed

Community-TC (pull_request) TaskGroup: success
Details

homu Test successful
Details

bors-servo deleted the jdm-patch-34 branch Nov 20, 2019

highfive removed the S-awaiting-merge label Nov 20, 2019

servo / servo

Enable webxr by default #24777

Enable webxr by default #24777

jdm commented Nov 18, 2019 •

edited by larsbergstrom

jdm commented Nov 18, 2019

Manishearth left a comment

Manishearth commented Nov 18, 2019

bors-servo commented Nov 18, 2019

larsbergstrom commented Nov 18, 2019

bors-servo commented Nov 19, 2019

bors-servo commented Nov 19, 2019

jdm commented Nov 19, 2019

bors-servo commented Nov 19, 2019

bors-servo commented Nov 20, 2019

bors-servo commented Nov 20, 2019

CYBAI commented Nov 20, 2019

jdm commented Nov 20, 2019

bors-servo commented Nov 20, 2019

bors-servo commented Nov 20, 2019

jdm commented Nov 20, 2019

bors-servo commented Nov 20, 2019

bors-servo commented Nov 20, 2019

jdm commented Nov 20, 2019

bors-servo commented Nov 20, 2019

bors-servo commented Nov 20, 2019

bors-servo commented Nov 20, 2019

servo / servo

Join GitHub today

Enable webxr by default #24777

Enable webxr by default #24777

Conversation

jdm commented Nov 18, 2019 • edited by larsbergstrom

jdm commented Nov 18, 2019

Manishearth left a comment

Manishearth commented Nov 18, 2019

bors-servo commented Nov 18, 2019

larsbergstrom commented Nov 18, 2019

bors-servo commented Nov 19, 2019

bors-servo commented Nov 19, 2019

jdm commented Nov 19, 2019

bors-servo commented Nov 19, 2019

bors-servo commented Nov 20, 2019

bors-servo commented Nov 20, 2019

CYBAI commented Nov 20, 2019

jdm commented Nov 20, 2019

bors-servo commented Nov 20, 2019

bors-servo commented Nov 20, 2019

jdm commented Nov 20, 2019

bors-servo commented Nov 20, 2019

bors-servo commented Nov 20, 2019

jdm commented Nov 20, 2019

bors-servo commented Nov 20, 2019

bors-servo commented Nov 20, 2019

bors-servo commented Nov 20, 2019

jdm commented Nov 18, 2019 •

edited by larsbergstrom