Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move WPT Linux from Buildbot to Taskcluster #24785

Merged
merged 3 commits into from Nov 20, 2019
Merged

Move WPT Linux from Buildbot to Taskcluster #24785

merged 3 commits into from Nov 20, 2019

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Nov 19, 2019

Closes #24418
SimonSapin added 2 commits Nov 19, 2019
@SimonSapin
Fix run.dockerfile to actually be able to run current Servo
b38fd6b 
… and avoid runtime errors about missing gstreamer plugins
@SimonSapin
Tweak WPT task names and config
81a03c1
@SimonSapin
Copy link
Member Author

SimonSapin commented Nov 19, 2019

This run looks pretty good, I think? https://community-tc.services.mozilla.com/tasks/groups/XVj2vEiQT_K-RK9MYhBJlA

Filtered log:

  ▶ TIMEOUT [expected OK] /webdriver/tests/element_send_keys/file_upload.py
  │ 
  └ [2019-11-19T16:40:02Z ERROR script::dom::bindings::error] Error at :2:28 arguments[0] is undefined

  ▶ PASS [expected FAIL] /_mozilla/css/text_decoration_underline_subpx_a.html

  ▶ PASS [expected FAIL] /css/css-text/word-break/word-break-break-all-005.html

  ▶ OK [expected CRASH] /_mozilla/mozilla/fetch_cannot_overwhelm_system.window.html
@jdm
jdm approved these changes Nov 19, 2019
View changes
@SimonSapin
Copy link
Member Author

SimonSapin commented Nov 19, 2019

A second run got the exact same filtered unexpected results, so they don’t look intermittent: https://community-tc.services.mozilla.com/tasks/groups/UhZtEvtISO-VD3qkSvNRRA

I don’t have a precise explanation for these differences with Buildbot, but we’re running Ubuntu 18.04 instead of 14.04 and Ubuntu’s gstreamer instead of https://github.com/servo/servo/wiki/How-to-generate-GStreamer-binaries-for-CI
@jdm
Copy link
Member

jdm commented Nov 19, 2019

Yeah, I would go ahead and add linux-specific expected results for those tests.
@SimonSapin SimonSapin force-pushed the linux-wpt2 branch from 4d7a9b0 to b4a9cca Nov 19, 2019
@SimonSapin
Move WPT Linux from Buildbot to Taskcluster
Loading status checks…
34287e5 
Update expectations as differences don’t look intermittent:
#24785 (comment)

Fixes #23569
@SimonSapin SimonSapin force-pushed the linux-wpt2 branch from b4a9cca to 34287e5 Nov 19, 2019
@SimonSapin
Copy link
Member Author

SimonSapin commented Nov 19, 2019

Alright, let’s see how this looks.

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Nov 19, 2019

⌛ Trying commit 34287e5 with merge 1472407...
bors-servo added a commit that referenced this pull request Nov 19, 2019
@bors-servo
Auto merge of #24785 - servo:linux-wpt2, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1472407 
Move WPT Linux from Buildbot to Taskcluster

Closes #24418
@SimonSapin
Copy link
Member Author

SimonSapin commented Nov 19, 2019

Currently this runs on GCP instances that have 16 “vCPU” (which as I understand it map to 8 cores / 16 threads). We can change max capacity (number of instances running concurrently) or the machine type in https://community-tc.services.mozilla.com/worker-manager/proj-servo%2Fdocker and send a PR to projects.yml in mozilla/community-tc-config in order to make that change persistent (not overwritten next time someone runs tc-admin in that repository).

Other knobs at disposal are the number of chunks (= number of tasks), and the number of wptrunner processes per task.

With the current config the time for release build + WPT tasks on Linux is well under that of macOS, which remains the limiting factor for cycle time.
@bors-servo
Copy link
Contributor

bors-servo commented Nov 19, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
State: approved= try=True
@SimonSapin
Copy link
Member Author

SimonSapin commented Nov 19, 2019

Per your previous comments:

@bors-servo r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented Nov 19, 2019

📌 Commit 34287e5 has been approved by jdm
@highfive highfive assigned jdm and unassigned ferjm Nov 19, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2019

⌛ Testing commit 34287e5 with merge 6d4a09e...
bors-servo added a commit that referenced this pull request Nov 20, 2019
@bors-servo
Auto merge of #24785 - servo:linux-wpt2, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6d4a09e 
Move WPT Linux from Buildbot to Taskcluster

Closes #24418
@bors-servo
Copy link
Contributor

bors-servo commented Nov 20, 2019

☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster
Approved by: jdm
Pushing 6d4a09e to master...
@bors-servo bors-servo merged commit 34287e5 into master Nov 20, 2019
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@bors-servo bors-servo deleted the linux-wpt2 branch Nov 20, 2019
@bors-servo bors-servo mentioned this pull request Nov 20, 2019
Merged
3 of 3 tasks complete
SimonSapin added a commit to servo/saltfs that referenced this pull request Nov 22, 2019
@SimonSapin
Disable gating servo/servo PRs on Buildbot
Loading status checks…
65142dd 
It’s only no-op jobs since servo/servo#24785
@SimonSapin SimonSapin mentioned this pull request Nov 22, 2019
Merged
bors-servo added a commit to servo/saltfs that referenced this pull request Nov 22, 2019
@bors-servo
Auto merge of #988 - servo:nogate, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d973971 
Disable gating servo/servo PRs on Buildbot

It’s only no-op jobs since servo/servo#24785

This doesn’t yet shut down Buildbot or remove its config, in case we want to move back.
@SimonSapin SimonSapin mentioned this pull request Nov 22, 2019
Closed
27 of 31 tasks complete
jdm added a commit to jdm/servo that referenced this pull request Dec 14, 2019
@SimonSapin @jdm
Move WPT Linux from Buildbot to Taskcluster
05c0705 
Update expectations as differences don’t look intermittent:
servo#24785 (comment)

Fixes servo#23569
@jdm jdm mentioned this pull request Dec 17, 2019
Closed
jdm added a commit to jdm/servo that referenced this pull request Dec 20, 2019
@SimonSapin @jdm
Move WPT Linux from Buildbot to Taskcluster
5bca51f 
Update expectations as differences don’t look intermittent:
servo#24785 (comment)

Fixes servo#23569
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

[WIP] Enable WPT on Linux in Taskcluster
5 participants
@SimonSapin @jdm @bors-servo @ferjm @highfive
You can’t perform that action at this time.