Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUnindent Document::set_activity #24817
Merged
Conversation
highfive
commented
Nov 21, 2019
|
Heads up! This PR modifies the following files:
|
jdm
changed the title
highfive
commented
Nov 21, 2019
|
|
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 21, 2019
Unindent Document::set_activity I was reading this method while reviewing some code and I find the early-return version easier to read.
|
|
|
@bors-servo retry |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 22, 2019
Unindent Document::set_activity I was reading this method while reviewing some code and I find the early-return version easier to read.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedNov 21, 2019
I was reading this method while reviewing some code and I find the early-return version easier to read.