New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start implementing text in layout 2020 #24822
Merged
+311
−42
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1446756
Pass a LayoutContext to TextRun::layout in 2020
nox 6f49dc2
Properly use STYLE_THREAD_POOL in layout 2020
nox a5e55dd
Introduce GlyphStore::total_advance
nox 7e143c7
Make floats not parse on layout 2020
nox b3d30d2
Start implementing text in layout 2020
nox 85b2a4d
Support line_height better in layout 2020
nox File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.
Make floats not parse on layout 2020
- Loading branch information
commit 7e143c7a05c8ffce3806d8b1517dda8b6cb3f34b
| @@ -63,6 +63,7 @@ ${helpers.predefined_type( | ||
| "Float", | ||
| "computed::Float::None", | ||
| engines="gecko servo-2013 servo-2020", | ||
| servo_2020_pref="layout.2020.unimplemented", | ||
|
This conversation was marked as resolved
by nox
nox
Author
Member
|
||
| initial_specified_value="specified::Float::None", | ||
| spec="https://drafts.csswg.org/css-box/#propdef-float", | ||
| animation_value_type="discrete", | ||
ProTip!
Use n and p to navigate between commits in a pull request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Oops! Not sure how I missed this before, and sorry it ended up causing so much headaches…