Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start implementing text in layout 2020 #24822

Merged
merged 6 commits into from Nov 25, 2019

Make floats not parse on layout 2020

  • Loading branch information
nox committed Nov 25, 2019
commit 7e143c7a05c8ffce3806d8b1517dda8b6cb3f34b
@@ -63,6 +63,7 @@ ${helpers.predefined_type(
"Float",
"computed::Float::None",
engines="gecko servo-2013 servo-2020",
servo_2020_pref="layout.2020.unimplemented",
This conversation was marked as resolved by nox

This comment has been minimized.

Copy link
@SimonSapin

SimonSapin Nov 22, 2019

Member

Oops! Not sure how I missed this before, and sorry it ended up causing so much headaches…

This comment has been minimized.

Copy link
@nox

nox Nov 25, 2019

Author Member

No problem, I realised way too late that basically all of servo.org is in a float.

initial_specified_value="specified::Float::None",
spec="https://drafts.csswg.org/css-box/#propdef-float",
animation_value_type="discrete",
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.