Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for squeeze events #24838
Merged
Conversation
highfive
commented
Nov 22, 2019
|
Heads up! This PR modifies the following files:
|
highfive
commented
Nov 22, 2019
|
|
|
@bors-servo r=jdm taskcluster failure is because servo isn't updated yet |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 22, 2019
Add support for squeeze events Depends on servo/webxr#98
bors-servo
added a commit
to servo/webxr
that referenced
this pull request
Nov 22, 2019
Prepare API for squeeze events We can't yet support squeeze events on hololens, but the code here will make it super easy to add support when we need to. r? @jdm This is a breaking change and needs to be landed simultaneously with servo/servo#24838
|
@bors-servo r=jdm |
|
|
|
@bors-servo r- |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 22, 2019
Add support for squeeze events Depends on servo/webxr#98
|
@bors-servo r=jdm |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 22, 2019
Add support for squeeze events Depends on servo/webxr#98
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedNov 22, 2019
Depends on servo/webxr#98