Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make JS runnables for workers execute on correct event loop #24842

Merged
merged 1 commit into from Nov 26, 2019
Merged

Make JS runnables for workers execute on correct event loop #24842

merged 1 commit into from Nov 26, 2019

Conversation

@jdm
Copy link
Member

jdm commented Nov 22, 2019

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #24812
@highfive
Copy link

highfive commented Nov 22, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/dedicatedworkerglobalscope.rs
  • @KiChjang: components/script/dom/dedicatedworkerglobalscope.rs
@jdm
Copy link
Member Author

jdm commented Nov 22, 2019

@bors-servo try=wpt
@highfive
Copy link

highfive commented Nov 22, 2019

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@bors-servo
Copy link
Contributor

bors-servo commented Nov 22, 2019

⌛ Trying commit 1e56f12 with merge 3ad1b7c...
bors-servo added a commit that referenced this pull request Nov 22, 2019
@bors-servo
Auto merge of #24842 - servo:jdm-patch-34, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3ad1b7c 
Make JS runnables for workers execute on correct event loop

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24812
@bors-servo
Copy link
Contributor

bors-servo commented Nov 22, 2019

💔 Test failed - status-taskcluster
@jdm
Ensure JS runnables are dispatched to a worker's event loop instead o…
Loading status checks…
0f30755 
…f its parent.
@jdm jdm force-pushed the jdm-patch-34 branch from 1e56f12 to 0f30755 Nov 22, 2019
@jdm
Copy link
Member Author

jdm commented Nov 22, 2019

That's a nice set of improved test results.
@jdm
Copy link
Member Author

jdm commented Nov 26, 2019

@nox Review ping.
@nox
Copy link
Member

nox commented Nov 26, 2019

@bors-servo r+

Oops.
@bors-servo
Copy link
Contributor

bors-servo commented Nov 26, 2019

📌 Commit 0f30755 has been approved by nox
bors-servo added a commit that referenced this pull request Nov 26, 2019
@bors-servo
Auto merge of #24842 - servo:jdm-patch-34, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7a72f8a 
Make JS runnables for workers execute on correct event loop

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24812
@bors-servo
Copy link
Contributor

bors-servo commented Nov 26, 2019

⌛ Testing commit 0f30755 with merge 7a72f8a...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 26, 2019

☀️ Test successful - status-taskcluster
Approved by: nox
Pushing 7a72f8a to master...
@bors-servo bors-servo merged commit 0f30755 into master Nov 26, 2019
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@bors-servo bors-servo deleted the jdm-patch-34 branch Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

JS runnables from worker threads do not run on the correct event loop
4 participants
@jdm @highfive @bors-servo @nox
You can’t perform that action at this time.