Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt user to install OpenXR package if not installed #24854

Merged
merged 1 commit into from Nov 26, 2019

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Nov 25, 2019

Fix #24086

It's important to note that this PR introduces a restricted capability. During the app store submission process we will need to justify why we want to use that capability.

This piece of UI is important for the Emulator, where OpenXR is not available by default.

Windows::UI::Xaml::DispatcherTimer timer;
inline static const hstring OPENXR_PACKAGE_NAME =
L"Microsoft.MixedRealityRuntimeDeveloperPreview_8wekyb3d8bbwe";
inline static const hstring OPENXR_PACAKGE_SHORTER_NAME =

This comment has been minimized.

Copy link
@Manishearth

Manishearth Nov 25, 2019

Member

spelling of constant

@paulrouget paulrouget force-pushed the paulrouget:xrprompt branch from 7601af7 to 75b522d Nov 26, 2019
@paulrouget
Copy link
Contributor Author

paulrouget commented Nov 26, 2019

@bors-servo r=Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Nov 26, 2019

📌 Commit 75b522d has been approved by Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Nov 26, 2019

Testing commit 75b522d with merge 75aba2b...

bors-servo added a commit that referenced this pull request Nov 26, 2019
Prompt user to install OpenXR package if not installed

Fix #24086

It's important to note that this PR introduces a restricted capability. During the app store submission process we will need to justify why we want to use that capability.

This piece of UI is important for the Emulator, where OpenXR is not available by default.
@bors-servo
Copy link
Contributor

bors-servo commented Nov 26, 2019

☀️ Test successful - status-taskcluster
Approved by: Manishearth
Pushing 75aba2b to master...

@bors-servo bors-servo merged commit 75b522d into servo:master Nov 26, 2019
1 of 2 checks passed
1 of 2 checks passed
Community-TC (pull_request) TaskGroup: failure
Details
homu Test successful
Details
@jdm jdm added this to Done in HoloLens Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
HoloLens
  
Done
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.