Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDon't panic if surfman initialization fails. #24859
Merged
+24
−9
Conversation
highfive
commented
Nov 25, 2019
|
|
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 26, 2019
Don't panic if surfman initialization fails. Since WebGL is only one component of the web platform, there's no reason that failing to initialize surfman for webgl support should take down the entire browser. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24642 (in that the browser will now start up) and fix #24627 - [x] These changes do not require tests because tests for graphics acceleration? don't make me laugh.
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Nov 26, 2019
Don't panic if surfman initialization fails. Since WebGL is only one component of the web platform, there's no reason that failing to initialize surfman for webgl support should take down the entire browser. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24642 (in that the browser will now start up) and fix #24627 - [x] These changes do not require tests because tests for graphics acceleration? don't make me laugh.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedNov 25, 2019
Since WebGL is only one component of the web platform, there's no reason that failing to initialize surfman for webgl support should take down the entire browser.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors