Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract IPC out of webrender #24875

Merged
merged 1 commit into from Nov 28, 2019
Merged

Extract IPC out of webrender #24875

merged 1 commit into from Nov 28, 2019

Conversation

@jdm
Copy link
Member

jdm commented Nov 26, 2019 •
edited

Fixes #20172. Fixes #13480.
@highfive
Copy link

highfive commented Nov 26, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/window.rs, components/script/dom/htmlmediaelement.rs, components/script/dom/bindings/trace.rs, components/script/Cargo.toml, components/constellation/pipeline.rs and 3 more
  • @cbrewster: components/constellation/pipeline.rs, components/constellation/Cargo.toml, components/constellation/constellation.rs
  • @KiChjang: components/net/image_cache.rs, components/script/dom/window.rs, components/script_traits/lib.rs, components/net_traits/lib.rs, components/script/dom/htmlmediaelement.rs and 7 more
  • @emilio: components/layout/Cargo.toml
@highfive
Copy link

highfive commented Nov 26, 2019

warning Warning warning

  • These commits modify net, layout, gfx, and script code, but no tests are modified. Please consider adding a test!
@jdm jdm unassigned ferjm Nov 26, 2019
@jdm jdm removed the S-awaiting-review label Nov 26, 2019
@jdm
Copy link
Member Author

jdm commented Nov 26, 2019

@bors-servo try=wpt
@bors-servo
Copy link
Contributor

bors-servo commented Nov 26, 2019

⌛ Trying commit bb74a75 with merge 1e18c57...
bors-servo added a commit that referenced this pull request Nov 26, 2019
@bors-servo
Auto merge of #24875 - jdm:wr-no-ipc, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1e18c57 
Extract IPC out of webrender
@jdm
Copy link
Member Author

jdm commented Nov 26, 2019 •
edited

Note to self:
@bors-servo
Copy link
Contributor

bors-servo commented Nov 26, 2019

💔 Test failed - status-taskcluster
@jdm jdm force-pushed the jdm:wr-no-ipc branch from bb74a75 to 48790de Nov 26, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Nov 26, 2019

☔ The latest upstream changes (presumably #24758) made this pull request unmergeable. Please resolve the merge conflicts.
@jdm jdm force-pushed the jdm:wr-no-ipc branch 3 times, most recently from ad54500 to 8816ccb Nov 26, 2019
@jdm jdm marked this pull request as ready for review Nov 26, 2019
@jdm jdm removed the S-needs-rebase label Nov 26, 2019
@jdm
Copy link
Member Author

jdm commented Nov 26, 2019

r? @asajeffrey

I realized that this can land separately from https://github.com/jdm/webrender/tree/no-ipc; all we have to do is stop using the optional ipc feature from WebRender.
@jdm jdm force-pushed the jdm:wr-no-ipc branch 2 times, most recently from 14e1afc to 05afb9b Nov 26, 2019
@asajeffrey
Copy link
Member

asajeffrey commented Nov 27, 2019

Ooh this looks pretty good. I'll have a proper look later today.
@jdm jdm mentioned this pull request Nov 27, 2019
Merged
@jdm jdm force-pushed the jdm:wr-no-ipc branch from 05afb9b to 94a8cff Nov 27, 2019
@asajeffrey
asajeffrey approved these changes Nov 27, 2019
View changes
Copy link
Member

asajeffrey left a comment

LGTM, some minor nits. Lots of new tests that pass yay! One new test that fails, do you know why?
components/canvas/lib.rs Show resolved Hide resolved
components/constellation/constellation.rs Outdated Show resolved Hide resolved
tests/wpt/metadata/css/CSS2/tables/table-anonymous-objects-009.xht.ini Show resolved Hide resolved
.../the-fieldset-and-legend-elements/fieldset-transform-translatez.html.ini Outdated Show resolved Hide resolved
bors-servo added a commit that referenced this pull request Nov 27, 2019
@bors-servo
Auto merge of #24875 - jdm:wr-no-ipc, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c6610e4 
Extract IPC out of webrender

Fixes #20172. Fixes #13480.
@bors-servo
Copy link
Contributor

bors-servo commented Nov 27, 2019

💔 Test failed - status-taskcluster
@jdm jdm force-pushed the jdm:wr-no-ipc branch from 4623935 to e5d6961 Nov 27, 2019
@jdm
Copy link
Member Author

jdm commented Nov 27, 2019

@bors-servo r=asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented Nov 27, 2019

📌 Commit e5d6961 has been approved by asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented Nov 27, 2019

⌛ Testing commit e5d6961 with merge a4b62f3...
bors-servo added a commit that referenced this pull request Nov 27, 2019
@bors-servo
Auto merge of #24875 - jdm:wr-no-ipc, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a4b62f3 
Extract IPC out of webrender

Fixes #20172. Fixes #13480.
@bors-servo
Copy link
Contributor

bors-servo commented Nov 27, 2019

💔 Test failed - status-taskcluster
@jdm
Use non-IPC webrender API over explicit IPC channels.
Loading status checks…
564c16d
@jdm jdm force-pushed the jdm:wr-no-ipc branch from e5d6961 to 564c16d Nov 28, 2019
@jdm
Copy link
Member Author

jdm commented Nov 28, 2019

@bors-servo r=asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented Nov 28, 2019

📌 Commit 564c16d has been approved by asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented Nov 28, 2019

⌛ Testing commit 564c16d with merge 5f1681a...
bors-servo added a commit that referenced this pull request Nov 28, 2019
@bors-servo
Auto merge of #24875 - jdm:wr-no-ipc, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5f1681a 
Extract IPC out of webrender

Fixes #20172. Fixes #13480.
@bors-servo
Copy link
Contributor

bors-servo commented Nov 28, 2019

☀️ Test successful - status-taskcluster
Approved by: asajeffrey
Pushing 5f1681a to master...
@bors-servo bors-servo merged commit 564c16d into servo:master Nov 28, 2019
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Nov 28, 2019
Merged
4 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asajeffrey asajeffrey

Assignees

@asajeffrey asajeffrey

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Extract IPC usage from WebRender into Servo
intermittent crash ("Connection reset by peer" from create_api) in /html/semantics/embedded-content/the-canvas-element/2d.getcontext.shared.html, /html/semantics/scripting-1/the-template-element/template-element/node-document-changes.html, /dom/traversal/TreeWalker-walking-outside-a-tree.html, /XMLHttpRequest/responseText-status.html, /_mozilla/css/line_break_nowrap.html
5 participants
@jdm @highfive @bors-servo @asajeffrey @ferjm
You can’t perform that action at this time.