Add ALPN and signature algorithms to OpenSSL config #24976

Darkspirit · 2019-11-30T03:42:55Z

Updated http crate from 0.1.17 to 0.1.20.
Updated hyper from 0.12.33 to 0.12.35.
Updated hyper-openssl from 0.7.0 to 0.7.1.
Updated openssl crate from 0.10.11 to 0.10.26.
- Set ALPN to h2+http/1.1 for https (Enabled HTTP2) and http/1.1 for websockets.
- Restricted signature algorithms to the same list across platforms: EdDSA at first, then ECDSA, then TLS 1.3's RSA(-PSS), then classic RSA (PKCS#1 1.5).
  Thereby we disabled the following non-web-standard signature algorithms: SHA512/ECDSA, SHA224/ECDSA, SHA1/ECDSA, SHA224/RSA, SHA224/DSA, SHA1/DSA, SHA256/DSA, SHA384/DSA, SHA512/DSA. SHA1/RSA is almost dead and now only used by a few old and broken F5 load balancers: Like TLS 1.0 deprecation, we can again deprecate this some months earlier than other browsers.
- Added Chacha20 to TLS 1.2 ciphersuite list and preferred it like Firefox and Rustls. Removed legacy and privacy-hostile plain RSA (AES256-SHA, AES128-SHA).
  Compared to Mozilla intermediate v5 we keep ECDHE-RSA-AES256-SHA and ECDHE-RSA-AES128-SHA for now, but won't reintroduce deprecated DHE.
- Switched server-side to Mozilla intermediate v5 in components/net/tests/main.rs. (The new modern would have been TLSv1.3-only, therefore only worked with OpenSSL 1.1.1 which is unfortunately not yet used on every target.)
- Renamed ssl_connector_builder(certs) to the more neutral and long-term better fitting create_tls_config(certs, alpn) as it was done in #24764.

./mach build -d does not report any errors
./mach test-tidy does not report any errors

highfive · 2019-11-30T03:42:59Z

Heads up! This PR modifies the following files:

@KiChjang: components/net/resource_thread.rs, components/net/http_loader.rs, components/net/websocket_loader.rs, components/net/connector.rs, components/net/tests/main.rs and 1 more


        Add ALPN and signature algorithms to OpenSSL config

Darkspirit · 2019-12-02T16:05:13Z

Historical context: Last cipherlist change was in #22243 (comment).
TLS 1.0 + 1.1 have been disabled in Servo and Firefox Nightly in the meantime.
Plain RSA is finally down to 1.07% (No. 61: AES128-SHA) and 0.64% (No. 63: AES256-SHA). Most sloppy end-user websites have upgraded their configurations.

asajeffrey · 2019-12-02T16:18:48Z

@avadacatavra do you have opinions about ciphersuites?

avadacatavra

This is great work--thank you!

jdm · 2019-12-09T20:39:00Z

@bors-servo r=avadacatavra

bors-servo · 2019-12-09T20:39:02Z

📌 Commit b811be7 has been approved by avadacatavra

bors-servo · 2019-12-09T21:02:57Z

⌛ Testing commit b811be7 with merge 7facf5f...


        Auto merge of #24976 - Darkspirit:openssl, r=avadacatavra

Add ALPN and signature algorithms to OpenSSL config * Updated http crate from 0.1.17 [to 0.1.20](https://github.com/hyperium/http/blob/master/CHANGELOG.md#0120-november-26-2019). * Updated hyper from 0.12.33 [to 0.12.35](hyperium/hyper@v0.12.33...v0.12.35). * Updated hyper-openssl from 0.7.0 [to 0.7.1](https://github.com/sfackler/hyper-openssl/blob/master/CHANGELOG.md#v071---2019-03-01). * Updated openssl crate from 0.10.11 [to 0.10.26](https://github.com/sfackler/rust-openssl/blob/master/openssl/CHANGELOG.md#v01026---2019-11-22). * Set ALPN to h2+http/1.1 for https (Enabled HTTP2) and http/1.1 for websockets. * Restricted signature algorithms to the same list across platforms: EdDSA at first, then ECDSA certificates, then TLS 1.3's RSA(-PSS), then classic RSA (PKCS 1.5). Thereby we disabled the [following](https://www.ssllabs.com/ssltest/viewClient.html?name=OpenSSL&version=1.1.1c&key=165) non-web-standard signature algorithms: SHA512/ECDSA, SHA224/ECDSA, SHA1/ECDSA, SHA224/RSA, SHA224/DSA, SHA1/DSA, SHA256/DSA, SHA384/DSA, SHA512/DSA. [SHA1/RSA](https://tools.ietf.org/html/draft-ietf-tls-md5-sha1-deprecate-00) is almost dead and now only used by a few old and broken F5 load balancers: Like TLS 1.0 deprecation, we can again deprecate this some months earlier than other browsers. * Added Chacha20 to TLS 1.2 ciphersuite list and preferred it like Firefox and [Rustls](https://github.com/ctz/rustls/blob/4b13a322c05c9310173513782c5d12c5afedfaf5/rustls/src/suites.rs#L377). Removed legacy and privacy-hostile plain RSA (AES256-SHA, AES128-SHA). Compared to [Mozilla intermediate v5](https://wiki.mozilla.org/Security/Server_Side_TLS#Intermediate_compatibility_.28recommended.29) we keep ECDHE-RSA-AES256-SHA and ECDHE-RSA-AES128-SHA for now, but won't reintroduce deprecated DHE. * Switched server-side to [Mozilla intermediate v5](https://wiki.mozilla.org/Security/Server_Side_TLS#Intermediate_compatibility_.28recommended.29) in components/net/tests/main.rs. (The new `modern` would have been TLSv1.3-only, therefore only worked with OpenSSL 1.1.1 which is unfortunately not yet used on every target.) * Renamed `ssl_connector_builder(certs)` to the more neutral and long-term better fitting `create_tls_config(certs, alpn)` as it was done in #24764. ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors

bors-servo · 2019-12-09T21:35:11Z

💔 Test failed - status-taskcluster

jdm · 2019-12-09T21:36:26Z

@bors-servo retry

#24726

bors-servo · 2019-12-09T21:59:41Z

⌛ Testing commit b811be7 with merge 4bee751...


        Auto merge of #24976 - Darkspirit:openssl, r=avadacatavra

Add ALPN and signature algorithms to OpenSSL config * Updated http crate from 0.1.17 [to 0.1.20](https://github.com/hyperium/http/blob/master/CHANGELOG.md#0120-november-26-2019). * Updated hyper from 0.12.33 [to 0.12.35](hyperium/hyper@v0.12.33...v0.12.35). * Updated hyper-openssl from 0.7.0 [to 0.7.1](https://github.com/sfackler/hyper-openssl/blob/master/CHANGELOG.md#v071---2019-03-01). * Updated openssl crate from 0.10.11 [to 0.10.26](https://github.com/sfackler/rust-openssl/blob/master/openssl/CHANGELOG.md#v01026---2019-11-22). * Set ALPN to h2+http/1.1 for https (Enabled HTTP2) and http/1.1 for websockets. * Restricted signature algorithms to the same list across platforms: EdDSA at first, then ECDSA certificates, then TLS 1.3's RSA(-PSS), then classic RSA (PKCS 1.5). Thereby we disabled the [following](https://www.ssllabs.com/ssltest/viewClient.html?name=OpenSSL&version=1.1.1c&key=165) non-web-standard signature algorithms: SHA512/ECDSA, SHA224/ECDSA, SHA1/ECDSA, SHA224/RSA, SHA224/DSA, SHA1/DSA, SHA256/DSA, SHA384/DSA, SHA512/DSA. [SHA1/RSA](https://tools.ietf.org/html/draft-ietf-tls-md5-sha1-deprecate-00) is almost dead and now only used by a few old and broken F5 load balancers: Like TLS 1.0 deprecation, we can again deprecate this some months earlier than other browsers. * Added Chacha20 to TLS 1.2 ciphersuite list and preferred it like Firefox and [Rustls](https://github.com/ctz/rustls/blob/4b13a322c05c9310173513782c5d12c5afedfaf5/rustls/src/suites.rs#L377). Removed legacy and privacy-hostile plain RSA (AES256-SHA, AES128-SHA). Compared to [Mozilla intermediate v5](https://wiki.mozilla.org/Security/Server_Side_TLS#Intermediate_compatibility_.28recommended.29) we keep ECDHE-RSA-AES256-SHA and ECDHE-RSA-AES128-SHA for now, but won't reintroduce deprecated DHE. * Switched server-side to [Mozilla intermediate v5](https://wiki.mozilla.org/Security/Server_Side_TLS#Intermediate_compatibility_.28recommended.29) in components/net/tests/main.rs. (The new `modern` would have been TLSv1.3-only, therefore only worked with OpenSSL 1.1.1 which is unfortunately not yet used on every target.) * Renamed `ssl_connector_builder(certs)` to the more neutral and long-term better fitting `create_tls_config(certs, alpn)` as it was done in #24764. ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors

bors-servo · 2019-12-09T22:21:50Z

💔 Test failed - status-taskcluster

jdm · 2019-12-09T22:23:11Z

@bors-servo retry

bors-servo · 2019-12-09T22:47:33Z

⌛ Testing commit b811be7 with merge 56f4046...


        Auto merge of #24976 - Darkspirit:openssl, r=avadacatavra

Add ALPN and signature algorithms to OpenSSL config * Updated http crate from 0.1.17 [to 0.1.20](https://github.com/hyperium/http/blob/master/CHANGELOG.md#0120-november-26-2019). * Updated hyper from 0.12.33 [to 0.12.35](hyperium/hyper@v0.12.33...v0.12.35). * Updated hyper-openssl from 0.7.0 [to 0.7.1](https://github.com/sfackler/hyper-openssl/blob/master/CHANGELOG.md#v071---2019-03-01). * Updated openssl crate from 0.10.11 [to 0.10.26](https://github.com/sfackler/rust-openssl/blob/master/openssl/CHANGELOG.md#v01026---2019-11-22). * Set ALPN to h2+http/1.1 for https (Enabled HTTP2) and http/1.1 for websockets. * Restricted signature algorithms to the same list across platforms: EdDSA at first, then ECDSA certificates, then TLS 1.3's RSA(-PSS), then classic RSA (PKCS 1.5). Thereby we disabled the [following](https://www.ssllabs.com/ssltest/viewClient.html?name=OpenSSL&version=1.1.1c&key=165) non-web-standard signature algorithms: SHA512/ECDSA, SHA224/ECDSA, SHA1/ECDSA, SHA224/RSA, SHA224/DSA, SHA1/DSA, SHA256/DSA, SHA384/DSA, SHA512/DSA. [SHA1/RSA](https://tools.ietf.org/html/draft-ietf-tls-md5-sha1-deprecate-00) is almost dead and now only used by a few old and broken F5 load balancers: Like TLS 1.0 deprecation, we can again deprecate this some months earlier than other browsers. * Added Chacha20 to TLS 1.2 ciphersuite list and preferred it like Firefox and [Rustls](https://github.com/ctz/rustls/blob/4b13a322c05c9310173513782c5d12c5afedfaf5/rustls/src/suites.rs#L377). Removed legacy and privacy-hostile plain RSA (AES256-SHA, AES128-SHA). Compared to [Mozilla intermediate v5](https://wiki.mozilla.org/Security/Server_Side_TLS#Intermediate_compatibility_.28recommended.29) we keep ECDHE-RSA-AES256-SHA and ECDHE-RSA-AES128-SHA for now, but won't reintroduce deprecated DHE. * Switched server-side to [Mozilla intermediate v5](https://wiki.mozilla.org/Security/Server_Side_TLS#Intermediate_compatibility_.28recommended.29) in components/net/tests/main.rs. (The new `modern` would have been TLSv1.3-only, therefore only worked with OpenSSL 1.1.1 which is unfortunately not yet used on every target.) * Renamed `ssl_connector_builder(certs)` to the more neutral and long-term better fitting `create_tls_config(certs, alpn)` as it was done in #24764. ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors

bors-servo · 2019-12-09T23:09:34Z

💔 Test failed - status-taskcluster

jdm · 2019-12-09T23:53:22Z

@bors-servo retry


        Auto merge of #24976 - Darkspirit:openssl, r=avadacatavra

Add ALPN and signature algorithms to OpenSSL config * Updated http crate from 0.1.17 [to 0.1.20](https://github.com/hyperium/http/blob/master/CHANGELOG.md#0120-november-26-2019). * Updated hyper from 0.12.33 [to 0.12.35](hyperium/hyper@v0.12.33...v0.12.35). * Updated hyper-openssl from 0.7.0 [to 0.7.1](https://github.com/sfackler/hyper-openssl/blob/master/CHANGELOG.md#v071---2019-03-01). * Updated openssl crate from 0.10.11 [to 0.10.26](https://github.com/sfackler/rust-openssl/blob/master/openssl/CHANGELOG.md#v01026---2019-11-22). * Set ALPN to h2+http/1.1 for https (Enabled HTTP2) and http/1.1 for websockets. * Restricted signature algorithms to the same list across platforms: EdDSA at first, then ECDSA certificates, then TLS 1.3's RSA(-PSS), then classic RSA (PKCS 1.5). Thereby we disabled the [following](https://www.ssllabs.com/ssltest/viewClient.html?name=OpenSSL&version=1.1.1c&key=165) non-web-standard signature algorithms: SHA512/ECDSA, SHA224/ECDSA, SHA1/ECDSA, SHA224/RSA, SHA224/DSA, SHA1/DSA, SHA256/DSA, SHA384/DSA, SHA512/DSA. [SHA1/RSA](https://tools.ietf.org/html/draft-ietf-tls-md5-sha1-deprecate-00) is almost dead and now only used by a few old and broken F5 load balancers: Like TLS 1.0 deprecation, we can again deprecate this some months earlier than other browsers. * Added Chacha20 to TLS 1.2 ciphersuite list and preferred it like Firefox and [Rustls](https://github.com/ctz/rustls/blob/4b13a322c05c9310173513782c5d12c5afedfaf5/rustls/src/suites.rs#L377). Removed legacy and privacy-hostile plain RSA (AES256-SHA, AES128-SHA). Compared to [Mozilla intermediate v5](https://wiki.mozilla.org/Security/Server_Side_TLS#Intermediate_compatibility_.28recommended.29) we keep ECDHE-RSA-AES256-SHA and ECDHE-RSA-AES128-SHA for now, but won't reintroduce deprecated DHE. * Switched server-side to [Mozilla intermediate v5](https://wiki.mozilla.org/Security/Server_Side_TLS#Intermediate_compatibility_.28recommended.29) in components/net/tests/main.rs. (The new `modern` would have been TLSv1.3-only, therefore only worked with OpenSSL 1.1.1 which is unfortunately not yet used on every target.) * Renamed `ssl_connector_builder(certs)` to the more neutral and long-term better fitting `create_tls_config(certs, alpn)` as it was done in #24764. ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors

bors-servo · 2019-12-10T00:21:46Z

⌛ Testing commit b811be7 with merge 1974c87...

bors-servo · 2019-12-10T01:29:51Z

☀️ Test successful - status-taskcluster
Approved by: avadacatavra
Pushing 1974c87 to master...


        Auto merge of #25287 - jdm:google-load, r=pcwalton

Disable H2 ALPN. This was introduced by #24976, and it breaks loading https://google.com. Without any network specialists currently contributing to Servo regularly, I would rather revert the particular change that broke it rather than attempt to continue investigating. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #25286 - [x] These changes do not require tests because no H2 testing, no HTTPS configuration testing.


        Auto merge of #25287 - jdm:google-load, r=pcwalton

Disable H2 ALPN. This was introduced by #24976, and it breaks loading https://google.com. Without any network specialists currently contributing to Servo regularly, I would rather revert the particular change that broke it rather than attempt to continue investigating. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #25286 - [x] These changes do not require tests because no H2 testing, no HTTPS configuration testing.

highfive assigned asajeffrey Nov 30, 2019

highfive added the S-awaiting-review label Nov 30, 2019

Add ALPN and signature algorithms to OpenSSL config

Verified

This commit was signed with a verified signature.

Darkspirit

GPG key ID: 28F9E42748DD95AE Learn about signing commits

Loading status checks…

b811be7

Darkspirit force-pushed the Darkspirit:openssl branch from b823720 to b811be7 Nov 30, 2019

avadacatavra approved these changes Dec 9, 2019

View changes

highfive assigned avadacatavra and unassigned asajeffrey Dec 9, 2019

highfive added S-awaiting-merge and removed S-awaiting-review labels Dec 9, 2019

highfive added S-tests-failed and removed S-awaiting-merge labels Dec 9, 2019

highfive added S-awaiting-merge and removed S-tests-failed labels Dec 9, 2019

highfive added S-tests-failed and removed S-awaiting-merge labels Dec 9, 2019

highfive added S-awaiting-merge and removed S-tests-failed labels Dec 9, 2019

highfive added S-tests-failed and removed S-awaiting-merge labels Dec 9, 2019

highfive added S-awaiting-merge and removed S-tests-failed labels Dec 10, 2019

bors-servo merged commit b811be7 into servo:master Dec 10, 2019
2 checks passed

2 checks passed

Community-TC (pull_request) TaskGroup: success
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Dec 10, 2019

Darkspirit deleted the Darkspirit:openssl branch Dec 10, 2019

This was referenced Dec 13, 2019

Can't load google.com #25286

Closed

Disable H2 ALPN. #25287

Merged

zhuowei mentioned this pull request Jan 26, 2020

"could not set signature algorithms" when running Servo on Android #25619

Closed

Darkspirit mentioned this pull request Feb 7, 2020

Mac build doesn’t run: set_sigalgs_list fails #25708

Closed

servo / servo

Add ALPN and signature algorithms to OpenSSL config #24976

Add ALPN and signature algorithms to OpenSSL config #24976

Darkspirit commented Nov 30, 2019 •

edited

highfive commented Nov 30, 2019

Darkspirit commented Dec 2, 2019 •

edited

asajeffrey commented Dec 2, 2019

avadacatavra left a comment

jdm commented Dec 9, 2019

bors-servo commented Dec 9, 2019

bors-servo commented Dec 9, 2019

bors-servo commented Dec 9, 2019

jdm commented Dec 9, 2019

bors-servo commented Dec 9, 2019

bors-servo commented Dec 9, 2019

jdm commented Dec 9, 2019

bors-servo commented Dec 9, 2019

bors-servo commented Dec 9, 2019

jdm commented Dec 9, 2019

bors-servo commented Dec 10, 2019

bors-servo commented Dec 10, 2019

servo / servo

Join GitHub today

Add ALPN and signature algorithms to OpenSSL config #24976

Add ALPN and signature algorithms to OpenSSL config #24976

Conversation

Darkspirit commented Nov 30, 2019 • edited

highfive commented Nov 30, 2019

Darkspirit commented Dec 2, 2019 • edited

asajeffrey commented Dec 2, 2019

avadacatavra left a comment

jdm commented Dec 9, 2019

bors-servo commented Dec 9, 2019

bors-servo commented Dec 9, 2019

bors-servo commented Dec 9, 2019

jdm commented Dec 9, 2019

bors-servo commented Dec 9, 2019

bors-servo commented Dec 9, 2019

jdm commented Dec 9, 2019

bors-servo commented Dec 9, 2019

bors-servo commented Dec 9, 2019

jdm commented Dec 9, 2019

bors-servo commented Dec 10, 2019

bors-servo commented Dec 10, 2019

Darkspirit commented Nov 30, 2019 •

edited

Darkspirit commented Dec 2, 2019 •

edited