Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement size extremums #25031
Merged
Implement size extremums #25031
Conversation
highfive
commented
Dec 3, 2019
|
Heads up! This PR modifies the following files:
|
highfive
commented
Dec 3, 2019
|
|
components/layout_2020/flow/mod.rs
Outdated
| if let Some(max_block_size) = max_block_size { | ||
| if block_size > max_block_size { | ||
| block_size = max_block_size; | ||
| } | ||
| } |
Comment on lines
621
to
625
This comment has been minimized.
This comment has been minimized.
SimonSapin
Dec 4, 2019
Member
Nit: why not use .min() here? Or even for a function that handles the Option
This comment has been minimized.
This comment has been minimized.
SimonSapin
Dec 4, 2019
Member
Something like:
fn maybe_clamp_at_max(x: Length, max_x: Option<Length>) -> Length {
if let Some(max_x) = max_x {
x.min(max_x)
} else {
x
}
}
|
@bors-servo r=SimonSapin |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nox commentedDec 3, 2019
No description provided.