Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGStreamer plugin should use GLMemory #25048
Merged
+300
−253
Conversation
highfive
commented
Dec 3, 2019
|
|
|
r? @ferjm |
|
As someone who's been fighting with GStreamer for a while, I'm trully amazed by how fast you got all this to work :) |
| CoreError::Failed, | ||
| ["Failed to map output buffer writable"] | ||
| ); | ||
| let memory = unsafe { memory.into_ptr() }; |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
asajeffrey
Dec 5, 2019
Author
Member
I've been focusing on the issue with buffer allocation rather than the space leak atm. I got buffer allocation to work over in my playground plugin, I'm going to port it here, and look to see if this makes the space leak magically go away. asajeffrey/my-gst-plugin@14f6657
|
Thanks! |
|
@bors-servo r+ |
|
|
This was referenced Dec 5, 2019
|
I filed the follow-up issues. |
bors-servo
added a commit
that referenced
this pull request
Dec 5, 2019
GStreamer plugin should use GLMemory <!-- Please describe your changes on the following line: --> Get the gstreamer servosrc plugin to generate frames in GLMemory rather than main memory. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24831 - [x] These changes do not require tests because it's an embedding perf issue <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
asajeffrey
force-pushed the
asajeffrey:gstplugin-glmemory
branch
from
e53bcfe
to
06a10c5
|
Oops, broke the windows build. @bors-servo r=ferjm |
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 5, 2019
GStreamer plugin should use GLMemory <!-- Please describe your changes on the following line: --> Get the gstreamer servosrc plugin to generate frames in GLMemory rather than main memory. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24831 - [x] These changes do not require tests because it's an embedding perf issue <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo retry #25140 |
bors-servo
added a commit
that referenced
this pull request
Dec 5, 2019
GStreamer plugin should use GLMemory <!-- Please describe your changes on the following line: --> Get the gstreamer servosrc plugin to generate frames in GLMemory rather than main memory. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24831 - [x] These changes do not require tests because it's an embedding perf issue <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
highfive
added
S-tests-failed
S-awaiting-review
and removed
S-awaiting-merge
S-tests-failed
labels
|
Lets see if disabling the gstreamer media stack in windows does the job. (If it does, I'll file a follow-up to re-enable it). @bors-servo try=windows |
bors-servo
added a commit
that referenced
this pull request
Dec 5, 2019
GStreamer plugin should use GLMemory <!-- Please describe your changes on the following line: --> Get the gstreamer servosrc plugin to generate frames in GLMemory rather than main memory. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24831 - [x] These changes do not require tests because it's an embedding perf issue <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
asajeffrey
force-pushed the
asajeffrey:gstplugin-glmemory
branch
from
c69360f
to
445ee9b
|
Filed #25189. @bors-servo r=ferjm |
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 6, 2019
GStreamer plugin should use GLMemory <!-- Please describe your changes on the following line: --> Get the gstreamer servosrc plugin to generate frames in GLMemory rather than main memory. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24831 - [x] These changes do not require tests because it's an embedding perf issue <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedDec 3, 2019
Get the gstreamer servosrc plugin to generate frames in GLMemory rather than main memory.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors