Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named form getter #25070

Merged
merged 13 commits into from Dec 16, 2019
+231 −22
Merged

Named form getter #25070

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f73e145
uncomment the named getter from HTMLFormElement.webidl
Nov 27, 2019
2108a85
created sourced names w/o past names map part
Dec 3, 2019
2ee6150
Removed tidy-test errors
jaymodi98 Dec 3, 2019
5e67dbd
Fixed is_listed_element() call and DomRoot child reference
Dec 4, 2019
50fdae7
implemented NamedGetter and other suggestions
amj23897 Dec 5, 2019
7b968a3
NamedGetter completed and fixed issues
amj23897 Dec 6, 2019
16b9efc
updated past_names_map to save time info
amj23897 Dec 6, 2019
159194b
run tidy check and added comments
amj23897 Dec 6, 2019
575f7f5
partially implemented SupportedPropertyNames
amj23897 Dec 7, 2019
a935e00
sorting partially done for Step 6 of SupportedPropertyNames
amj23897 Dec 7, 2019
4682d92
sorting done for Step 6 of SupportedPropertyNames
amj23897 Dec 8, 2019
254bbc3
removed duplicate entries from sourcedNamesVec for step 7 of Supporte…
amj23897 Dec 16, 2019
ef8496c
updated expected test results in log
amj23897 Dec 16, 2019
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Next

uncomment the named getter from HTMLFormElement.webidl

  • Loading branch information
Chintan Gandhi
Chintan Gandhi committed Nov 27, 2019
commit f73e1453caf583839901b1edd4bb6349ee9f5e87
2 components/script/dom/webidls/HTMLFormElement.webidl
View file
Open in desktop
@@ -29,7 +29,7 @@ interface HTMLFormElement : HTMLElement {
[SameObject] readonly attribute HTMLFormControlsCollection elements;
readonly attribute unsigned long length;
getter Element? (unsigned long index);
//getter (RadioNodeList or Element) (DOMString name);
getter (RadioNodeList or Element) (DOMString name);

void submit();
[CEReactions]
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.