Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly send TouchEvents to Servo #25076

Merged
merged 1 commit into from Dec 5, 2019
Merged

Properly send TouchEvents to Servo #25076

merged 1 commit into from Dec 5, 2019

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Dec 4, 2019

This PR is based on #24778. It fixes some UWP platform weirdness (click not registering, and non-expected touch move events).

@Manishearth
Copy link
Member

Manishearth commented Dec 4, 2019

@bors-servo r+

looks like the issue was missing Lost and Exited events

@bors-servo
Copy link
Contributor

bors-servo commented Dec 4, 2019

📌 Commit 171e826 has been approved by Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Dec 4, 2019

Testing commit 171e826 with merge 6a71f2d...

bors-servo added a commit that referenced this pull request Dec 4, 2019
Properly send TouchEvents to Servo

This PR is based on #24778. It fixes some UWP platform weirdness (click not registering, and non-expected touch move events).
@bors-servo
Copy link
Contributor

bors-servo commented Dec 4, 2019

💔 Test failed - status-taskcluster

@jdm
Copy link
Member

jdm commented Dec 5, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Dec 5, 2019

Testing commit 171e826 with merge d64559a...

bors-servo added a commit that referenced this pull request Dec 5, 2019
Properly send TouchEvents to Servo

This PR is based on #24778. It fixes some UWP platform weirdness (click not registering, and non-expected touch move events).
@bors-servo
Copy link
Contributor

bors-servo commented Dec 5, 2019

💔 Test failed - status-taskcluster

@jdm
Copy link
Member

jdm commented Dec 5, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Dec 5, 2019

Testing commit 171e826 with merge 64bcce2...

bors-servo added a commit that referenced this pull request Dec 5, 2019
Properly send TouchEvents to Servo

This PR is based on #24778. It fixes some UWP platform weirdness (click not registering, and non-expected touch move events).
@bors-servo
Copy link
Contributor

bors-servo commented Dec 5, 2019

☀️ Test successful - status-taskcluster
Approved by: Manishearth
Pushing 64bcce2 to master...

@bors-servo bors-servo merged commit 171e826 into servo:master Dec 5, 2019
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.