Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMove WPT sync-from-upstream task to Linux #25117
Conversation
|
@bors-servo r+ |
|
|
|
Because this task is not used by Homu, testing it requires some manual steps:
The first attempt (that didn’t fail) resulted in #25086, which looks similar to #25077 which ran on macOS around the same time. Both PRs change many files, presumably because upstream WPT had many changes since the last sync. To eliminate that source of change, #25115 was made by another run that also disabled syncing from upstream WPT. It touches 54 I’ve started another run with the same configuration to see if the results look different. jdm says on IRC that those 54 are plausibly all due to intermittent test results, though. |
|
Uh, it looks like https://github.com/servo/servo/pull/25115/files may have been overwritten by the actual daily task (since the branch name is based only on the date.) Anyway, 5aa458e in #25122 also changes 53 If some of these are deterministic but due to differences between Linux and macOS, do we risk having macOS CI start failing after a PR like this is merged? @jdm, what do you think? |
|
I don't see how it's any different from the current situation - linux CI has to pass for any new sync PR when the mac machines generate them, this is just the reverse. I think this is fine. |
Move WPT sync-from-upstream task to Linux Before this PR, this task keeps one macOS workers busy for many hours every day.
|
|
SimonSapin commentedDec 5, 2019
Before this PR, this task keeps one macOS workers busy for many hours every day.