Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devtools: save and send cached messages #25161

Merged
merged 1 commit into from Dec 8, 2019
Merged

devtools: save and send cached messages #25161

merged 1 commit into from Dec 8, 2019

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Dec 6, 2019 •
edited

@jdm the only real difference between your original patch and this PR is the removal of the GetCachedMessages messages that are not necessary anymore now that we directly send the message to the devtools.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #13161 (GitHub issue number if applicable)
@paulrouget
devtools: save and send cached messages
Loading status checks…
b3b886e
@highfive
Copy link

highfive commented Dec 6, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/globalscope.rs, components/script/dom/dedicatedworkerglobalscope.rs, components/script/script_thread.rs, components/script/dom/serviceworkerglobalscope.rs, components/script/devtools.rs
  • @KiChjang: components/script/dom/globalscope.rs, components/script/dom/dedicatedworkerglobalscope.rs, components/script/script_thread.rs, components/script/dom/serviceworkerglobalscope.rs, components/script/devtools.rs
@highfive
Copy link

highfive commented Dec 6, 2019

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@paulrouget paulrouget mentioned this pull request Dec 6, 2019
Closed
@jdm
Copy link
Member

jdm commented Dec 8, 2019 •
edited

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 8, 2019

📌 Commit b3b886e has been approved by jdm
@highfive highfive assigned jdm and unassigned nox Dec 8, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Dec 8, 2019

⌛ Testing commit b3b886e with merge 136366b...
bors-servo added a commit that referenced this pull request Dec 8, 2019
@bors-servo
Auto merge of #25161 - paulrouget:cachedMsgs, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
136366b 
devtools: save and send cached messages

@jdm the only real difference between your original patch and this PR is the removal of the `GetCachedMessages` messages that are not necessary anymore now that we directly send the message to the devtools.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #13161 (GitHub issue number if applicable)
@bors-servo
Copy link
Contributor

bors-servo commented Dec 8, 2019

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing 136366b to master...
@bors-servo bors-servo merged commit b3b886e into servo:master Dec 8, 2019
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Report errors to devtools
5 participants
@paulrouget @highfive @jdm @bors-servo @nox
You can’t perform that action at this time.