Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement `text-align` (except `justify`) #25203

Merged
merged 6 commits into from Dec 10, 2019
Merged

Implement `text-align` (except `justify`) #25203

merged 6 commits into from Dec 10, 2019

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Dec 7, 2019

No description provided.

SimonSapin added 2 commits Dec 5, 2019
@SimonSapin
Don’t store computed values of logical properties in style structs
b9adf8b 
They are not used.
@SimonSapin
Use the WritingMode bitflags from Stylo
40ad9a7
@SimonSapin SimonSapin requested a review from nox Dec 7, 2019
@SimonSapin SimonSapin added this to In progress in Layout 2020 via automation Dec 7, 2019
@highfive
Copy link

highfive commented Dec 7, 2019

Heads up! This PR modifies the following files:

  • @emilio: components/style/properties/longhands/inherited_text.mako.rs, components/style/logical_geometry.rs, components/style/values/specified/text.rs, components/style/properties/properties.mako.rs
@highfive
Copy link

highfive commented Dec 7, 2019

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
SimonSapin added 3 commits Dec 7, 2019
@SimonSapin
Containing blocks contains styles rather than just a writing mode
fa1adf2
@SimonSapin
Rename LineBoxes to Lines, since it contains fragments
ce9fc3e
@SimonSapin
Rename content_rect to rect in TextFragment and ImageFragment
6d91d77 
Since they don’t have padding etc.
@SimonSapin SimonSapin force-pushed the text-align branch from 02a8624 to cb6104e Dec 7, 2019
@SimonSapin
Implement `text-align` (except `justify`)
Loading status checks…
9f4b1a0
@SimonSapin SimonSapin force-pushed the text-align branch from cb6104e to 9f4b1a0 Dec 7, 2019
@nox
Copy link
Member

nox commented Dec 9, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 9, 2019

📌 Commit 9f4b1a0 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Dec 9, 2019

⌛ Testing commit 9f4b1a0 with merge 4ce07c6...
bors-servo added a commit that referenced this pull request Dec 9, 2019
@bors-servo
Auto merge of #25203 - servo:text-align, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4ce07c6 
Implement `text-align` (except `justify`)
@bors-servo
Copy link
Contributor

bors-servo commented Dec 9, 2019

💔 Test failed - status-taskcluster
@SimonSapin
Copy link
Member Author

SimonSapin commented Dec 9, 2019

@bors-servo retry #24726
@SimonSapin SimonSapin mentioned this pull request Dec 9, 2019
Merged
@bors-servo
Copy link
Contributor

bors-servo commented Dec 10, 2019

⌛ Testing commit 9f4b1a0 with merge 64c9928...
bors-servo added a commit that referenced this pull request Dec 10, 2019
@bors-servo
Auto merge of #25203 - servo:text-align, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
64c9928 
Implement `text-align` (except `justify`)
@bors-servo
Copy link
Contributor

bors-servo commented Dec 10, 2019

☀️ Test successful - status-taskcluster
Approved by: nox
Pushing 64c9928 to master...
@bors-servo bors-servo merged commit 9f4b1a0 into master Dec 10, 2019
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Layout 2020 automation moved this from In progress to Merged / resolved Dec 10, 2019
@bors-servo bors-servo deleted the text-align branch Dec 10, 2019
@SimonSapin SimonSapin mentioned this pull request Jan 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nox nox

Assignees

@nox nox

Labels
A-layout/2020 A-layout/inline
Projects
Layout 2020
  
Merged / resolved
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@SimonSapin @highfive @nox @bors-servo
You can’t perform that action at this time.