Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWorkarounds for form-submission-0 tests with about:blank onloads #25220
Conversation
|
Opened new PR for upstreamable changes. Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#20686. |
...pt/web-platform-tests/html/semantics/forms/form-submission-0/constructing-form-data-set.html
Outdated
| async_test(t => { | ||
| frame1.onload = t.step_func_done(() => { | ||
| assert_not_equals(frame1.contentDocument.URL.indexOf('_charset_=windows-1252'), -1); | ||
| let tCharset=async_test('_charset_ control sets the expected encoding name.'); |
This comment has been minimized.
This comment has been minimized.
jdm
Dec 9, 2019
Member
Let's keep the existing structure like so:
async_test(t => {
frame1.onload = t.step_func(() => {
if (frame1.contentWindow.location.href == "about:blank") { return; }
assert_not_equals(frame1.contentDocument.URL.indexOf('_charset_=windows-1252'), -1);
tCharset.done();
};
}, '_charset_ control sets the expected encoding name.');
|
Transplanted upstreamable changes to existing PR. Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#20686. |
Otherwise this looks good! |
|
Transplanted upstreamable changes to existing PR. Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#20686. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 10, 2019
Workarounds for form-submission-0 tests with about:blank onloads <!-- Please describe your changes on the following line: --> Following the model of 3b9ab34 these changes replace some naive onload events with equivalents that do nothing if they see an about:blank load event. Two test cases now pass, and one failing test case is now failing for a less ambiguous reason (#25154) --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #25151 and fix #25152. <!-- Either: --> - [X] These changes do not require tests because these are fixes to tests only, not code changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo retry |
|
|
|
Transplanted upstreamable changes to existing PR. Completed upstream sync of web-platform-test changes at web-platform-tests/wpt#20686. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 10, 2019
Workarounds for form-submission-0 tests with about:blank onloads <!-- Please describe your changes on the following line: --> Following the model of 3b9ab34 these changes replace some naive onload events with equivalents that do nothing if they see an about:blank load event. Two test cases now pass, and one failing test case is now failing for a less ambiguous reason (#25154) --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #25151 and fix #25152. <!-- Either: --> - [X] These changes do not require tests because these are fixes to tests only, not code changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pshaughn commentedDec 9, 2019
Following the model of 3b9ab34 these changes replace some naive onload events with equivalents that do nothing if they see an about:blank load event. Two test cases now pass, and one failing test case is now failing for a less ambiguous reason (#25154)
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors