Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Took out the special mouseover cancel case #25240

Merged
merged 2 commits into from Dec 11, 2019
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Prev

Add `FIXME` to the new comment asking wether code below it is right

  • Loading branch information
SimonSapin committed Dec 11, 2019
commit e501eaaa5b43961883ef8ef1427790f6c9bb1804
@@ -231,7 +231,7 @@ impl CompiledEventListener {
let should_cancel = value.is_boolean() && value.to_boolean() == false;

if should_cancel {
// spec says to set the cancelled flag directly
// FIXME: spec says to set the cancelled flag directly
// here, not just to prevent default;
// can that ever make a difference?
event.PreventDefault();
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.