Mechanism to allow Servo to prompt the user #25242

paulrouget · 2019-12-11T08:55:47Z

This blocks the embedder thread (compositor thread). Not ideal. I don't think it's too much work to only block script, I'll do that in a follow up bug.

Fix #23376

@Manishearth we have a few new APIs. Hopefully this will cover your needs. A thing I haven't implemented yet is a way to ask the user to pick from a list. Let me know if it's something you'll need.

highfive · 2019-12-11T08:55:53Z

Heads up! This PR modifies the following files:

@asajeffrey: components/script/dom/window.rs, components/script/dom/webidls/Window.webidl
@KiChjang: components/script/dom/window.rs, components/script/dom/webidls/Window.webidl

highfive · 2019-12-11T08:55:55Z

Warning

These commits modify unsafe code. Please review it carefully!
These commits modify script code, but no tests are modified. Please consider adding a test!

asajeffrey

Small nit, otherwise the changes to the embedder LGTM. I'll leave the HL code up to @Manishearth.

asajeffrey · 2019-12-11T17:02:12Z

components/embedder_traits/lib.rs

+
+#[derive(Deserialize, Serialize, PartialEq)]
+pub enum PromptOrigin {
+    Untrusted,


A comment or spec link for what is meant by (un)trusted?

asajeffrey · 2019-12-11T17:02:12Z

components/embedder_traits/lib.rs

+#[derive(Deserialize, Serialize)]
+pub enum PromptDefinition {
+    Alert(String, IpcSender<()>),
+    OkCancel(String, IpcSender<bool>),


An enum rather than a bool? Or at least a comment saying that true is Ok?

paulrouget · 2019-12-12T12:50:56Z

Added comments and enum instead of bool.

paulrouget · 2019-12-13T10:16:54Z

r? @Manishearth

jdm · 2019-12-17T14:52:58Z

@Manishearth Review ping.

Manishearth

looks good to me!

(sorry for the delay, was waiting on some XR permissions discussions to happen)

bors-servo · 2020-01-15T15:49:36Z

☔ The latest upstream changes (presumably #25525) made this pull request unmergeable. Please resolve the merge conflicts.

jdm · 2020-01-15T16:16:29Z

Shoot, we should have merged this :(

pshaughn · 2020-01-15T16:35:23Z

It looks like this is adding more tinyfiledialogs calls; if any of them can come from strings written by page authors, send them through the escaper.

paulrouget · 2020-02-04T08:13:55Z

I’ll get back to that once I figured #25683

paulrouget · 2020-02-06T11:58:05Z

I’ve put together the 3 prompt/devtools related PR (this one + #25266 + #25307).

paulrouget · 2020-02-07T04:08:53Z

@bors-servo r=manishearth

bors-servo · 2020-02-07T04:08:54Z

📌 Commit cf09d72 has been approved by manishearth

bors-servo · 2020-02-07T04:08:59Z

⌛ Testing commit cf09d72 with merge ada40b2...


        Auto merge of #25242 - paulrouget:prompt, r=manishearth

@Manishearth

Mechanism to allow Servo to prompt the user This blocks the embedder thread (compositor thread). Not ideal. I don't think it's too much work to only block script, I'll do that in a follow up bug. Fix #23376 @Manishearth we have a few new APIs. Hopefully this will cover your needs. A thing I haven't implemented yet is a way to ask the user to pick from a list. Let me know if it's something you'll need.


        Embedder Prompt API


        Prompt user before accepting incoming devtools connection


        enable devtools for hololens

paulrouget · 2020-02-10T05:58:23Z

@bors-servo try=linux,windows

bors-servo · 2020-02-10T05:58:24Z

🙁 There is no try chooser linux,windows for this repo, try one of: linux, mac, windows, wpt, wpt-2020, wpt-mac, wpt-android, android, magicleap, arm

paulrouget · 2020-02-10T06:06:19Z

Didn’t try to build locally:

@bors-servo try=magicleap

bors-servo · 2020-02-10T06:06:24Z

⌛ Trying commit d838200 with merge 9271532...


        Auto merge of #25242 - paulrouget:prompt, r=<try>

@Manishearth

Mechanism to allow Servo to prompt the user This blocks the embedder thread (compositor thread). Not ideal. I don't think it's too much work to only block script, I'll do that in a follow up bug. Fix #23376 @Manishearth we have a few new APIs. Hopefully this will cover your needs. A thing I haven't implemented yet is a way to ask the user to pick from a list. Let me know if it's something you'll need.

bors-servo · 2020-02-10T06:07:12Z

☀️ Test successful - status-taskcluster
State: approved= try=True

paulrouget · 2020-02-10T06:59:15Z

@bors-servo r=manishearth

bors-servo · 2020-02-10T06:59:16Z

📌 Commit d838200 has been approved by manishearth

bors-servo · 2020-02-10T06:59:21Z

⌛ Testing commit d838200 with merge b2f40eb...


        Auto merge of #25242 - paulrouget:prompt, r=manishearth

@Manishearth

Mechanism to allow Servo to prompt the user This blocks the embedder thread (compositor thread). Not ideal. I don't think it's too much work to only block script, I'll do that in a follow up bug. Fix #23376 @Manishearth we have a few new APIs. Hopefully this will cover your needs. A thing I haven't implemented yet is a way to ask the user to pick from a list. Let me know if it's something you'll need.

bors-servo · 2020-02-10T07:32:26Z

💔 Test failed - status-taskcluster

paulrouget · 2020-02-10T08:33:47Z

@bors-servo retry

bors-servo · 2020-02-10T08:33:53Z

⌛ Testing commit d838200 with merge 5044379...


        Auto merge of #25242 - paulrouget:prompt, r=manishearth

@Manishearth

Mechanism to allow Servo to prompt the user This blocks the embedder thread (compositor thread). Not ideal. I don't think it's too much work to only block script, I'll do that in a follow up bug. Fix #23376 @Manishearth we have a few new APIs. Hopefully this will cover your needs. A thing I haven't implemented yet is a way to ask the user to pick from a list. Let me know if it's something you'll need.

bors-servo · 2020-02-10T08:53:50Z

☀️ Test successful - status-taskcluster
Approved by: manishearth
Pushing 5044379 to master...

highfive assigned asajeffrey Dec 11, 2019

highfive added the S-awaiting-review label Dec 11, 2019

jdm added the S-fails-tidy label Dec 11, 2019

asajeffrey reviewed Dec 11, 2019

View changes

paulrouget force-pushed the paulrouget:prompt branch from c7ca82a to b33b855 Dec 12, 2019

paulrouget mentioned this pull request Dec 12, 2019

WIP: Devtools prompt #25266

Closed

paulrouget force-pushed the paulrouget:prompt branch from b33b855 to e24059b Dec 13, 2019

highfive assigned Manishearth and unassigned asajeffrey Dec 13, 2019

Manishearth approved these changes Dec 31, 2019

View changes

highfive added the S-needs-rebase label Jan 15, 2020

paulrouget force-pushed the paulrouget:prompt branch from e24059b to 79d5ffd Feb 6, 2020

Manishearth approved these changes Feb 6, 2020

View changes

highfive added S-awaiting-merge and removed S-awaiting-review S-needs-rebase labels Feb 7, 2020

paulrouget added 3 commits Dec 9, 2019

Embedder Prompt API

51f15a0

Prompt user before accepting incoming devtools connection

49376e3

enable devtools for hololens

Loading status checks…

d838200

paulrouget force-pushed the paulrouget:prompt branch from 3244d0d to d838200 Feb 10, 2020

highfive added S-awaiting-review and removed S-tests-failed labels Feb 10, 2020

highfive added S-awaiting-merge and removed S-awaiting-review labels Feb 10, 2020

highfive added S-tests-failed and removed S-awaiting-merge labels Feb 10, 2020

highfive added S-awaiting-merge and removed S-tests-failed labels Feb 10, 2020

bors-servo merged commit d838200 into servo:master Feb 10, 2020
2 checks passed

2 checks passed

Community-TC (pull_request) TaskGroup: success
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Feb 10, 2020

bors-servo mentioned this pull request Feb 10, 2020

Enable devtools by default on hololens. #25307

Closed

servo / servo

Mechanism to allow Servo to prompt the user #25242

Mechanism to allow Servo to prompt the user #25242

paulrouget commented Dec 11, 2019

highfive commented Dec 11, 2019

highfive commented Dec 11, 2019

asajeffrey left a comment

This comment has been minimized.

This comment has been minimized.

paulrouget commented Dec 12, 2019

paulrouget commented Dec 13, 2019

jdm commented Dec 17, 2019

Manishearth left a comment

bors-servo commented Jan 15, 2020

jdm commented Jan 15, 2020

pshaughn commented Jan 15, 2020

paulrouget commented Feb 4, 2020

paulrouget commented Feb 6, 2020

paulrouget commented Feb 7, 2020

bors-servo commented Feb 7, 2020

bors-servo commented Feb 7, 2020

paulrouget commented Feb 10, 2020

bors-servo commented Feb 10, 2020

paulrouget commented Feb 10, 2020

bors-servo commented Feb 10, 2020

bors-servo commented Feb 10, 2020

paulrouget commented Feb 10, 2020

bors-servo commented Feb 10, 2020

bors-servo commented Feb 10, 2020

bors-servo commented Feb 10, 2020

paulrouget commented Feb 10, 2020

bors-servo commented Feb 10, 2020

bors-servo commented Feb 10, 2020

servo / servo

Join GitHub today

Mechanism to allow Servo to prompt the user #25242

Mechanism to allow Servo to prompt the user #25242

Conversation

paulrouget commented Dec 11, 2019

highfive commented Dec 11, 2019

highfive commented Dec 11, 2019

asajeffrey left a comment

This comment has been minimized.

asajeffrey Dec 11, 2019

This comment has been minimized.

asajeffrey Dec 11, 2019

paulrouget commented Dec 12, 2019

paulrouget commented Dec 13, 2019

jdm commented Dec 17, 2019

Manishearth left a comment

bors-servo commented Jan 15, 2020

jdm commented Jan 15, 2020

pshaughn commented Jan 15, 2020

paulrouget commented Feb 4, 2020

paulrouget commented Feb 6, 2020

paulrouget commented Feb 7, 2020

bors-servo commented Feb 7, 2020

bors-servo commented Feb 7, 2020

paulrouget commented Feb 10, 2020

bors-servo commented Feb 10, 2020

paulrouget commented Feb 10, 2020

bors-servo commented Feb 10, 2020

bors-servo commented Feb 10, 2020

paulrouget commented Feb 10, 2020

bors-servo commented Feb 10, 2020

bors-servo commented Feb 10, 2020

bors-servo commented Feb 10, 2020

paulrouget commented Feb 10, 2020

bors-servo commented Feb 10, 2020

bors-servo commented Feb 10, 2020