Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various webxr WPT fixes #25259

Merged
merged 11 commits into from Dec 13, 2019

Fix xrDevice_requestSession_no_mode to test for a throw, not a rejection

  • Loading branch information
Manishearth committed Dec 12, 2019
commit 326902220c8e19f80bcc1ef79fda93eb45e8f265
"testharness"
],
"webxr/xrDevice_requestSession_no_mode.https.html": [
"de77b38c868e3b5dad88b8eface770b16b5f16c1",
"5ef249c58186131f8e467da48cfafebe65df9adf",
"testharness"
],
"webxr/xrDevice_requestSession_non_immersive_no_gesture.https.html": [

This file was deleted.

@@ -11,11 +11,10 @@
return navigator.xr.test.simulateDeviceConnection(VALID_NON_IMMERSIVE_DEVICE)
.then( (controller) => new Promise((resolve) => {
navigator.xr.test.simulateUserActivation( () => {
resolve(promise_rejects(
t,
new TypeError(),
navigator.xr.requestSession()
))
t.step_func(() => {
assert_throws(new TypeError(), () => navigator.xr.requestSession())
})
resolve()
});
}));
});
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.