Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWIP: Devtools prompt #25266
Closed
WIP: Devtools prompt #25266
Conversation
highfive
commented
Dec 12, 2019
|
Heads up! This PR modifies the following files:
|
highfive
commented
Dec 12, 2019
|
|
|
The important changes look good, should this wait till #25242 lands? |
| @@ -119,7 +119,7 @@ Servo::Servo(hstring url, hstring args, GLsizei width, GLsizei height, | |||
|
|
|||
| // Example Call when *pfilters[] is used: | |||
| // o.vslogger_mod_list = pfilters; // servo log modules | |||
| // o.vslogger_mod_size = sizeof(pfilters) / sizeof(pfilters[0]) -1; // | |||
| // o.vslogger_mod_size = sizeof(pfilters) / sizeof(pfilters[0]); // | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
paulrouget
Dec 13, 2019
Author
Contributor
I realized that it was wrong. The last filter was never used.
| </Capabilities> | ||
| </Package> | ||
| </Package> |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
|
Landed as part of #25242 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
paulrouget commentedDec 12, 2019
Depends on #25242
Ask the user before accepting devtools incoming connection.