Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue warning to devtools when module scripts in use. #25267

Merged
merged 1 commit into from Dec 13, 2019
Merged

Issue warning to devtools when module scripts in use. #25267

merged 1 commit into from Dec 13, 2019

Conversation

@jdm
Copy link
Member

jdm commented Dec 12, 2019

This makes it easier to identify why content isn't working in environments which don't have access to the RUST_LOG output.
@highfive
Copy link

highfive commented Dec 12, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/globalscope.rs, components/script/dom/htmlscriptelement.rs
  • @KiChjang: components/script/dom/globalscope.rs, components/script/dom/htmlscriptelement.rs
@highfive
Copy link

highfive commented Dec 12, 2019

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@jdm jdm added this to In progress in Microsoft app store Dec 12, 2019
@Manishearth
Copy link
Member

Manishearth commented Dec 12, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 12, 2019

📌 Commit 77e4f23 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Dec 12, 2019

⌛ Testing commit 77e4f23 with merge ebc1cca...
bors-servo added a commit that referenced this pull request Dec 12, 2019
@bors-servo
Auto merge of #25267 - jdm:devtools-module-script-warning, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ebc1cca 
Issue warning to devtools when module scripts in use.

This makes it easier to identify why content isn't working in environments which don't have access to the RUST_LOG output.
@bors-servo
Copy link
Contributor

bors-servo commented Dec 12, 2019

💔 Test failed - status-taskcluster
@jdm
Issue warning to devtools when module scripts in use.
Loading status checks…
55eb34b
@jdm jdm force-pushed the jdm:devtools-module-script-warning branch from 77e4f23 to 55eb34b Dec 12, 2019
@jdm
Copy link
Member Author

jdm commented Dec 12, 2019

@bors-servo r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Dec 12, 2019

📌 Commit 55eb34b has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Dec 12, 2019

⌛ Testing commit 55eb34b with merge 3665257...
bors-servo added a commit that referenced this pull request Dec 12, 2019
@bors-servo
Auto merge of #25267 - jdm:devtools-module-script-warning, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3665257 
Issue warning to devtools when module scripts in use.

This makes it easier to identify why content isn't working in environments which don't have access to the RUST_LOG output.
@bors-servo
Copy link
Contributor

bors-servo commented Dec 12, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented Dec 12, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Dec 12, 2019

⌛ Testing commit 55eb34b with merge ae5d79b...
bors-servo added a commit that referenced this pull request Dec 12, 2019
@bors-servo
Auto merge of #25267 - jdm:devtools-module-script-warning, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ae5d79b 
Issue warning to devtools when module scripts in use.

This makes it easier to identify why content isn't working in environments which don't have access to the RUST_LOG output.
@bors-servo
Copy link
Contributor

bors-servo commented Dec 12, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented Dec 12, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2019

⌛ Testing commit 55eb34b with merge 1a2b5c2...
bors-servo added a commit that referenced this pull request Dec 13, 2019
@bors-servo
Auto merge of #25267 - jdm:devtools-module-script-warning, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1a2b5c2 
Issue warning to devtools when module scripts in use.

This makes it easier to identify why content isn't working in environments which don't have access to the RUST_LOG output.
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented Dec 13, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2019

⌛ Testing commit 55eb34b with merge 35c7add...
bors-servo added a commit that referenced this pull request Dec 13, 2019
@bors-servo
Auto merge of #25267 - jdm:devtools-module-script-warning, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
35c7add 
Issue warning to devtools when module scripts in use.

This makes it easier to identify why content isn't working in environments which don't have access to the RUST_LOG output.
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member Author

jdm commented Dec 13, 2019

@bors-servo retry
bors-servo added a commit that referenced this pull request Dec 13, 2019
@bors-servo
Auto merge of #25267 - jdm:devtools-module-script-warning, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
068a210 
Issue warning to devtools when module scripts in use.

This makes it easier to identify why content isn't working in environments which don't have access to the RUST_LOG output.
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2019

⌛ Testing commit 55eb34b with merge 068a210...
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2019

☀️ Test successful - status-taskcluster
Approved by: Manishearth
Pushing 068a210 to master...
@bors-servo bors-servo merged commit 55eb34b into servo:master Dec 13, 2019
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@jdm jdm moved this from In progress to Done in Microsoft app store Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
None yet
Projects
Microsoft app store
  
Done
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@jdm @highfive @Manishearth @bors-servo
You can’t perform that action at this time.