Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRun GL commands on the GStreamer GL thread #25271
Merged
+45
−6
Conversation
highfive
commented
Dec 12, 2019
|
|
|
r? @Manishearth |
| @@ -55,8 +55,10 @@ use gstreamer_base::BaseSrcExt; | |||
| use gstreamer_gl::GLContext; | |||
| use gstreamer_gl::GLContextExt; | |||
| use gstreamer_gl::GLContextExtManual; | |||
| use gstreamer_gl_sys::gst_gl_context_thread_add; | |||
This comment has been minimized.
This comment has been minimized.
Manishearth
Dec 12, 2019
Member
is there no exported rust function for this? should there be one? we should file an upstream bug
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r=Manishearth |
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 12, 2019
Run GL commands on the GStreamer GL thread <!-- Please describe your changes on the following line: --> GStreamer has thread affinity for GL contexts. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #25268 - [x] These changes do not require tests because <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Dec 13, 2019
Run GL commands on the GStreamer GL thread <!-- Please describe your changes on the following line: --> GStreamer has thread affinity for GL contexts. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #25268 - [x] These changes do not require tests because <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Dec 13, 2019
Run GL commands on the GStreamer GL thread <!-- Please describe your changes on the following line: --> GStreamer has thread affinity for GL contexts. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #25268 - [x] These changes do not require tests because <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Dec 13, 2019
Run GL commands on the GStreamer GL thread <!-- Please describe your changes on the following line: --> GStreamer has thread affinity for GL contexts. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #25268 - [x] These changes do not require tests because <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedDec 12, 2019
GStreamer has thread affinity for GL contexts.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors