Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout `position: fixed` in the initial containing block #25273

Merged
merged 13 commits into from Dec 13, 2019
Merged

Layout `position: fixed` in the initial containing block #25273

merged 13 commits into from Dec 13, 2019

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Dec 12, 2019

No description provided.

SimonSapin added 6 commits Dec 12, 2019
@SimonSapin
Introduce PositioningContext
b43a3de
@SimonSapin
Make adjust_static_positions a method of PositioningContext
9edda95
@SimonSapin
Upgrade rayon_croissant to 0.2.0
1c8d14a
@SimonSapin
Give `PositioningContext` more responsibilities
c44ee51 
Iits details are now private to the module.

It has a couple methods that take closures to make sure that "before" and "after" steps are done together:

* In an absolutely positioned box, take care of nested abspos (establish a new containing block, etc.)
* For a box that *might* be `position: relative`, optionally take care of the same.
@SimonSapin
Layout `position: fixed` in the initial containing block
5ebddf1
@SimonSapin
Fix a width v.s. height confusion bug in abspos layout
Loading status checks…
53a8a60
@SimonSapin
Copy link
Member Author

SimonSapin commented Dec 12, 2019

r? @nox
@highfive highfive assigned nox and unassigned jdm Dec 12, 2019
@SimonSapin
Parse `background: <color>`
Loading status checks…
6fce97c
@SimonSapin SimonSapin added this to In progress in Layout 2020 via automation Dec 13, 2019
@nox
nox approved these changes Dec 13, 2019
View changes
Copy link
Member

nox left a comment

Just a couple of useless remarks and some nits.
components/layout_2020/positioned.rs Outdated Show resolved Hide resolved
components/layout_2020/flow/construct.rs Show resolved Hide resolved
components/layout_2020/flow/mod.rs Outdated Show resolved Hide resolved
components/layout_2020/positioned.rs Show resolved Hide resolved
SimonSapin added 5 commits Dec 13, 2019
@SimonSapin
Replace the closure in `layout_in_flow_non_replaced_block_level` with…
c0962aa 
… an enum
@SimonSapin
Regroup branches specific to `SameFormattingContextBlock`
672d971
@SimonSapin
Move call to `for_maybe_position_relative` out of `layout_in_flow_non…
04b701b 
…_replaced_block_level`
@SimonSapin
Rename `CollectedAbsolutelyPositionedBox` to `HoistedAbsolutelyPositi…
b218957 
…onedBox`
@SimonSapin
Make `for_maybe_position_relative` take care of relative adjustment.
Loading status checks…
58b7005
@nox
nox approved these changes Dec 13, 2019
View changes
Copy link
Member

nox left a comment

Nice!
components/layout_2020/flow/mod.rs Outdated Show resolved Hide resolved
components/layout_2020/flow/mod.rs Outdated Show resolved Hide resolved
@SimonSapin SimonSapin mentioned this pull request Dec 13, 2019
Closed
@SimonSapin
Rename `BlockLevelKind` to `NonReplacedContents`
Loading status checks…
6f3c5ce
@nox
Copy link
Member

nox commented Dec 13, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2019

📌 Commit 6f3c5ce has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2019

⌛ Testing commit 6f3c5ce with merge 973d6ff...
bors-servo added a commit that referenced this pull request Dec 13, 2019
@bors-servo
Auto merge of #25273 - servo:fixedpos, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
973d6ff 
 Layout `position: fixed` in the initial containing block
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Dec 13, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2019

⌛ Testing commit 6f3c5ce with merge 762e67f...
bors-servo added a commit that referenced this pull request Dec 13, 2019
@bors-servo
Auto merge of #25273 - servo:fixedpos, r=nox
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
762e67f 
 Layout `position: fixed` in the initial containing block
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2019

☀️ Test successful - status-taskcluster
Approved by: nox
Pushing 762e67f to master...
@bors-servo bors-servo merged commit 6f3c5ce into master Dec 13, 2019
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Layout 2020 automation moved this from In progress to Merged / resolved Dec 13, 2019
@bors-servo bors-servo deleted the fixedpos branch Dec 13, 2019
@bors-servo bors-servo mentioned this pull request Dec 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nox nox

Assignees

@nox nox

Labels
None yet
Projects
Layout 2020
  
Merged / resolved
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@SimonSapin @nox @bors-servo @jdm @highfive
You can’t perform that action at this time.