Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout `position: fixed` in the initial containing block #25273

Merged
merged 13 commits into from Dec 13, 2019
Merged

Layout `position: fixed` in the initial containing block #25273

merged 13 commits into from Dec 13, 2019
+549 −401

Commits on Dec 12, 2019

  1. Introduce PositioningContext

    @SimonSapin
    SimonSapin committed Dec 12, 2019
    b43a3de

  2. Make adjust_static_positions a method of PositioningContext

    @SimonSapin
    SimonSapin committed Dec 12, 2019
    9edda95

  3. Upgrade rayon_croissant to 0.2.0

    @SimonSapin
    SimonSapin committed Dec 12, 2019
    1c8d14a

  4. Give `PositioningContext` more responsibilities 

    Iits details are now private to the module.

It has a couple methods that take closures to make sure that "before" and "after" steps are done together:

* In an absolutely positioned box, take care of nested abspos (establish a new containing block, etc.)
* For a box that *might* be `position: relative`, optionally take care of the same.
    @SimonSapin
    SimonSapin committed Dec 12, 2019
    c44ee51

  5. Layout `position: fixed` in the initial containing block

    @SimonSapin
    SimonSapin committed Dec 12, 2019
    5ebddf1

  6. Fix a width v.s. height confusion bug in abspos layout

    @SimonSapin
    SimonSapin committed Dec 12, 2019
    Loading status checks…
    53a8a60

  7. Parse `background: <color>`

    @SimonSapin
    SimonSapin committed Dec 12, 2019
    Loading status checks…
    6fce97c

Commits on Dec 13, 2019

  1. Replace the closure in `layout_in_flow_non_replaced_block_level` with… 

    … an enum
    @SimonSapin
    SimonSapin committed Dec 13, 2019
    c0962aa

  2. Regroup branches specific to `SameFormattingContextBlock`

    @SimonSapin
    SimonSapin committed Dec 13, 2019
    672d971

  3. Move call to `for_maybe_position_relative` out of `layout_in_flow_non… 

    …_replaced_block_level`
    @SimonSapin
    SimonSapin committed Dec 13, 2019
    04b701b

  4. Rename `CollectedAbsolutelyPositionedBox` to `HoistedAbsolutelyPositi… 

    …onedBox`
    @SimonSapin
    SimonSapin committed Dec 13, 2019
    b218957

  5. Make `for_maybe_position_relative` take care of relative adjustment.

    @SimonSapin
    SimonSapin committed Dec 13, 2019
    Loading status checks…
    58b7005

  6. Rename `BlockLevelKind` to `NonReplacedContents`

    @SimonSapin
    SimonSapin committed Dec 13, 2019
    Loading status checks…
    6f3c5ce
You can’t perform that action at this time.