Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout `position: fixed` in the initial containing block #25273

Merged
merged 13 commits into from Dec 13, 2019
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Fix a width v.s. height confusion bug in abspos layout

  • Loading branch information
SimonSapin committed Dec 12, 2019
commit 53a8a609d22570c969b9dd6a1e760b6ee72c7381
@@ -447,7 +447,7 @@ impl<'box_tree> CollectedAbsolutelyPositionedBox<'box_tree> {

let inline_start = match inline_axis.anchor {
Anchor::Start(start) => start + pb.inline_start + margin.inline_start,
Anchor::End(end) => cbbs - end - pb.inline_end - margin.inline_end - size.inline,
Anchor::End(end) => cbis - end - pb.inline_end - margin.inline_end - size.inline,
This conversation was marked as resolved by nox

This comment has been minimized.

Copy link
@nox

nox Dec 13, 2019

Member

EWWWWWWWW

};
let block_start = match block_axis.anchor {
Anchor::Start(start) => start + pb.block_start + margin.block_start,
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.