Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only compile applicable event handler content attributes #25274

Closed
wants to merge 6 commits into from
+256 −181
Closed

Only compile applicable event handler content attributes #25274

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
863069d
Move global_event_handlers_list to a metamacro
Manishearth Dec 12, 2019
fab4e7f
Move window_event_handlers_list to a metamacro
Manishearth Dec 13, 2019
56f80c9
Export static arrays for event handler lists
Manishearth Dec 13, 2019
5975eba
Export lazy statics
Manishearth Dec 13, 2019
b68057d
Use new shiny statics for element/body mutation
Manishearth Dec 13, 2019
dfd9862
Add event handler attribute logic for frameset elements too
Manishearth Dec 13, 2019
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Next

Move global_event_handlers_list to a metamacro

  • Loading branch information
@Manishearth
Manishearth committed Dec 13, 2019
commit 863069d493433b07ed12cc14cb110788230a7d94
162 components/script/dom/macros.rs
View file
Open in desktop
@@ -413,76 +413,100 @@ macro_rules! window_owned_beforeunload_event_handler(
// https://html.spec.whatwg.org/multipage/#globaleventhandlers
// see webidls/EventHandler.webidl
// As more methods get added, just update them here.
macro_rules! global_event_handlers(
() => (
event_handler!(blur, GetOnblur, SetOnblur);
event_handler!(focus, GetOnfocus, SetOnfocus);
event_handler!(load, GetOnload, SetOnload);
event_handler!(resize, GetOnresize, SetOnresize);
event_handler!(scroll, GetOnscroll, SetOnscroll);
global_event_handlers!(NoOnload);
macro_rules! global_event_handlers_list{
($macro:ident) => {
global_event_handlers_list!($macro @
(blur, GetOnblur, SetOnblur, event_handler;
focus, GetOnfocus, SetOnfocus, event_handler;
load, GetOnload, SetOnload, event_handler;
resize, GetOnresize, SetOnresize, event_handler;
scroll, GetOnscroll, SetOnscroll, event_handler;)
);
};
($macro:ident, NoOnload) => {
global_event_handlers_list!($macro @ ());
};
($macro:ident @ ($($tt:tt)*)) => {
$macro![
abort, GetOnabort, SetOnabort, event_handler;
cancel, GetOncancel, SetOncancel, event_handler;
canplay, GetOncanplay, SetOncanplay, event_handler;
canplaythrough, GetOncanplaythrough, SetOncanplaythrough, event_handler;
change, GetOnchange, SetOnchange, event_handler;
click, GetOnclick, SetOnclick, event_handler;
close, GetOnclose, SetOnclose, event_handler;
contextmenu, GetOncontextmenu, SetOncontextmenu, event_handler;
cuechange, GetOncuechange, SetOncuechange, event_handler;
dblclick, GetOndblclick, SetOndblclick, event_handler;
drag, GetOndrag, SetOndrag, event_handler;
dragend, GetOndragend, SetOndragend, event_handler;
dragenter, GetOndragenter, SetOndragenter, event_handler;
dragexit, GetOndragexit, SetOndragexit, event_handler;
dragleave, GetOndragleave, SetOndragleave, event_handler;
dragover, GetOndragover, SetOndragover, event_handler;
dragstart, GetOndragstart, SetOndragstart, event_handler;
drop, GetOndrop, SetOndrop, event_handler;
durationchange, GetOndurationchange, SetOndurationchange, event_handler;
emptied, GetOnemptied, SetOnemptied, event_handler;
ended, GetOnended, SetOnended, event_handler;
error, GetOnerror, SetOnerror, error_event_handler;
formdata, GetOnformdata, SetOnformdata, event_handler;
input, GetOninput, SetOninput, event_handler;
invalid, GetOninvalid, SetOninvalid, event_handler;
keydown, GetOnkeydown, SetOnkeydown, event_handler;
keypress, GetOnkeypress, SetOnkeypress, event_handler;
keyup, GetOnkeyup, SetOnkeyup, event_handler;
loadeddata, GetOnloadeddata, SetOnloadeddata, event_handler;
loadedmetadata, GetOnloadedmetadata, SetOnloadedmetadata, event_handler;
loadstart, GetOnloadstart, SetOnloadstart, event_handler;
mousedown, GetOnmousedown, SetOnmousedown, event_handler;
mouseenter, GetOnmouseenter, SetOnmouseenter, event_handler;
mouseleave, GetOnmouseleave, SetOnmouseleave, event_handler;
mousemove, GetOnmousemove, SetOnmousemove, event_handler;
mouseout, GetOnmouseout, SetOnmouseout, event_handler;
mouseover, GetOnmouseover, SetOnmouseover, event_handler;
mouseup, GetOnmouseup, SetOnmouseup, event_handler;
wheel, GetOnwheel, SetOnwheel, event_handler;
pause, GetOnpause, SetOnpause, event_handler;
play, GetOnplay, SetOnplay, event_handler;
playing, GetOnplaying, SetOnplaying, event_handler;
progress, GetOnprogress, SetOnprogress, event_handler;
ratechange, GetOnratechange, SetOnratechange, event_handler;
reset, GetOnreset, SetOnreset, event_handler;
seeked, GetOnseeked, SetOnseeked, event_handler;
seeking, GetOnseeking, SetOnseeking, event_handler;
select, GetOnselect, SetOnselect, event_handler;
show, GetOnshow, SetOnshow, event_handler;
stalled, GetOnstalled, SetOnstalled, event_handler;
submit, GetOnsubmit, SetOnsubmit, event_handler;
suspend, GetOnsuspend, SetOnsuspend, event_handler;
timeupdate, GetOntimeupdate, SetOntimeupdate, event_handler;
toggle, GetOntoggle, SetOntoggle, event_handler;
transitionend, GetOntransitionend, SetOntransitionend, event_handler;
volumechange, GetOnvolumechange, SetOnvolumechange, event_handler;
waiting, GetOnwaiting, SetOnwaiting, event_handler;
$($tt)*
];
}
}

macro_rules! run_event_handler {
($($name:ident, $get:ident, $set:ident, $event_macro:ident;)+) => {
$($event_macro!($name, $get, $set);)+
};
}
// https://html.spec.whatwg.org/multipage/#globaleventhandlers
// see webidls/EventHandler.webidl
// As more methods get added, just update them here.
macro_rules! global_event_handlers{
() => {
global_event_handlers_list!(run_event_handler);
};
(NoOnload) => {
global_event_handlers_list!(run_event_handler, NoOnload);
};
}

);
(NoOnload) => (
event_handler!(abort, GetOnabort, SetOnabort);
event_handler!(cancel, GetOncancel, SetOncancel);
event_handler!(canplay, GetOncanplay, SetOncanplay);
event_handler!(canplaythrough, GetOncanplaythrough, SetOncanplaythrough);
event_handler!(change, GetOnchange, SetOnchange);
event_handler!(click, GetOnclick, SetOnclick);
event_handler!(close, GetOnclose, SetOnclose);
event_handler!(contextmenu, GetOncontextmenu, SetOncontextmenu);
event_handler!(cuechange, GetOncuechange, SetOncuechange);
event_handler!(dblclick, GetOndblclick, SetOndblclick);
event_handler!(drag, GetOndrag, SetOndrag);
event_handler!(dragend, GetOndragend, SetOndragend);
event_handler!(dragenter, GetOndragenter, SetOndragenter);
event_handler!(dragexit, GetOndragexit, SetOndragexit);
event_handler!(dragleave, GetOndragleave, SetOndragleave);
event_handler!(dragover, GetOndragover, SetOndragover);
event_handler!(dragstart, GetOndragstart, SetOndragstart);
event_handler!(drop, GetOndrop, SetOndrop);
event_handler!(durationchange, GetOndurationchange, SetOndurationchange);
event_handler!(emptied, GetOnemptied, SetOnemptied);
event_handler!(ended, GetOnended, SetOnended);
error_event_handler!(error, GetOnerror, SetOnerror);
event_handler!(formdata, GetOnformdata, SetOnformdata);
event_handler!(input, GetOninput, SetOninput);
event_handler!(invalid, GetOninvalid, SetOninvalid);
event_handler!(keydown, GetOnkeydown, SetOnkeydown);
event_handler!(keypress, GetOnkeypress, SetOnkeypress);
event_handler!(keyup, GetOnkeyup, SetOnkeyup);
event_handler!(loadeddata, GetOnloadeddata, SetOnloadeddata);
event_handler!(loadedmetadata, GetOnloadedmetadata, SetOnloadedmetadata);
event_handler!(loadstart, GetOnloadstart, SetOnloadstart);
event_handler!(mousedown, GetOnmousedown, SetOnmousedown);
event_handler!(mouseenter, GetOnmouseenter, SetOnmouseenter);
event_handler!(mouseleave, GetOnmouseleave, SetOnmouseleave);
event_handler!(mousemove, GetOnmousemove, SetOnmousemove);
event_handler!(mouseout, GetOnmouseout, SetOnmouseout);
event_handler!(mouseover, GetOnmouseover, SetOnmouseover);
event_handler!(mouseup, GetOnmouseup, SetOnmouseup);
event_handler!(wheel, GetOnwheel, SetOnwheel);
event_handler!(pause, GetOnpause, SetOnpause);
event_handler!(play, GetOnplay, SetOnplay);
event_handler!(playing, GetOnplaying, SetOnplaying);
event_handler!(progress, GetOnprogress, SetOnprogress);
event_handler!(ratechange, GetOnratechange, SetOnratechange);
event_handler!(reset, GetOnreset, SetOnreset);
event_handler!(seeked, GetOnseeked, SetOnseeked);
event_handler!(seeking, GetOnseeking, SetOnseeking);
event_handler!(select, GetOnselect, SetOnselect);
event_handler!(show, GetOnshow, SetOnshow);
event_handler!(stalled, GetOnstalled, SetOnstalled);
event_handler!(submit, GetOnsubmit, SetOnsubmit);
event_handler!(suspend, GetOnsuspend, SetOnsuspend);
event_handler!(timeupdate, GetOntimeupdate, SetOntimeupdate);
event_handler!(toggle, GetOntoggle, SetOntoggle);
event_handler!(transitionend, GetOntransitionend, SetOntransitionend);
event_handler!(volumechange, GetOnvolumechange, SetOnvolumechange);
event_handler!(waiting, GetOnwaiting, SetOnwaiting);
)
);

// https://html.spec.whatwg.org/multipage/#windoweventhandlers
// see webidls/EventHandler.webidl
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.