Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MessageEvent.InitMessageEvent #25276

Merged
merged 3 commits into from Dec 18, 2019
Merged

Implement MessageEvent.InitMessageEvent #25276

merged 3 commits into from Dec 18, 2019

Conversation

@kunalmohan
Copy link
Collaborator

kunalmohan commented Dec 13, 2019 •
edited

InitMessageEvent had to be implemented as required by wpt. For this few keys of struct MessageEvent are now wrapped inside DomRefCell wrapper.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #25192 (GitHub issue number if applicable)
  • There are tests for these changes
@highfive
Copy link

highfive commented Dec 13, 2019

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @ferjm (or someone else) soon.
@highfive
Copy link

highfive commented Dec 13, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/messageevent.rs, components/script/dom/webidls/MessageEvent.webidl
  • @KiChjang: components/script/dom/messageevent.rs, components/script/dom/webidls/MessageEvent.webidl
@highfive
Copy link

highfive commented Dec 13, 2019

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@kunalmohan
Copy link
Collaborator Author

kunalmohan commented Dec 13, 2019

I am facing a problem with the build.
./mach check is running successfully, but ./mach build -d fails with (signal: 9, SIGKILL: kill)
@CYBAI
Copy link
Collaborator

CYBAI commented Dec 16, 2019 •
edited

I am facing a problem with the build.
./mach check is running successfully, but ./mach build -d fails with (signal: 9, SIGKILL: kill)

Do you have enough memory or disk space on your machine 👀? Maybe you can try to ./mach clean and ./mach build -d again.
@kunalmohan
Copy link
Collaborator Author

kunalmohan commented Dec 17, 2019

The build is finally successful. I don't think the memory should have been a problem (8GB RAM+ 8GB swap+600GB storage). I rebased my branch on the latest changes and tried ./mach clean which gave an error (issue #24985 ). I also tried ./mach busted this time which returned unknown mach command. So I gave ./mach build -d another shot, and it was successful.
@kunalmohan
Copy link
Collaborator Author

kunalmohan commented Dec 17, 2019

r?@jdm
@highfive highfive assigned jdm and unassigned ferjm Dec 17, 2019
@kunalmohan kunalmohan changed the title [WIP]Implement MessageEvent.InitMessageEvent Implement MessageEvent.InitMessageEvent Dec 17, 2019
@jdm
Copy link
Member

jdm commented Dec 17, 2019

@bors-servo try=wpt
bors-servo added a commit that referenced this pull request Dec 17, 2019
@bors-servo
Auto merge of #25276 - kunalmohan:25192-initMessageEvent, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5c48787 
Implement MessageEvent.InitMessageEvent

<!-- Please describe your changes on the following line: -->
InitMessageEvent had to be implemented as required by wpt. For this few keys of struct `MessageEvent` are now wrapped inside DomRefCell wrapper.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [x] These changes fix #25192  (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 17, 2019

⌛ Trying commit 4274a75 with merge 5c48787...
@kunalmohan
Copy link
Collaborator Author

kunalmohan commented Dec 17, 2019

Sorry, I forgot to update the tests. Is it necessary to run the tests on release build in order to update the tests?
@jdm
Copy link
Member

jdm commented Dec 17, 2019

Usually you can use the results of a debug build to update the tests, but let's wait and see what gets reported from CI.
@bors-servo
Copy link
Contributor

bors-servo commented Dec 17, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Dec 17, 2019 

  ▶ Unexpected subtest result in /html/webappapis/scripting/events/messageevent-constructor.https.html:
  └ PASS [expected FAIL] Default event values
  ▶ Unexpected subtest result in /html/webappapis/scripting/events/messageevent-constructor.https.html:
  └ PASS [expected FAIL] initMessageEvent operation
  ▶ Unexpected subtest result in /html/webappapis/scripting/events/messageevent-constructor.https.html:
  └ PASS [expected FAIL] initMessageEvent operation default parameter values

  ▶ Unexpected subtest result in /html/dom/idlharness.worker.html:
  └ PASS [expected FAIL] MessageEvent interface: operation initMessageEvent(DOMString, boolean, boolean, any, USVString, DOMString, MessageEventSource, [object Object])
  ▶ Unexpected subtest result in /html/dom/idlharness.worker.html:
  └ PASS [expected FAIL] MessageEvent interface: new MessageEvent("message", { data: 5 }) must inherit property "initMessageEvent(DOMString, boolean, boolean, any, USVString, DOMString, MessageEventSource, [object Object])" with the proper type
  ▶ Unexpected subtest result in /html/dom/idlharness.worker.html:
  └ PASS [expected FAIL] MessageEvent interface: calling initMessageEvent(DOMString, boolean, boolean, any, USVString, DOMString, MessageEventSource, [object Object]) on new MessageEvent("message", { data: 5 }) with too few arguments must throw TypeError
  ▶ Unexpected subtest result in /html/dom/idlharness.https.html?exclude=(Document|Window|HTML.*):
  └ PASS [expected FAIL] MessageEvent interface: operation initMessageEvent(DOMString, boolean, boolean, any, USVString, DOMString, MessageEventSource, [object Object])
  ▶ Unexpected subtest result in /html/dom/idlharness.https.html?exclude=(Document|Window|HTML.*):
  └ PASS [expected FAIL] MessageEvent interface: new MessageEvent("message", { data: 5 }) must inherit property "initMessageEvent(DOMString, boolean, boolean, any, USVString, DOMString, MessageEventSource, [object Object])" with the proper type
  ▶ Unexpected subtest result in /html/dom/idlharness.https.html?exclude=(Document|Window|HTML.*):
  └ PASS [expected FAIL] MessageEvent interface: calling initMessageEvent(DOMString, boolean, boolean, any, USVString, DOMString, MessageEventSource, [object Object]) on new MessageEvent("message", { data: 5 }) with too few arguments must throw TypeError
@jdm
Copy link
Member

jdm commented Dec 18, 2019

This is missing changes to tests/wpt/metadata/html/dom/idlharness.https.html.ini and tests/wpt/metadata/html/dom/idlharness.worker.js.ini.
@kunalmohan
Copy link
Collaborator Author

kunalmohan commented Dec 18, 2019

#25192 (comment)
I ran update-wpt for the test mentioned in the above comment and only the file present in the commit was changed.
If I run the command for all the wpt tests a large number of files are getting changed, so should I do that?
@jdm
Copy link
Member

jdm commented Dec 18, 2019

I recommend running tests/wpt/web-platform-tests/html/dom/idlharness.https.html and tests/wpt/web-platform-tests/html/dom/idlharness.worker.js and running update-wpt on the log for those tests.
@bors-servo
Copy link
Contributor

bors-servo commented Dec 18, 2019

⌛ Testing commit b4090cc with merge affcee0...
bors-servo added a commit that referenced this pull request Dec 18, 2019
@bors-servo
Auto merge of #25276 - kunalmohan:25192-initMessageEvent, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
affcee0 
Implement MessageEvent.InitMessageEvent

<!-- Please describe your changes on the following line: -->
InitMessageEvent had to be implemented as required by wpt. For this few keys of struct `MessageEvent` are now wrapped inside DomRefCell wrapper.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [x] These changes fix #25192  (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 18, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Dec 18, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Dec 18, 2019

⌛ Testing commit b4090cc with merge 9a4ef73...
bors-servo added a commit that referenced this pull request Dec 18, 2019
@bors-servo
Auto merge of #25276 - kunalmohan:25192-initMessageEvent, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9a4ef73 
Implement MessageEvent.InitMessageEvent

<!-- Please describe your changes on the following line: -->
InitMessageEvent had to be implemented as required by wpt. For this few keys of struct `MessageEvent` are now wrapped inside DomRefCell wrapper.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [x] These changes fix #25192  (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 18, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Dec 18, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Dec 18, 2019

⌛ Testing commit b4090cc with merge b72aef8...
bors-servo added a commit that referenced this pull request Dec 18, 2019
@bors-servo
Auto merge of #25276 - kunalmohan:25192-initMessageEvent, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b72aef8 
Implement MessageEvent.InitMessageEvent

<!-- Please describe your changes on the following line: -->
InitMessageEvent had to be implemented as required by wpt. For this few keys of struct `MessageEvent` are now wrapped inside DomRefCell wrapper.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [x] These changes fix #25192  (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 18, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Dec 18, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Dec 18, 2019

⌛ Testing commit b4090cc with merge f183d66...
bors-servo added a commit that referenced this pull request Dec 18, 2019
@bors-servo
Auto merge of #25276 - kunalmohan:25192-initMessageEvent, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f183d66 
Implement MessageEvent.InitMessageEvent

<!-- Please describe your changes on the following line: -->
InitMessageEvent had to be implemented as required by wpt. For this few keys of struct `MessageEvent` are now wrapped inside DomRefCell wrapper.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [x] These changes fix #25192  (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 18, 2019

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing f183d66 to master...
@bors-servo bors-servo merged commit b4090cc into servo:master Dec 18, 2019
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@kunalmohan kunalmohan deleted the kunalmohan:25192-initMessageEvent branch Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Implement MessageEvent.initMessageEvent
6 participants
@kunalmohan @highfive @CYBAI @jdm @bors-servo @ferjm
You can’t perform that action at this time.