Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle cursor and hit testing in 2020 #25280

Merged
merged 6 commits into from Dec 13, 2019
Merged

Handle cursor and hit testing in 2020 #25280

merged 6 commits into from Dec 13, 2019
+305 −144

Conversation

@nox
Copy link
Member

nox commented Dec 13, 2019

No description provided.

@nox nox requested a review from SimonSapin Dec 13, 2019
@highfive
Copy link

highfive commented Dec 13, 2019

Heads up! This PR modifies the following files:

  • @emilio: components/style/properties/longhands/inherited_ui.mako.rs
@highfive
Copy link

highfive commented Dec 13, 2019

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@SimonSapin
SimonSapin approved these changes Dec 13, 2019
View changes
Copy link
Member

SimonSapin left a comment

Nicely done!

What do you think of renaming node: OpaqueNode fields in the box tree to dom_node?
@nox nox force-pushed the 2020-hit-test branch from 45b6ecd to e2f7a8c Dec 13, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2019

☔ The latest upstream changes (presumably #25273) made this pull request unmergeable. Please resolve the merge conflicts.
nox added 6 commits Dec 13, 2019
@nox
Enable cursor and pointer-events in 2020
22ea33c
@nox
Add NodeExt::as_opaque
fb1891f
@nox
Introduce BlockLevelJob
b2f6cc7
@nox
Remove the Node type parameter from Contents
47944a3 
We now pass the Node as an argument during DOM traversal in layout.
@nox
Store an OpaqueNode in boxes and fragments
abc2c15
@nox
Handle cursor and hit testing in 2020
Loading status checks…
ace052d
@nox nox force-pushed the 2020-hit-test branch from e2f7a8c to ace052d Dec 13, 2019
@SimonSapin
Copy link
Member

SimonSapin commented Dec 13, 2019

As discussed on IRC the name tag for a field of type OpaqueNode is not my favorite, but oh well.

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2019

📌 Commit ace052d has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2019

⌛ Testing commit ace052d with merge 760b3a2...
bors-servo added a commit that referenced this pull request Dec 13, 2019
@bors-servo
Auto merge of #25280 - servo:2020-hit-test, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
760b3a2 
Handle cursor and hit testing in 2020
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2019

💔 Test failed - status-taskcluster
@jdm
Copy link
Member

jdm commented Dec 13, 2019

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2019

⌛ Testing commit ace052d with merge 0103ab7...
bors-servo added a commit that referenced this pull request Dec 13, 2019
@bors-servo
Auto merge of #25280 - servo:2020-hit-test, r=SimonSapin
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0103ab7 
Handle cursor and hit testing in 2020
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2019

☀️ Test successful - status-taskcluster
Approved by: SimonSapin
Pushing 0103ab7 to master...
@bors-servo bors-servo merged commit ace052d into master Dec 13, 2019
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@bors-servo bors-servo deleted the 2020-hit-test branch Dec 13, 2019
@jdm jdm mentioned this pull request Dec 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonSapin SimonSapin

Assignees

@SimonSapin SimonSapin

Labels
A-layout/2020
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@nox @highfive @bors-servo @SimonSapin @jdm
You can’t perform that action at this time.