style: Sync changes from mozilla-central. #25299

emilio · 2019-12-15T22:01:55Z

See individual commits for details.


        style: convert NS_STYLE_TOP_LAYER_* to an enum class in nsStyleConsts.h

Differential Revision: https://phabricator.services.mozilla.com/D55377


        style: convert NS_STYLE_RUBY_ALIGN_* to an enum class in nsStyleConsts.h

Differential Revision: https://phabricator.services.mozilla.com/D55380


        style: convert NS_STYLE_TEXT_SIZE_ADJUST_* to an enum class in nsStyl…

…eConsts.h Differential Revision: https://phabricator.services.mozilla.com/D55382


        style: convert NS_STYLE_RUBY_POSITION_* to an enum class in nsStyleCo…

…nsts.h Differential Revision: https://phabricator.services.mozilla.com/D55379


        style: Check for border-image-* initial specified values when seriali…

…zing border shorthand. Differential Revision: https://phabricator.services.mozilla.com/D55588


        style: Add support for parsing of the CSS text-underline-position pro…

…perty. Differential Revision: https://phabricator.services.mozilla.com/D54722


        style: Refactor InvalidationMap flags to use bitflags.

Differential Revision: https://phabricator.services.mozilla.com/D55862


        style: Remove layout.css.xul-box-display-values.survive-blockificatio…

…n.enabled. Differential Revision: https://phabricator.services.mozilla.com/D55898

highfive · 2019-12-15T22:02:02Z

Warning

These commits modify style, layout, and gfx code, but no tests are modified. Please consider adding a test!

emilio · 2019-12-15T22:03:01Z

r? for the layout changes @SimonSapin / @nox

I need to squash too.

There's no behavior change for now, but I want to land this to make implementing min() / max() / etc. easier.

emilio · 2019-12-15T22:03:07Z

@bors-servo try


        Auto merge of #25299 - emilio:gecko-sync, r=<try>

style: Sync changes from mozilla-central. See individual commits for details.

bors-servo · 2019-12-15T22:03:12Z

⌛ Trying commit 0200923 with merge ffa9fee...

atouchet · 2019-12-15T22:13:29Z

@emilio if you are updating selectors could you also bump the version for #24574?

bors-servo · 2019-12-15T22:17:22Z

💔 Test failed - status-taskcluster

emilio · 2019-12-15T22:57:47Z

@atouchet will do

emilio · 2019-12-15T23:04:04Z

@bors-servo try

bors-servo · 2019-12-15T23:04:09Z

⌛ Trying commit 2d3e4e7 with merge b1d2836...


        Auto merge of #25299 - emilio:gecko-sync, r=<try>

style: Sync changes from mozilla-central. See individual commits for details.

bors-servo · 2019-12-15T23:45:31Z

💔 Test failed - status-taskcluster

CYBAI · 2019-12-16T01:28:41Z

  ▶ Unexpected subtest result in /css/cssom/border-shorthand-serialization.html:
  └ PASS [expected FAIL] Declaration with border longhands and border-image is not serialized to a border shorthand declaration.


        style: Avoid writing into the empty array header.

Differential Revision: https://phabricator.services.mozilla.com/D55291


        style: Update derive_more.

Differential Revision: https://phabricator.services.mozilla.com/D56043


        style: convert NS_STYLE_ISOLATION_* to an enum class in nsStyleConsts.h.

Differential Revision: https://phabricator.services.mozilla.com/D55378


        Auto merge of #25299 - emilio:gecko-sync, r=emilio,nox

style: Sync changes from mozilla-central. See individual commits for details.

bors-servo · 2019-12-16T14:37:58Z

💔 Test failed - status-taskcluster

CYBAI · 2019-12-16T14:44:28Z

  ▶ TIMEOUT [expected PASS] /css/CSS2/floats-clear/floats-024.xht
  │ 
  │ 
  │ 
  │ 
  │ Shutting down the Constellation after generating an output file or exit flag specified
  └ 18 threads are still running after shutdown (bad).
  ▶ TIMEOUT [expected PASS] /css/CSS2/floats-clear/floats-040.xht
  │ 
  │ 
  │ 
  │ 
  │ Shutting down the Constellation after generating an output file or exit flag specified
  │ 18 threads are still running after shutdown (bad).
  │ 
  │ 
  │ 
  │ Shutting down the Constellation after generating an output file or exit flag specified
  └ 19 threads are still running after shutdown (bad).
  ▶ TIMEOUT [expected FAIL] /css/CSS2/floats-clear/floats-015.xht
  │ 
  │ 
  │ 
  │ 
  │ Shutting down the Constellation after generating an output file or exit flag specified
  └ 18 threads are still running after shutdown (bad).

Looks like #24762 (or #25258?)

jdm · 2019-12-16T14:45:37Z

@bors-servo retry

#24762

jdm · 2019-12-16T14:45:53Z

@bors-servo retry

emilio · 2019-12-16T18:49:15Z

@bors-servo r=emilio,nox

Huh, what's up with bors?

bors-servo · 2019-12-16T18:49:17Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: #25306

bors-servo · 2019-12-16T18:49:18Z

📌 Commit 7513bc2 has been approved by emilio,nox

jdm · 2019-12-16T18:50:20Z

@emilio https://build.servo.org/homu/queue/servo

bors-servo · 2019-12-17T02:51:02Z

⌛ Testing commit 7513bc2 with merge 858b9da...


        Auto merge of #25299 - emilio:gecko-sync, r=emilio,nox

style: Sync changes from mozilla-central. See individual commits for details.

bors-servo · 2019-12-17T04:08:05Z

💔 Test failed - status-taskcluster

jdm · 2019-12-17T04:27:30Z

@bors-servo retry p=2

bors-servo · 2019-12-17T04:51:21Z

⌛ Testing commit 7513bc2 with merge a8b8f46...


        Auto merge of #25299 - emilio:gecko-sync, r=emilio,nox

style: Sync changes from mozilla-central. See individual commits for details.

bors-servo · 2019-12-17T05:08:54Z

☀️ Test successful - status-taskcluster
Approved by: emilio,nox
Pushing a8b8f46 to master...

jeffin143 and others added 8 commits Dec 1, 2019

style: Refactor InvalidationMap flags to use bitflags.

Verified

This commit was signed with a verified signature.

emilio Emilio Cobos Álvarez

GPG key ID: E1152D0994E4BF8A Learn about signing commits

5e7d429

Differential Revision: https://phabricator.services.mozilla.com/D55862

highfive assigned nox Dec 15, 2019

highfive added the S-awaiting-review label Dec 15, 2019

highfive added the S-tests-failed label Dec 15, 2019

highfive removed the S-tests-failed label Dec 15, 2019

highfive added the S-tests-failed label Dec 15, 2019

highfive removed the S-tests-failed label Dec 16, 2019

emilio and others added 3 commits Dec 16, 2019

style: Avoid writing into the empty array header.

80ac4d2

Differential Revision: https://phabricator.services.mozilla.com/D55291

style: Update derive_more.

baa9ac1

Differential Revision: https://phabricator.services.mozilla.com/D56043

style: convert NS_STYLE_ISOLATION_* to an enum class in nsStyleConsts.h.

e944962

Differential Revision: https://phabricator.services.mozilla.com/D55378

highfive added S-tests-failed and removed S-awaiting-merge labels Dec 16, 2019

jdm closed this Dec 16, 2019

jdm reopened this Dec 16, 2019

highfive added S-awaiting-merge and removed S-tests-failed labels Dec 16, 2019

highfive added S-tests-failed and removed S-awaiting-merge labels Dec 17, 2019

highfive added S-awaiting-merge and removed S-tests-failed labels Dec 17, 2019

bors-servo merged commit 7513bc2 into servo:master Dec 17, 2019
2 checks passed

2 checks passed

Community-TC (pull_request) TaskGroup: success
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label Dec 17, 2019

bors-servo mentioned this pull request Dec 17, 2019

Initial implementation of GPUBuffer for WebGPU #25264

Merged

3 of 3 tasks complete

emilio deleted the emilio:gecko-sync branch Feb 10, 2020

servo / servo

style: Sync changes from mozilla-central. #25299

style: Sync changes from mozilla-central. #25299

emilio commented Dec 15, 2019

highfive commented Dec 15, 2019

emilio commented Dec 15, 2019

emilio commented Dec 15, 2019

bors-servo commented Dec 15, 2019

atouchet commented Dec 15, 2019

bors-servo commented Dec 15, 2019

emilio commented Dec 15, 2019

emilio commented Dec 15, 2019

bors-servo commented Dec 15, 2019

bors-servo commented Dec 15, 2019

CYBAI commented Dec 16, 2019

bors-servo commented Dec 16, 2019

CYBAI commented Dec 16, 2019

jdm commented Dec 16, 2019

jdm commented Dec 16, 2019

emilio commented Dec 16, 2019

bors-servo commented Dec 16, 2019

bors-servo commented Dec 16, 2019

jdm commented Dec 16, 2019

bors-servo commented Dec 17, 2019

bors-servo commented Dec 17, 2019

jdm commented Dec 17, 2019 •

edited

bors-servo commented Dec 17, 2019

bors-servo commented Dec 17, 2019

servo / servo

Join GitHub today

style: Sync changes from mozilla-central. #25299

style: Sync changes from mozilla-central. #25299

Conversation

emilio commented Dec 15, 2019

highfive commented Dec 15, 2019

emilio commented Dec 15, 2019

emilio commented Dec 15, 2019

bors-servo commented Dec 15, 2019

atouchet commented Dec 15, 2019

bors-servo commented Dec 15, 2019

emilio commented Dec 15, 2019

emilio commented Dec 15, 2019

bors-servo commented Dec 15, 2019

bors-servo commented Dec 15, 2019

CYBAI commented Dec 16, 2019

bors-servo commented Dec 16, 2019

CYBAI commented Dec 16, 2019

jdm commented Dec 16, 2019

jdm commented Dec 16, 2019

emilio commented Dec 16, 2019

bors-servo commented Dec 16, 2019

bors-servo commented Dec 16, 2019

jdm commented Dec 16, 2019

bors-servo commented Dec 17, 2019

bors-servo commented Dec 17, 2019

jdm commented Dec 17, 2019 • edited

bors-servo commented Dec 17, 2019

bors-servo commented Dec 17, 2019

jdm commented Dec 17, 2019 •

edited