Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `layout-2020` option to the `.servobuild` file #25304

Merged
merged 1 commit into from Dec 17, 2019
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Add `layout-2020` option to the `.servobuild` file

… and `--with-layout-2013` command-line option to disable it.
  • Loading branch information
SimonSapin committed Dec 16, 2019
commit d670b4420afbc6bc05a7c6bb77ca0f60e3f61595
@@ -324,6 +324,7 @@ def resolverelative(category, key):
self.config["build"].setdefault("mode", "")
self.config["build"].setdefault("debug-assertions", False)
self.config["build"].setdefault("debug-mozjs", False)
self.config["build"].setdefault("layout-2020", False)
self.config["build"].setdefault("ccache", "")
self.config["build"].setdefault("rustflags", "")
self.config["build"].setdefault("incremental", None)
@@ -850,6 +851,7 @@ def build_like_command_arguments(decorated_function):
),
CommandArgument('--with-raqote', default=None, action='store_true'),
CommandArgument('--with-layout-2020', default=None, action='store_true'),
CommandArgument('--with-layout-2013', default=None, action='store_true'),
CommandArgument('--without-wgl', default=None, action='store_true'),
]

@@ -888,7 +890,8 @@ def run_cargo_build_like_command(
env=None, verbose=False,
target=None, android=False, magicleap=False, libsimpleservo=False,
features=None, debug_mozjs=False, with_debug_assertions=False,
with_frame_pointer=False, with_raqote=False, with_layout_2020=False, without_wgl=False,
with_frame_pointer=False, with_raqote=False, without_wgl=False,
with_layout_2020=False, with_layout_2013=False,
uwp=False, media_stack=None,
):
env = env or self.build_env()
@@ -928,7 +931,7 @@ def run_cargo_build_like_command(
features.append("canvas2d-raqote")
elif "canvas2d-raqote" not in features:
features.append("canvas2d-azure")
if with_layout_2020 and "layout-2013" not in features:
if with_layout_2020 or (self.config["build"]["layout-2020"] and not with_layout_2013):
features.append("layout-2020")
elif "layout-2020" not in features:
features.append("layout-2013")
@@ -43,6 +43,9 @@ webgl-backtrace = false
# that triggered it.
dom-backtrace = false

# Default to the “2020” implementation of CSS layout instead of the “2013” one.
layout-2020 = false

# Set to the path to your ccache binary to enable caching of compiler outputs
#ccache = "/usr/local/bin/ccache"

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.