Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not wake up embedder on each animation tick #25306

Merged
merged 1 commit into from Dec 16, 2019

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Dec 16, 2019

The constellation should only update the compositor if the animation state actually changed.

@highfive
Copy link

highfive commented Dec 16, 2019

Heads up! This PR modifies the following files:

  • @asajeffrey: components/constellation/pipeline.rs, components/constellation/constellation.rs
  • @cbrewster: components/constellation/pipeline.rs, components/constellation/constellation.rs
  • @KiChjang: components/script_traits/lib.rs
@jdm
Copy link
Member

jdm commented Dec 16, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Dec 16, 2019

📌 Commit 016d9a6 has been approved by jdm

@jdm jdm added this to In progress in Microsoft app store Dec 16, 2019
@jdm
Copy link
Member

jdm commented Dec 16, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Dec 16, 2019

Testing commit 016d9a6 with merge cbb4bb1...

bors-servo added a commit that referenced this pull request Dec 16, 2019
Do not wake up embedder on each animation tick

The constellation should only update the compositor if the animation state actually changed.
@bors-servo
Copy link
Contributor

bors-servo commented Dec 16, 2019

💔 Test failed - status-taskcluster

@jdm
Copy link
Member

jdm commented Dec 16, 2019

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Dec 16, 2019

Testing commit 016d9a6 with merge fb5ab1f...

bors-servo added a commit that referenced this pull request Dec 16, 2019
Do not wake up embedder on each animation tick

The constellation should only update the compositor if the animation state actually changed.
@bors-servo
Copy link
Contributor

bors-servo commented Dec 16, 2019

☀️ Test successful - status-taskcluster
Approved by: jdm
Pushing fb5ab1f to master...

@bors-servo bors-servo merged commit 016d9a6 into servo:master Dec 16, 2019
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@jdm jdm moved this from In progress to Done in Microsoft app store Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.