Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDo not run faster than 60 FPS #25312
Conversation
|
Does this limit Servo to running at 60 FPS? Would it make sense to instead use the display's refresh rate? |
|
If the monitor is cadenced at 120 FPS, it will force Servo to run at 60 FPS. We could rely on https://docs.rs/winit/0.20.0-alpha4/winit/monitor/struct.VideoMode.html#method.refresh_rate We should also maybe only sleep if no call to This is an improvement non the less. |
What about displays that don't run at multiples of 60 (ex. 75, 90, 144, etc.)? |
|
Servo will always run at 60FPS max. This is not the best approach. Open to suggestions. |
|
Using that winit method instead of assuming 60 seems like a reasonable idea to me. |
|
cc @asajeffrey thoughts on this? |
|
Approach seems fine by me but I'm not sure if this is the right way to do this. |
|
Can we avoid blocking the main thread? The embedder may have things they want to do on the main thread at more than 60fps. If nothing else we should make the number 60 configurable, e.g. for devices that run at 120fps. |
|
Closing this as this is starting to look more complex that I initially imagined. See #25305. |
paulrouget commentedDec 17, 2019
Fix #25305